<div dir="ltr">Nastya,<div>according to the template I provided initially [1] format in fuel-qa is invalid. I've requested to support only one format [2].</div><div>File must always have a folder. If you want to cover the whole repo, then the right structure would be</div><div>
<p class="p1"><span class="s1">maintainers:</span></p>
<p class="p2"><span class="s1"></span><br></p>
<p class="p1"><span class="s1">- ./:</span></p>
<p class="p1"><span class="s1"> - name: ...</span></p>
<p class="p1"><span class="s1"> email: ...</span></p>
<p class="p1"><span class="s1"> IRC: ...</span></p></div><div>e.g. you'd just refer to the current folder, which should be root of the repo by default.</div><div>Simon is asking a valid request: if you add his folder in the file, he will be always added to the review request by script, once it's implemented. Only in the case when contribution is made to his particular area of responsibility.</div><div><br></div><div>[1] <a href="https://github.com/openstack/fuel-web/blob/master/MAINTAINERS"><span style="line-height:1.5">https://github.com/openstack/</span><span style="line-height:1.5">fuel-web/blob/master/MAINTAINERS</span></a></div><div>[2] <a href="https://bugs.launchpad.net/fuel/+bug/1497655" target="_blank" style="line-height:1.5">https://bugs.launchpad.net/fuel/+bug/1497655</a></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 20, 2015 at 11:03 PM Anastasia Urlapova <<a href="mailto:aurlapova@mirantis.com">aurlapova@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Simon,</div><div>structure of fuel-web repo is much more complex than fuel-qa, ~ 50 active contributors work with fuel-web.</div><div>There is the functionality of the different Fuel domains and each requires its own expertise, so maintenance is divided by folders.</div><div>In case of fuel-qa maintainers are doing review for whole repository, structure of file[0] is correct.</div><div><br></div><div><br></div><div>Nastya.</div><div>[0] <a href="https://github.com/openstack/fuel-qa/blob/master/MAINTAINERS" target="_blank">https://github.com/openstack/fuel-qa/blob/master/MAINTAINERS</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 21, 2015 at 2:15 AM, Mike Scherbakov <span dir="ltr"><<a href="mailto:mscherbakov@mirantis.com" target="_blank">mscherbakov@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Simon,<div>I believe that it's a mistake in fuel-qa. Valid structure is in fuel-web. Please fix the one in fuel-qa.</div><div><br></div><div>I'm also looking forward for automated adding of people to review requests based on this file. Here is the task to track it: <a href="https://bugs.launchpad.net/fuel/+bug/1497655" target="_blank">https://bugs.launchpad.net/fuel/+bug/1497655</a></div></div><div><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 20, 2015 at 2:10 AM Simon Pasquier <<a href="mailto:spasquier@mirantis.com" target="_blank">spasquier@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Thanks for the reply, Andrew! I must admit that I haven't read thoroughly the specification on the new team structure [1]. IIUC plugin developers should be added to the MAINTAINERS file of fuel-qa for the directories that concern their plugins. If I take LMA as an example, this would be:<br>fuelweb_test/tests/plugins/plugin_elasticsearch<br>fuelweb_test/tests/plugins/plugin_lma_collector<br>fuelweb_test/tests/plugins/plugin_lma_infra_alerting<br><br></div><div>Is that right?<br><br>I can submit a change to fuel-qa for adding the LMA team to the MAINTAINERS file but I can't figure out the structure of the YAML data: fuel-web/MAINTAINERS [2] is organized as "{directory1: [maintainer1, maintainer2, ...], directory2: [...], ...}" while for fuel-qa [3] (and other Fuel projects), it's "[maintainer1, maintainer2, ...]".<br></div><div><br></div><div>BR,</div>Simon<br><div><br>[1] <a href="http://specs.fuel-infra.org/fuel-specs-master/policy/team-structure.html" target="_blank">http://specs.fuel-infra.org/fuel-specs-master/policy/team-structure.html</a><br>[2] <a href="https://github.com/openstack/fuel-web/blob/master/MAINTAINERS" target="_blank">https://github.com/openstack/fuel-web/blob/master/MAINTAINERS</a><br>[3] <a href="https://github.com/openstack/fuel-qa/blob/master/MAINTAINERS" target="_blank">https://github.com/openstack/fuel-qa/blob/master/MAINTAINERS</a></div></div><div dir="ltr"><div><br><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 17, 2015 at 2:21 AM, Andrew Woodward <span dir="ltr"><<a href="mailto:xarses@gmail.com" target="_blank">xarses@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">We have already discussed this to be a result of describing data driven testing, untill this spec is completed there is little sense to remove all of these since fuel-qa is 100% required to operate this way. In the interim we should just specify the appropriate SME with the MAINTAINERS file.</div><div><div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 16, 2015 at 11:34 AM Sergii Golovatiuk <<a href="mailto:sgolovatiuk@mirantis.com" target="_blank">sgolovatiuk@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Tests should be in plugin </div><div class="gmail_extra"><br clear="all"><div><div><div dir="ltr">--<br>
Best regards,<br>
Sergii Golovatiuk,<br>
Skype #golserge<br>
IRC #holser<br></div></div></div></div><div class="gmail_extra">
<br><div class="gmail_quote">On Fri, Oct 16, 2015 at 5:58 PM, Simon Pasquier <span dir="ltr"><<a href="mailto:spasquier@mirantis.com" target="_blank">spasquier@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hello Alexey,<br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Oct 16, 2015 at 5:35 PM, Alexey Elagin <span dir="ltr"><<a href="mailto:aelagin@mirantis.com" target="_blank">aelagin@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Simon!<br>
<br>
We are going to remove plugins' functional tests from fuel-qa because this tests don't use for our plugins CI process.<br></blockquote><div><br></div></span><div>And where are the existing tests going to be stored then?<br><br></div><div>Thanks,<br></div><div>Simon<br></div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></span></div><br></div></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div></div></div><span><font color="#888888"><div dir="ltr">-- <br></div><div dir="ltr"><p dir="ltr">--</p><p dir="ltr"><span style="font-size:13.2px">Andrew Woodward</span></p><p dir="ltr"><span style="font-size:13.2px">Mirantis</span></p><p dir="ltr"><span style="font-size:13.2px">Fuel Community Ambassador</span></p><p dir="ltr"><span style="font-size:13.2px">Ceph Community</span></p>
</div>
</font></span><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div></div></div></div></div></div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><div dir="ltr">-- <br></div></div></div><span><font color="#888888"><div dir="ltr">Mike Scherbakov<br>#mihgen</div>
</font></span><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><div dir="ltr">-- <br></div><div dir="ltr">Mike Scherbakov<br>#mihgen</div>