<div dir="ltr">I think it will be better if you can submit a spec for your proposal, it will be easier for people to give comment.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 14, 2015 at 10:05 AM, Tang Chen <span dir="ltr"><<a href="mailto:tangchen@cn.fujitsu.com" target="_blank">tangchen@cn.fujitsu.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi, all,<br>
<br>
Please help to review this BP.<br>
<br>
<a href="https://blueprints.launchpad.net/nova/+spec/live-migration-state-machine" target="_blank">https://blueprints.launchpad.net/nova/+spec/live-migration-state-machine</a><br>
<br>
<br>
Currently, the migration_status field in Migration object is
indicating the <br>
status of migration process. But in the current code, it is
represented <br>
by pure string, like 'migrating', 'finished', and so on.<br>
<br>
The strings could be confusing to different developers, e.g. there
are 3 <br>
statuses representing the migration process is over successfully: <br>
'finished', 'completed' and 'done'. <br>
And 2 for migration in process: 'running' and 'migrating'.<br>
<br>
So I think we should use constants or enum for these statuses.<br>
<br>
<br>
Furthermore, Nikola has proposed to create a state machine for the
statuses, <br>
which is part of another abandoned BP. And this is also the work I'd
like to go <br>
on with. Please refer to:<br>
<a rel="nofollow" href="https://review.openstack.org/#/c/197668/" style="color:rgb(0,51,170);text-decoration:none;font-family:sans-serif;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:18px;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)" target="_blank">https://review.openstack.org/#/c/197668/</a><br style="color:rgb(51,51,51);font-family:sans-serif;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:18px;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">
<a rel="nofollow" href="https://review.openstack.org/#/c/197669/" style="color:rgb(0,51,170);text-decoration:none;font-family:sans-serif;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:18px;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)" target="_blank">https://review.openstack.org/#/c/197669/</a><br>
<br>
<br>
Another proposal is: introduce a new member named "state" into
Migration.<br>
Use a state machine to handle this Migration.state, and leave
migration_status <br>
field a
descriptive human readable free-form. <br>
<br>
<br>
So how do you think ?<br>
<br>
Thanks.<br>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>