<div dir="ltr">Hi neutrinos,<div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">One of the areas I would like to work on during the Mitaka cycle is 'consistency' [1].</span><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">We've grown quite a bit during the last cycle and we need to make sure we are on the same page when it comes to code quality and reviews, and at the same time speeding up review velocity without compromising stability [2].</span><br></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">This is the reason why I started the 'Effective Neutron' guide [3], with the hope that we could start collating pills of wisdom that we identify during Neutron reviews, and capture lessons learned from regressions we may experience post merge.</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">To this aim, I would invite people to start collectively add content to the guide. If you use the 'effective' tag [4], then it's easier to set them apart from the rest, for speedy review.</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">If you are stumbling upon a bad pattern and you want to clean that up (like Cedric did in [5]), adding a tip at the same time of the patch is also ok, unless you pinky-swear you'll do that as follow up (the effective guide is available from Liberty, so backports may cause a conflict should you want to go back to Kilo). </span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Cheers,</span></div><div><span style="font-size:12.8px">Armando</span></div><div><br></div><div>[1] <a href="http://git.openstack.org/cgit/openstack/election/tree/candidates/mitaka/Neutron/Armando_Migliaccio.txt#n33" target="_blank">http://git.openstack.org/cgit/openstack/election/tree/candidates/mitaka/Neutron/Armando_Migliaccio.txt#n33</a></div><div>[2] <a href="http://git.openstack.org/cgit/openstack/election/tree/candidates/mitaka/Neutron/Armando_Migliaccio.txt#n25" target="_blank">http://git.openstack.org/cgit/openstack/election/tree/candidates/mitaka/Neutron/Armando_Migliaccio.txt#n25</a><br><div>[3] <a href="http://docs.openstack.org/developer/neutron/devref/effective_neutron.html" target="_blank">http://docs.openstack.org/developer/neutron/devref/effective_neutron.html</a></div><div>[4] <a href="https://review.openstack.org/#/q/project:openstack/neutron+topic:effective,n,z" target="_blank">https://review.openstack.org/#/q/project:openstack/neutron+topic:effective,n,z</a></div><div>[5] <a href="https://review.openstack.org/#/c/230823/" target="_blank">https://review.openstack.org/#/c/230823/</a></div></div></div>