<div dir="ltr"><br><div class="gmail_extra"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div style="font-family:arial;font-size:small"><span style="font-family:arial,sans-serif">On Wed, Sep 30, 2015 at 11:24 PM, Jeff Peeler </span><span dir="ltr" style="font-family:arial,sans-serif"><<a href="mailto:jpeeler@redhat.com" target="_blank">jpeeler@redhat.com</a>></span><span style="font-family:arial,sans-serif"> wrote:</span><br></div></div></div></div></div></div></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The patch I just submitted[1] modifies the syntax of all.yml to use<br>
dictionaries, which changes how variables are referenced. The key<br>
point being in globals.yml, the overriding of a variable will change<br>
from simply specifying the variable to using the dictionary value:<br>
<br>
old:<br>
api_interface: 'eth0'<br>
<br>
new:<br>
network:<br>
    api_interface: 'eth0'<br>
<br></blockquote><div>This looks good.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Preliminary feedback on IRC sounded positive, so I'll go ahead and<br>
work on finishing the review immediately assuming that we'll go<br>
forward. Please ping me if you hate this change so that I can stop the<br>
work.<br>
<br>
[1] <a href="https://review.openstack.org/#/c/229535/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/229535/</a><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div></div>