<div dir="ltr">+1 for <=80 chars. It will be uniform with the existing coding style.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 25, 2015 at 8:22 PM, Dmitry Tantsur <span dir="ltr"><<a href="mailto:dtantsur@redhat.com" target="_blank">dtantsur@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 09/25/2015 04:44 PM, Ihar Hrachyshka wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
releases are approaching, so it’s the right time to start some bike shedding on the mailing list.<br>
<br>
Recently I got pointed out several times [1][2] that I violate our commit message requirement [3] for the message lines that says: "Subsequent lines should be wrapped at 72 characters.”<br>
<br>
I agree that very long commit message lines can be bad, f.e. if they are 200+ chars. But <= 79 chars?.. Don’t think so. Especially since we have 79 chars limit for the code.<br>
<br>
We had a check for the line lengths in openstack-dev/hacking before but it was killed [4] as per openstack-dev@ discussion [5].<br>
<br>
I believe commit message lines of <=80 chars are absolutely fine and should not get -1 treatment. I propose to raise the limit for the guideline on wiki accordingly.<br>
</blockquote>
<br></span>
+1, I never understood it actually. I know some folks even question 80 chars for the code, so having 72 chars for commit messages looks a bit weird to me.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
Comments?<br>
<br>
[1]: <a href="https://review.openstack.org/#/c/224728/6//COMMIT_MSG" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/224728/6//COMMIT_MSG</a><br>
[2]: <a href="https://review.openstack.org/#/c/227319/2//COMMIT_MSG" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/227319/2//COMMIT_MSG</a><br>
[3]: <a href="https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure" rel="noreferrer" target="_blank">https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure</a><br>
[4]: <a href="https://review.openstack.org/#/c/142585/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/142585/</a><br>
[5]: <a href="http://lists.openstack.org/pipermail/openstack-dev/2014-December/thread.html#52519" rel="noreferrer" target="_blank">http://lists.openstack.org/pipermail/openstack-dev/2014-December/thread.html#52519</a><br>
<br>
Ihar<br>
<br>
<br>
<br></span>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</blockquote>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div>