<div dir="ltr">Hello Joshua, thank you for your feedback.<div><br></div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:12.8px">This will end up on </span><a href="http://review.openstack.org/" rel="noreferrer" target="_blank" style="font-size:12.8px">review.openstack.org</a><span style="font-size:12.8px"> right so that it can be properly reviewed (it will likely take a while since it looks to be ~1000+ lines of code)?</span></blockquote><div> </div><div>Yes, sure I will send this patch to <span style="font-size:12.8px"> </span><a href="http://review.openstack.org/" rel="noreferrer" target="_blank" style="font-size:12.8px">review.openstack.org</a>, but first of all I need to get merged devstack patch (<a href="https://review.openstack.org/#/c/226348/" rel="noreferrer" target="_blank" style="font-size:12.8px">https://review.openstack.org/#/c/226348/</a>).</div><div>Then I will add gate jobs with testing new driver using devstack. And the will send pika driver patch to review.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:12.8px">Also suggestion, before that merges, can docs be added, seems like very little docstrings about what/why/how. For sustainability purposes that would be appreciated I think.</span></blockquote><div><br></div><div>Ok. Will add.</div><div><br></div><div>On Fri, Sep 25, 2015 at 6:58 PM, Joshua Harlow <span dir="ltr"><<a href="mailto:harlowja@outlook.com" target="_blank">harlowja@outlook.com</a>></span> wrote:<br></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Also a side question, that someone might know,<br>
<br>
Whatever happened to the folks from rabbitmq (incorporated? pivotal?) who were going to get involved in oslo.messaging, did that ever happen; if anyone knows?<br>
<br>
They might be a good bunch of people to review such a pika driver (since I think they as a corporation created pika?).<br>
<br>
Dmitriy Ukhlov wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div class="h5">
Hello stackers,<br>
<br>
I'm working on new olso.messaging RabbitMQ driver implementation which<br>
uses pika client library instead of kombu. It related to<br>
<a href="https://blueprints.launchpad.net/oslo.messaging/+spec/rabbit-pika" rel="noreferrer" target="_blank">https://blueprints.launchpad.net/oslo.messaging/+spec/rabbit-pika</a>.<br>
In this letter I want to share current results and probably get first<br>
feedack from you.<br>
Now code is availabe here:<br>
<a href="https://github.com/dukhlov/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_pika.py" rel="noreferrer" target="_blank">https://github.com/dukhlov/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_pika.py</a><br>
<br>
Current status of this code:<br>
- pika driver passes functional tests<br>
- pika driver tempest smoke tests<br>
- pika driver passes almost all tempest full tests (except 5) but it<br>
seems that reason is not related to oslo.messaging<br>
Also I created small devstack patch to support pika driver testing on<br>
gate (<a href="https://review.openstack.org/#/c/226348/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/226348/</a>)<br>
<br>
Next steps:<br>
- communicate with Manish (blueprint owner)<br>
- write spec to this blueprint<br>
- send a review with this patch when spec and devstack patch get merged.<br>
<br>
Thank you.<br>
<br>
<br>
--<br>
Best regards,<br>
Dmitriy Ukhlov<br>
Mirantis Inc.<br>
<br></div></div><span class="">
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</span></blockquote><div class=""><div class="h5">
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div>Best regards,<br></div>Dmitriy Ukhlov<br></div>Mirantis Inc.<br></div></div>
</div></div>