<div dir="ltr"><span style="font-size:12.8px">+1 for <=80 chars. </span><span style="font-size:12.8px">72 characters sometimes are not enough</span><br><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature">Regards,<br>Ivan Kolodyazhny</div></div>
<br><div class="gmail_quote">On Fri, Sep 25, 2015 at 6:05 PM, Doug Hellmann <span dir="ltr"><<a href="mailto:doug@doughellmann.com" target="_blank">doug@doughellmann.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">git tools such as git log and git show indent the commit message in<br>
their output, so you don't actually have the full 79/80 character width<br>
to work with. That's where the 72 comes from.<br>
<br>
Doug<br>
<br>
Excerpts from Vikram Choudhary's message of 2015-09-25 20:25:41 +0530:<br>
<div class="HOEnZb"><div class="h5">> +1 for <=80 chars. It will be uniform with the existing coding style.<br>
><br>
> On Fri, Sep 25, 2015 at 8:22 PM, Dmitry Tantsur <<a href="mailto:dtantsur@redhat.com">dtantsur@redhat.com</a>> wrote:<br>
><br>
> > On 09/25/2015 04:44 PM, Ihar Hrachyshka wrote:<br>
> ><br>
> >> Hi all,<br>
> >><br>
> >> releases are approaching, so it’s the right time to start some bike<br>
> >> shedding on the mailing list.<br>
> >><br>
> >> Recently I got pointed out several times [1][2] that I violate our commit<br>
> >> message requirement [3] for the message lines that says: "Subsequent lines<br>
> >> should be wrapped at 72 characters.”<br>
> >><br>
> >> I agree that very long commit message lines can be bad, f.e. if they are<br>
> >> 200+ chars. But <= 79 chars?.. Don’t think so. Especially since we have 79<br>
> >> chars limit for the code.<br>
> >><br>
> >> We had a check for the line lengths in openstack-dev/hacking before but<br>
> >> it was killed [4] as per openstack-dev@ discussion [5].<br>
> >><br>
> >> I believe commit message lines of <=80 chars are absolutely fine and<br>
> >> should not get -1 treatment. I propose to raise the limit for the guideline<br>
> >> on wiki accordingly.<br>
> >><br>
> ><br>
> > +1, I never understood it actually. I know some folks even question 80<br>
> > chars for the code, so having 72 chars for commit messages looks a bit<br>
> > weird to me.<br>
> ><br>
> ><br>
> >> Comments?<br>
> >><br>
> >> [1]: <a href="https://review.openstack.org/#/c/224728/6//COMMIT_MSG" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/224728/6//COMMIT_MSG</a><br>
> >> [2]: <a href="https://review.openstack.org/#/c/227319/2//COMMIT_MSG" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/227319/2//COMMIT_MSG</a><br>
> >> [3]:<br>
> >> <a href="https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure" rel="noreferrer" target="_blank">https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure</a><br>
> >> [4]: <a href="https://review.openstack.org/#/c/142585/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/142585/</a><br>
> >> [5]:<br>
> >> <a href="http://lists.openstack.org/pipermail/openstack-dev/2014-December/thread.html#52519" rel="noreferrer" target="_blank">http://lists.openstack.org/pipermail/openstack-dev/2014-December/thread.html#52519</a><br>
> >><br>
> >> Ihar<br>
> >><br>
> >><br>
> >><br>
> >> __________________________________________________________________________<br>
> >> OpenStack Development Mailing List (not for usage questions)<br>
> >> Unsubscribe:<br>
> >> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> >> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
> >><br>
> >><br>
> ><br>
> > __________________________________________________________________________<br>
> > OpenStack Development Mailing List (not for usage questions)<br>
> > Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
> ><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>