<div dir="ltr"><div>Hi everyone!<br><br></div><div>I agree that wrong order of arguments misleads while debugging errors, BUT how we can prevent regression? Imo, this is not a good idea to make patches like <a href="https://review.openstack.org/#/c/64415/">https://review.openstack.org/#/c/64415/</a> in each release(without check in CI, such patches are redundant).<br><br></div><div><br></div>PS: This question relates not only for murano.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 24, 2015 at 11:48 AM, Kekane, Abhishek <span dir="ltr"><<a href="mailto:Abhishek.Kekane@nttdata.com" target="_blank">Abhishek.Kekane@nttdata.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
There is a bug for this, you can add murano projects to this bug.<br>
<br>
<a href="https://bugs.launchpad.net/heat/+bug/1259292" rel="noreferrer" target="_blank">https://bugs.launchpad.net/heat/+bug/1259292</a><br>
<br>
Thanks,<br>
<br>
Abhishek Kekane<br>
<div><div class="h5"><br>
-----Original Message-----<br>
From: Bulat Gaifullin [mailto:<a href="mailto:bgaifullin@mirantis.com">bgaifullin@mirantis.com</a>]<br>
Sent: 24 September 2015 13:29<br>
To: OpenStack Development Mailing List (not for usage questions)<br>
Subject: Re: [openstack-dev] [murano] Fix order of arguments in assertEqual<br>
<br>
+1<br>
<br>
> On 24 Sep 2015, at 10:45, Tetiana Lashchova <<a href="mailto:tlashchova@mirantis.com">tlashchova@mirantis.com</a>> wrote:<br>
><br>
> Hi folks!<br>
><br>
> Some tests in murano code use incorrect order of arguments in assertEqual.<br>
> The correct order expected by the testtools is<br>
><br>
> def assertEqual(self, expected, observed, message=''):<br>
> """Assert that 'expected' is equal to 'observed'.<br>
><br>
> :param expected: The expected value.<br>
> :param observed: The observed value.<br>
> :param message: An optional message to include in the error.<br>
> """<br>
><br>
> Error message has the following format:<br>
><br>
> raise mismatch_error<br>
> testtools.matchers._impl.MismatchError: !=:<br>
> reference = <expected value><br>
> actual = <observed value><br>
><br>
> Use of arguments in incorrect order could make debug output very confusing.<br>
> Let's fix it to make debugging easier.<br>
><br>
> Best regards,<br>
> Tetiana Lashchova<br>
> ______________________________________________________________________<br>
</div></div>> ____ OpenStack Development Mailing List (not for usage questions)<br>
<span class="">> Unsubscribe:<br>
> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</span>______________________________________________________________________<br>
Disclaimer: This email and any attachments are sent in strictest confidence<br>
for the sole use of the addressee and may contain legally privileged,<br>
confidential, and proprietary data. If you are not the intended recipient,<br>
please advise the sender by replying promptly to this email and then delete<br>
and destroy this email and any attachments without any further use, copying<br>
or forwarding.<br>
<div class="HOEnZb"><div class="h5"><br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Best regards,<br>Andrey Kurilin.<br></div></div>
</div>