<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 14, 2015 at 10:00 AM, Flavio Percoco <span dir="ltr"><<a href="mailto:flavio@redhat.com" target="_blank">flavio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 14/08/15 10:42 -0400, Assaf Muller wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
First I'd like to say that I recognize that this discussion is incredibly<br>
personal. Brandon and Russell, please do not be offended, but I know that I<br>
probably would be if this very public thread involved myself. That being said,<br>
please know that from my perspective this is *not* personal, rather I see this<br>
as a general discussion about the precedent that we are creating here.<br>
<br>
Responses in-line.<br>
<br>
On Fri, Aug 14, 2015 at 9:32 AM, Kyle Mestery <<a href="mailto:mestery@mestery.com" target="_blank">mestery@mestery.com</a>> wrote:<br>
<br>
On Fri, Aug 14, 2015 at 6:29 AM, Ihar Hrachyshka <<a href="mailto:ihrachys@redhat.com" target="_blank">ihrachys@redhat.com</a>><br>
wrote:<br></span><span class="">
it feels to me that leaving neutron-core group as a "meta-group" that<br>
includes everyone who makes significant positive impact in any of<br>
those repos is not optimal. <br>
<br>
This is where I'd disagree. I think in general teams pay too much attention<br>
to stats, which are incredibly easy to game. Case in point, with the<br>
current objections people have over Brandon and Russell being nominated, I<br>
could have waited 4-6 weeks and let them amass a plethora of review stats,<br>
but what would the point of that have been?<br>
<br>
<br>
None what so ever. I think the point here is that if someone is focusing on<br>
another project then it's debatable if they should become a core in the Neutron<br>
project itself. Very simply put, if someone is a core in a subproject and is<br>
doing a fantastic job, but that person is not truly involved in the Neutron<br>
project itself, then that person becoming core in Neutron to me is dangerous.<br>
Before someone becomes core, I would like to be familiar with their expertise<br>
in Neutron so that I know if to trust their +2 or not on a given area in<br>
Neutron. If that person didn't really focus on Neutron then I have no way of<br>
being familiar with their expertise, thus no ability to trust them even if I'm<br>
generally a trusting person.<br>
</span></blockquote>
<br>
I'm not really familiar with Neutron's workflow but as an outsider and<br>
also based on my experience from other projects, the separation of<br>
concerns from a review perspective is very useful. Teams that govern<br>
several projects are be better off giving reviewing rights to folks<br>
in a per-project basis rather than doing it cross-team.<br>
<br>
I'd go as far as saying that folks with review rights in the server<br>
don't necessarily need to have review rights in smaller projects. The<br>
reason I'm saying this is because I believe that reviewer rights is<br>
not a prize but a volunteer job. The moment I'm asked whether I want<br>
to join a reviewers team in a project, I gotta be honest with what my<br>
available time will allow me to do.<br>
<br></blockquote><div><br></div><div>What you just said is what I've been trying to emphasize my entire time as PTL: Reviewing is a duty, not a prize. The thing we're discussing here is the issue of when to give someone +2 rights. I'm arguing in favor of a web of trust system, which is what we have with Lieutenants. I'm also saying that I'm a proponent of elevating folks who want to take on the duty and letting them do that before they spend a month building up stats. This is not an opinion shared by everyone I realize, but it's my opinion.<br><br></div><div>Like I've said in this thread, the entire system is built on trust. We as a community need to trust more and rely on that trust. I feel as if I've spent my PTL time trying to build that up and instill this value into the Neutron community. The results speak for themselves at this point, but I'm proud of what *we* as a community have built here.<br><br></div><div>Kyle<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
To what I just said, I'd also add the familiarity with the code-base,<br>
etc.<br>
<br>
Just my $0.02,<br>
Flavio<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
<br>
-- <br>
@flaper87<br>
Flavio Percoco<br>
</font></span><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>