<div dir="ltr">If you want a quick visual diff of this, you can click on "Files changed" here: <a href="https://github.com/openstack/neutron/compare/feature/qos">https://github.com/openstack/neutron/compare/feature/qos</a> </div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 12, 2015 at 12:55 PM, Ihar Hrachyshka <span dir="ltr"><<a href="mailto:ihrachys@redhat.com" target="_blank">ihrachys@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256<br>
<br>
Hi all,<br>
<br>
with great pleasure, I want to request a coordinated review for<br>
merging feature/qos branch back to master:<br>
<br>
<a href="https://review.openstack.org/#/c/212170/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/212170/</a><br>
<br>
Since it's a merge patch, gerrit fails to show the whole diff that it<br>
introduces into master. To get over it, fetch the patch:<br>
<br>
$ git review -d 212170<br>
<br>
and then check the difference:<br>
<br>
$ git fetch origin && git diff origin/master...<br>
<br>
I think we should stick to review process originally suggested at [1].<br>
Specifically, since it's not reasonable to expect the whole feature<br>
branch to be reviewed by a single person, I hope multiple people will<br>
assign themselves to the job and split the pieces to review based on<br>
devref document that describes the feature [2] (Note that a new RPC<br>
push/pull mechanism is described in a separate devref section [3]).<br>
<br>
Note that we don't expect to tackle all review comments, however tiny,<br>
in feature/qos. We are happy to handle major flaws there, but for<br>
minor stuff, it's good to proceed in master. Nevertheless we are happy<br>
to get minors too and collect them for post-merge.<br>
<br>
Things we have in the tree:<br>
<br>
- - server: QoS API extension; QoS core resource extension; QoS ML2<br>
extension driver; QoS versioned objects + base for new objects; QoS<br>
supported rule types mechanism for ML2; QoS notification drivers<br>
mechanism to update SDN controllers;<br>
<br>
- - RPC: new push/pull mechanisms for versioned objects to propagate QoS<br>
objects into the agents;<br>
<br>
- - agent side: new L2 agent extensions mechanism, integrated into OVS<br>
and SR-IOV agents; QoS l2 agent extension; OVS and SR-IOV QoS drivers;<br>
ovs_lib and pci_lib changes.<br>
<br>
I suggest to split review into following logical pieces:<br>
<br>
- - API controller + service plugin + API tests;<br>
- - Versioned objects: neutron.objects.*<br>
- - ML2: supported_qos_rule_types mechanism, extension driver, update<br>
for get_device_details payload;<br>
- - RPC mechanism (push/pull), resource manager, registries +<br>
notification drivers integration;<br>
- - l2 extensions (manager, base interface) + qos extension;<br>
- - OVS integration with extension manager + OVS QoS driver + ovs_lib<br>
changes;<br>
- - SR-IOV agent integration with extension manager + SR-IOV QoS driver<br>
+ pci_lib changes;<br>
- - functional tests.<br>
<br>
We will also need to update the spec:<br>
<a href="https://review.openstack.org/#/c/199112/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/199112/</a><br>
<br>
Included test coverage:<br>
<br>
- - unit tests;<br>
- - API tests;<br>
- - functional tests (more scenarios to come in master);<br>
- - fullstack tests [4] (not in the tree since we need to merge client<br>
and base fullstack patches first).<br>
<br>
We have client patches up for review [5][6] and expect them to go in<br>
after merge of server component.<br>
<br>
We hope that we'll make fullstack in before closing the blueprint in<br>
this cycle.<br>
<br>
[1]:<br>
<a href="http://lists.openstack.org/pipermail/openstack-dev/2015-July/069188.html" rel="noreferrer" target="_blank">http://lists.openstack.org/pipermail/openstack-dev/2015-July/069188.html</a><br>
[2]:<br>
<a href="http://git.openstack.org/cgit/openstack/neutron/tree/doc/source/devref/q
uality_of_service.rst?h=feature/qos" rel="noreferrer" target="_blank">http://git.openstack.org/cgit/openstack/neutron/tree/doc/source/devref/q<br>
uality_of_service.rst?h=feature/qos</a><br>
[3]:<br>
<a href="http://git.openstack.org/cgit/openstack/neutron/tree/doc/source/devref/r
pc_callbacks.rst?h=feature/qos" rel="noreferrer" target="_blank">http://git.openstack.org/cgit/openstack/neutron/tree/doc/source/devref/r<br>
pc_callbacks.rst?h=feature/qos</a><br>
[4]: <a href="https://review.openstack.org/202492" rel="noreferrer" target="_blank">https://review.openstack.org/202492</a><br>
[5]: <a href="https://review.openstack.org/189655" rel="noreferrer" target="_blank">https://review.openstack.org/189655</a><br>
[6]: <a href="https://review.openstack.org/198277" rel="noreferrer" target="_blank">https://review.openstack.org/198277</a><br>
[7]: <a href="https://review.openstack.org/202061" rel="noreferrer" target="_blank">https://review.openstack.org/202061</a><br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2<br>
<br>
iQEcBAEBCAAGBQJVy6TPAAoJEC5aWaUY1u574v0IAOFOH09+cwhv8eEORyHF8kaK<br>
RTYGFefnjCD2BdXJ1bXBhyPMm9CoFbNpAW+zG9l9SaQ7aGvd3yE3bgqlp75qMK8Q<br>
8dW7HuC/pM/VTlrFg1dqZFwHiNYnqxTdoXgrviI8YWXFpfHUDvPIlVkfFRwurX6J<br>
YjHlJEh0VLSI4ungkTNg7Hljwlx4pDMzIB8dVrhGRTRcop4QMpqW+XG6DQVCiW/l<br>
XeUNkAE57H9phkyFQKJFzazYCN2HyOpADZqCrw7vQsUWbFR0LSwbbWy3bkYN9V0D<br>
CV4JTypmHsE+uMV1OaQ+PqPu0NhJw+S7B75QeouVJjltz4VdCWlV8qxSPiFMH4s=<br>
=kfhT<br>
-----END PGP SIGNATURE-----<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div>Kevin Benton</div></div>
</div>