<div dir="ltr">Mike,<div><br></div><div>Sounds great! +1 to fix the code. </div><div><br></div><div>-- dims</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 7, 2015 at 9:55 PM, Mike Bayer <span dir="ltr"><<a href="mailto:mbayer@redhat.com" target="_blank">mbayer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div>On 8/7/15 8:00 PM, Davanum Srinivas
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Mike,
<div><br>
</div>
<div>I edited my nova tox.ini like so:</div>
<div><a href="http://paste.openstack.org/show/412245/" target="_blank">http://paste.openstack.org/show/412245/</a><br>
</div>
<div><br>
</div>
<div>and it seems to be working for me:</div>
<div><a href="http://paste.openstack.org/show/412246/" target="_blank">http://paste.openstack.org/show/412246/</a><br>
</div>
</div>
</blockquote>
OK I can see why the gate passes, the error is exposed only by
Alembic 0.8, because the Column() in the remove operation has no
Table associated with it. <br>
<br>
But the code is still wrong and should be fixed. <br>
<br>
<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>-- dims</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Aug 7, 2015 at 6:42 PM, Mike
Bayer <span dir="ltr"><<a href="mailto:mbayer@redhat.com" target="_blank">mbayer@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Just a
heads up that this recently merged code is wrong:<br>
<br>
<a href="https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm</a><br>
<br>
and here it is failing tests on my local env, as it does on
my CI, as would be expected, there's a lot more if I keep it
running:<br>
<br>
<a href="http://paste.openstack.org/show/412236/" rel="noreferrer" target="_blank">http://paste.openstack.org/show/412236/</a><br>
<br>
However, utterly weirdly, all those tests *pass* with the
same versions of everything in the gate:<br>
<br>
<a href="http://paste.openstack.org/show/412236/" rel="noreferrer" target="_blank">http://paste.openstack.org/show/412236/</a><br>
<br>
<br>
I have no idea why this is. This might be on the oslo.db
side within the test_migrations logic, not really sure.
If someone feels like digging in, that would be great.<br>
<br>
The failure occurs with both Alembic 0.7.7 and Alembic 0.8
as yet unreleased. I have a feeling that releasing Alembic
0.8 may or may not bump this failure to be more widespread,
just because of its apparent heisenbuggy nature, and I'm
really hoping to release 0.8 next week. It was supposed to
be this week but I got sidetracked.<br>
<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote>
</div>
<br>
<br clear="all"><span class="HOEnZb"><font color="#888888">
<div><br>
</div>
-- <br>
<div>Davanum Srinivas :: <a href="https://twitter.com/dims" target="_blank"></a><a href="https://twitter.com/dims" target="_blank">https://twitter.com/dims</a></div>
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
<fieldset></fieldset>
<br>
<pre>__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</font></span></blockquote>
<br>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Davanum Srinivas :: <a href="https://twitter.com/dims" target="_blank">https://twitter.com/dims</a></div>
</div>