<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">I gave it some thought, and came to a conclusion, that adopting openstack config is the right thing to do. It enables some of the rules, that are disabled by default, so it actually is stricter, than our current config. So <a href="https://review.openstack.org/#/c/206729/">https://review.openstack.org/#/c/206729/</a></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Thank you again for your work Michael!</div> <br> <div id="bloop_sign_1438171959943571968" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px">-- <br>Kirill Zaitsev<br>Murano team</div><div style="font-family:helvetica,arial;font-size:13px">Software Engineer</div><div style="font-family:helvetica,arial;font-size:13px">Mirantis, Inc</div></div> <br><p class="airmail_on" style="color:#000;">On 28 Jul 2015 at 17:38:03, Michael Krotscheck (<a href="mailto:krotscheck@gmail.com">krotscheck@gmail.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>
<title></title>
<div dir="ltr">Well, the reasons those rules are deactivated is
because they simply had no equivalent in the previous tool, and we
didn't want to force the Horizon team to suddenly take on a far
more aggressive style correction job than they'd signed up for.
Once their job goes green, I'm going to start updating those rules
one by one to slowly tighten the rules set.
<div><br></div>
<div>With that in mind though: You can always extend the openstack
rules and add your own additional restrictions. So: Best of both
worlds :), just make sure you keep track of what's coming in from
upstream.</div>
<div><br></div>
<div>Michael</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Jul 28, 2015 at 3:58 AM Kirill Zaitsev
<<a href="mailto:kzaitsev@mirantis.com">kzaitsev@mirantis.com</a>>
wrote:<br></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Thanks Michael,</div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
I’m actually watching this process closely, and considering
switching to these rules, as soon as the job goes green. =)</div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
The upside of not doing so is that, since our (murano) js code base
is significantly smaller than that of horizon — we can impose
slightly stricter rule set, than horizon currently does. But
switching to it completely is something, that I do consider and it
is on the roadmap =)</div>
</div>
<div style="word-wrap:break-word"><br>
<div>
<div style="font-family:helvetica,arial;font-size:13px">
-- <br>
Kirill Zaitsev<br>
Murano team</div>
<div style="font-family:helvetica,arial;font-size:13px">Software
Engineer</div>
<div style="font-family:helvetica,arial;font-size:13px">Mirantis,
Inc</div>
</div>
<br></div>
<div style="word-wrap:break-word">
<p style="color:#000">On 28 Jul 2015 at 03:00:40, Michael
Krotscheck (<a href="mailto:krotscheck@gmail.com" target="_blank">krotscheck@gmail.com</a>) wrote:</p>
<blockquote type="cite">
<div>
<div>
<div dir="ltr">
<div style="font-size:small;line-height:20px"><span>FYI, those
rules have been moved into OpenStack under the QA program. I'm
currently working on getting npm publish jobs to function so we can
release those rules as well.</span></div>
<div style="font-size:small;line-height:20px">
<span><br></span></div>
<div style="font-size:small;line-height:20px"><span><a href="http://git.openstack.org/cgit/openstack/eslint-config-openstack/" target="_blank">http://git.openstack.org/cgit/openstack/eslint-config-openstack/</a></span></div>
<div style="font-size:small;line-height:20px">
<span><br></span></div>
<div style="font-size:small;line-height:20px">
<span>Michael</span></div>
</div>
<span><br></span>
<div class="gmail_quote">
<div dir="ltr"><span>On Mon, Jul 27, 2015 at 4:13 PM Kirill Zaitsev
<<a href="mailto:kzaitsev@mirantis.com" target="_blank">kzaitsev@mirantis.com</a>> wrote:<br></span></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span>Since there was some interest in my side activity (which is
described in <a href="https://blueprints.launchpad.net/murano/+spec/add-js-lint-jobs" target="_blank">https://blueprints.launchpad.net/murano/+spec/add-js-lint-jobs</a>)
I’ve created an etherpad with files, that are yet to be cleaned
up. </span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span><br></span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span>Here is the link <a href="https://etherpad.openstack.org/p/murano-escleanup" target="_blank">https://etherpad.openstack.org/p/murano-escleanup</a></span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span>So I suggest, that if you’re willing to help — add yourself
in front of the file you’d like to cleanup so that we would not do
the same job twice. </span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span><br></span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span>When adding rule configs I try to refer to <a href="https://github.com/krotscheck/eslint-config-openstack/blob/master/.eslintrc" target="_blank">https://github.com/krotscheck/eslint-config-openstack/blob/master/.eslintrc</a> </span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span>(I’m considering switching to it completely, but that is a
story for a different letter =))</span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span> </span></div>
<div>
<div style="font-family:helvetica,arial;font-size:13px">
<span>-- <br>
Kirill Zaitsev<br>
Murano team</span></div>
<div style="font-family:helvetica,arial;font-size:13px">
<span>Software Engineer</span></div>
<div style="font-family:helvetica,arial;font-size:13px">
<span>Mirantis, Inc</span></div>
</div>
</div>
<span>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</span></blockquote>
</div>
<span>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</span></div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div></div></span></blockquote></body></html>