<div dir="ltr">Hey, Li, Chen.<div><br></div><div>I implemented event log feature, and general aim event log feature is to provide some info about cluster provisioning to users. Actually, all fields of 'step', 'event' are only user-facing info. So, answer to questions are following:</div><div><br></div><div>1) Actually, the general aim of the 'step_type' field is to split several event-log steps with same name from plugin and from engine. Also, the 'step_type' is the common prefix of steps names. The cluster status provide only 'short' info about the current state of the cluster. Maybe it can be same but we won't remove that.</div><div><br></div><div>2) No, we shouldn't, because it's only user facing info, and we don't use that like we use cluster status in Sahara code and in Horizon.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 28, 2015 at 8:39 AM, Li, Chen <span dir="ltr"><<a href="mailto:chen.li@intel.com" target="_blank">chen.li@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal">Hi Sahara,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">“step_type” is a member of ClusterProvisionStep, and also be stored in context.<u></u><u></u></p>
<p class="MsoNormal"><a href="https://github.com/openstack/sahara/blob/master/sahara/db/sqlalchemy/models.py#L457" target="_blank">https://github.com/openstack/sahara/blob/master/sahara/db/sqlalchemy/models.py#L457</a><u></u><u></u></p>
<p class="MsoNormal"><a href="https://github.com/openstack/sahara/blob/master/sahara/context.py#L264" target="_blank">https://github.com/openstack/sahara/blob/master/sahara/context.py#L264</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I noticed that the “step_type” in context sometimes is updated at the same time as cluster status:<u></u><u></u></p>
<p class="MsoNormal"><a href="https://github.com/openstack/sahara/blob/master/sahara/service/ops.py#L255-L256" target="_blank">https://github.com/openstack/sahara/blob/master/sahara/service/ops.py#L255-L256</a><u></u><u></u></p>
<p class="MsoNormal"><a href="https://github.com/openstack/sahara/blob/master/sahara/service/ops.py#L260-L261" target="_blank">https://github.com/openstack/sahara/blob/master/sahara/service/ops.py#L260-L261</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">From my understanding, for a certain cluster, the relationship among cluster status & steps & event should be:<u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>1.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>The cluster is under a certain “status” <u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>2.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>Some “steps” would happen under a certain “status”<u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>3.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>Some “events” would happen under a certain “step”<u></u><u></u></p>
<p style="margin-left:0in"><u></u> <u></u></p>
<p style="margin-left:0in"><u></u> <u></u></p>
<p style="margin-left:0in">For example, if we’re working under plugin vanilla 2.6.<u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>1.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>When a cluster is under “Starting” status.<u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>2.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>Two steps involved for the “Starting” status : configure_instances & configure_topology_data.<u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>3.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>For step “configure_instances”, several events would happen => events number == instances number.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">My questions are:<u></u><u></u></p>
<p style="margin-left:.75in">
<u></u><span>1.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>Are there some step_type actually mixed with cluster status ? Should they be removed ?<u></u><u></u></p>
<p class="MsoNormal"> Or, I have missed something very important that we do need these step_type to be listed with cluster status ?
<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p style="margin-left:.75in">
<u></u><span>2.<span style="font:7.0pt "Times New Roman"">
</span></span><u></u>Should we define a group of constant to list all possible steps could happen for a cluster ?<u></u><u></u></p>
<p style="margin-left:1.0in">
<u></u><span style="font-family:Wingdings"><span>ð<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>If a plugin need special steps, it should define special constant by itself.<u></u><u></u></p>
<p style="margin-left:0in"><u></u> <u></u></p>
<p style="margin-left:0in">Looking forward to your reply.<u></u><u></u></p>
<p style="margin-left:0in"><u></u> <u></u></p>
<p style="margin-left:0in">Thanks.<span class="HOEnZb"><font color="#888888"><u></u><u></u></font></span></p><span class="HOEnZb"><font color="#888888">
<p style="margin-left:0in">-chen<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</font></span></div>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><span style="font-family:arial;font-size:small">Best Regards,</span><br></div><div><span style="font-family:arial;font-size:small">Vitaly Gridnev</span><br style="font-family:arial;font-size:small"><div style="font-family:arial;font-size:small">Mirantis, Inc</div></div></div></div>
</div>