<div dir="ltr"><div>Evgeniy, I need some response in <a href="https://bugs.launchpad.net/fuel/+bug/1476779">https://bugs.launchpad.net/fuel/+bug/1476779</a><br></div>AFAIC, it can be 30th (Thursday) for basic validation of template itself (regardless of present nodes and their node roles) but including known node roles/network roles for particular environment.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr">Aleksey Kasatkin
<br><br></div></div></div>
<br><div class="gmail_quote">On Mon, Jul 27, 2015 at 1:10 PM, Evgeniy L <span dir="ltr"><<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Igor,<div><br></div><div>Currently network template uses ERB [1] style template language,</div><div>but in fact it's Jinja [2], it was agreed to change it [3], no to confuse</div><div>the user, with ERB which is in fact jinja and doesn't have any ERB</div><div>features.</div><div><br></div><div>[1] <a href="https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/fixtures/network_template.json#L58" target="_blank">https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/fixtures/network_template.json#L58</a></div><div>[2] <a href="https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/objects/node.py#L854-L855" target="_blank">https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/objects/node.py#L854-L855</a></div><div>[3] <a href="https://review.openstack.org/#/c/197145/42/nailgun/nailgun/fixtures/network_template.json" target="_blank">https://review.openstack.org/#/c/197145/42/nailgun/nailgun/fixtures/network_template.json</a></div></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Jul 27, 2015 at 12:00 PM, Igor Kalnitsky <span dir="ltr"><<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Evgeniy,<br>
<span><br>
> 3. Change tokens in template language<br>
<br>
</span>I'm not sure what do you mean here. Could you please clarify? Perhaps<br>
I missed something.<br>
<br>
Thanks,<br>
Igor<br>
</span><span><span class=""><br>
On Mon, Jul 27, 2015 at 11:53 AM, Evgeniy L <<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>> wrote:<br>
> So, to summarise, +1 from me, we accept the changes which are required<br>
> for the feature as feature freeze exceptions:<br>
><br>
> 1. Fuel client changes [1]<br>
> 2. Validation [2]<br>
> 3. Change tokens in template language<br>
><br>
> Sebastian, Igor, correct?<br>
><br></span>
> [1] <a href="https://review.openstack.org/#/c/204321/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/204321/</a><br>
</span>> [2] <a href="https://bugs.launchpad.net/fuel/+bug/1476779" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a><span class=""><br>
<span>><br>
> On Sat, Jul 25, 2015 at 1:25 AM, Andrew Woodward <<a href="mailto:xarses@gmail.com" target="_blank">xarses@gmail.com</a>> wrote:<br>
>><br>
>> Igor,<br>
>><br>
</span></span>>> <a href="https://bugs.launchpad.net/fuel/+bug/1476779" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a> must be included in the FFE<span class=""><br>
<span>>> if you think it's a feature. Networking is the most complicated and<br>
>> frustrating thing the user can work with. If we cant provide usable feedback<br>
>> from bad data in the template then the feature is useless. I could argue<br>
>> that its a critical UX defect.<br>
>><br>
>><br>
</span></span><span class=""><span>>> On Fri, Jul 24, 2015 at 7:16 AM Evgeniy L <<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>> wrote:<br>
>>><br>
>>> Aleksey,<br>
>>><br>
>>> Yes, my point is those parts should be also included in the scope of FFE.<br>
>>> Regarding to template format, it's easy to fix and after release you will<br>
>>> not<br>
>>> be able to change it, or you can change it, but you will have to support<br>
>>> both<br>
>>> format, not to brake backward compatibility. So I would prefer to see it<br>
>>> fixed<br>
>>> in 7.0.<br>
>>><br>
>>> Thanks,<br>
>>><br>
>>> On Fri, Jul 24, 2015 at 3:14 PM, Aleksey Kasatkin<br>
</span></span><span class=""><span>>>> <<a href="mailto:akasatkin@mirantis.com" target="_blank">akasatkin@mirantis.com</a>> wrote:<br>
>>>><br>
>>>> I agree, guys, we need at least some basic validation for template when<br>
>>>> it is being loaded.<br>
>>>> Ivan Kliuk started to work on this task.<br>
>>>> And we agreed to test other types of delimiters (it is regarding ERB<br>
>>>> style template) but we have some more important issues.<br>
>>>> Evgeniy, is your meaning to include those to FFE ?<br>
>>>><br>
>>>><br>
>>>> Aleksey Kasatkin<br>
>>>><br>
>>>><br>
>>>> On Fri, Jul 24, 2015 at 2:12 PM, Sebastian Kalinowski<br>
</span></span><span class=""><span>>>>> <<a href="mailto:skalinowski@mirantis.com" target="_blank">skalinowski@mirantis.com</a>> wrote:<br>
>>>>><br>
>>>>> I agree here with Evgeniy. Even if it's not a trivial change, we cannot<br>
>>>>> leave a new API in such shape.<br>
>>>>><br>
</span></span><span class=""><span>>>>>> 2015-07-24 11:41 GMT+02:00 Evgeniy L <<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>>:<br>
>>>>>><br>
>>>>>> Hi Igor,<br>
>>>>>><br>
>>>>>> I don't agree with you, some basic validation is essential part of<br>
>>>>>> any handler and our API, currently it's easy to get meaningless 500<br>
>>>>>> error<br>
>>>>>> (which is unhandled exception) from the backend or get the error that<br>
>>>>>> there<br>
>>>>>> is something wrong with the template only after you press deploy<br>
>>>>>> button.<br>
>>>>>> It's a bad UX and contradicts to our attempts to develop good api.<br>
>>>>>><br>
>>>>>> Thanks,<br>
>>>>>><br>
>>>>>> On Fri, Jul 24, 2015 at 12:02 PM, Igor Kalnitsky<br>
</span></span><span><span class="">>>>>>> <<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>> wrote:<br>
>>>>>>><br>
>>>>>>> Greetings,<br>
>>>>>>><br>
>>>>>>> The issue [1] looks like a feature to me. I'd move it to next<br>
>>>>>>> release.<br>
>>>>>>> Let's focus on what's important right now - stability.<br>
>>>>>>><br>
>>>>>>> Thanks,<br>
>>>>>>> Igor<br>
>>>>>>><br></span>
>>>>>>> [1]: <a href="https://bugs.launchpad.net/fuel/+bug/1476779" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a><br>
>>>>>>><br>
</span><span><span class="">>>>>>>> On Fri, Jul 24, 2015 at 11:53 AM, Evgeniy L <<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>> wrote:<br>
>>>>>>> > Hi,<br>
>>>>>>> ><br>
>>>>>>> > Since the feature is essential, and changes are small, we can<br>
>>>>>>> > accept it as<br>
>>>>>>> > a,<br>
>>>>>>> > feature freeze exceptions.<br>
>>>>>>> ><br>
>>>>>>> > But as far as I know there is a very important ticket [1] which was<br>
>>>>>>> > created<br>
>>>>>>> > in<br>
>>>>>>> > order to get patches merged faster, also I still have concerns<br>
>>>>>>> > regarding to<br>
>>>>>>> > ERB style template "<% if3 %>" which is in fact Jinja. So it's not<br>
>>>>>>> > only<br>
>>>>>>> > about<br>
>>>>>>> > fixes in the client.<br>
>>>>>>> ><br></span>
>>>>>>> > [1] <a href="https://bugs.launchpad.net/fuel/+bug/1476779" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a><br>
>>>>>>> ><br>
</span><span class=""><span>>>>>>>> > On Thu, Jul 23, 2015 at 9:18 PM, Mike Scherbakov<br>
</span></span><span>>>>>>>> > <<a href="mailto:mscherbakov@mirantis.com" target="_blank">mscherbakov@mirantis.com</a>><span class=""><br>
>>>>>>> > wrote:<br>
>>>>>>> >><br>
>>>>>>> >> Looks like the only CLI part left:<br>
</span></span><span>>>>>>>> >> <a href="https://review.openstack.org/#/c/204321/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/204321/</a>, and you guys did a great<span class=""><br>
>>>>>>> >> job<br>
>>>>>>> >> finishing the other two.<br>
>>>>>>> >><br>
>>>>>>> >> Looks like we'd need to give FF exception, as this is essential<br>
>>>>>>> >> feature.<br>
>>>>>>> >> It's glad that we merged all other thousands lines of code. This<br>
>>>>>>> >> is the most<br>
>>>>>>> >> complex feature, and seems like the only small thing is left.<br>
>>>>>>> >><br>
>>>>>>> >> I'd like to hear feedback from Nailgun cores & fuel client SMEs.<br>
>>>>>>> >> For me,<br>
>>>>>>> >> it seems it is lower risk, and patch is relatively small. How long<br>
>>>>>>> >> would it<br>
>>>>>>> >> take to complete it? If it takes a couple of days, then it is<br>
>>>>>>> >> fine. If it is<br>
>>>>>>> >> going to take week or two, then we will have to have it as a risk<br>
>>>>>>> >> for HCF<br>
>>>>>>> >> deadline. Spending resources on features now, not on bugs, means<br>
>>>>>>> >> less<br>
>>>>>>> >> quality or slip of the release.<br>
>>>>>>> >><br>
>>>>>>> >> On Wed, Jul 22, 2015 at 2:36 PM Aleksey Kasatkin<br>
</span></span><span>>>>>>>> >> <<a href="mailto:akasatkin@mirantis.com" target="_blank">akasatkin@mirantis.com</a>><span class=""><br>
>>>>>>> >> wrote:<br>
>>>>>>> >>><br>
>>>>>>> >>> Team,<br>
>>>>>>> >>><br>
>>>>>>> >>> I would like to request an exception from the Feature Freeze for<br>
>>>>>>> >>> "Templates for Networking" feature [1].<br>
>>>>>>> >>><br>
>>>>>>> >>> Exception is required for two CRs to python-fuelclient: [2],[3]<br>
>>>>>>> >>> and one<br>
>>>>>>> >>> CR to fuel-web (Nailgun): [4].<br>
>>>>>>> >>> These CRs are for adding ability to create/remove networks via<br>
>>>>>>> >>> API [4]<br>
>>>>>>> >>> and for supporting new API functionality via CLI.<br>
>>>>>>> >>> These patchsets are for adding new templates-related<br>
>>>>>>> >>> functionality and<br>
>>>>>>> >>> they do not change existing functionality.<br>
>>>>>>> >>> Patchsets [3],[4] are in deep review and they will hopefully be<br>
>>>>>>> >>> merged on<br>
>>>>>>> >>> Thursday.<br>
>>>>>>> >>><br>
>>>>>>> >>> Please, respond if you have any questions or concerns related to<br>
>>>>>>> >>> this<br>
>>>>>>> >>> request.<br>
>>>>>>> >>><br>
>>>>>>> >>> Thanks in advance.<br>
>>>>>>> >>><br>
>>>>>>> >>> [1]<br></span>
>>>>>>> >>> <a href="https://blueprints.launchpad.net/fuel/+spec/templates-for-networking" rel="noreferrer" target="_blank">https://blueprints.launchpad.net/fuel/+spec/templates-for-networking</a><br>
</span>>>>>>>> >>> [2] <a href="https://review.openstack.org/#/c/204321/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/204321/</a><br>
>>>>>>> >>> [3] <a href="https://review.openstack.org/#/c/203602/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/203602/</a><br>
>>>>>>> >>> [4] <a href="https://review.openstack.org/#/c/201217/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/201217/</a><span class=""><br>
<span>>>>>>>> >>><br>
>>>>>>> >>> --<br>
>>>>>>> >>> Best regards,<br>
>>>>>>> >>> Aleksey Kasatkin<br>
>>>>>>> >>><br>
>>>>>>> >>><br>
>>>>>>> >>> __________________________________________________________________________<br>
>>>>>>> >>> OpenStack Development Mailing List (not for usage questions)<br>
>>>>>>> >>> Unsubscribe:<br>
</span></span><span class="">>>>>>>> >>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>>>>> >>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>>>>> >><br>
>>>>>>> >> --<br>
>>>>>>> >> Mike Scherbakov<br>
>>>>>>> >> #mihgen<br>
>>>>>>> >><br>
>>>>>>> >><br>
>>>>>>> >> __________________________________________________________________________<br>
>>>>>>> >> OpenStack Development Mailing List (not for usage questions)<br>
>>>>>>> >> Unsubscribe:<br>
</span></span><span class="">>>>>>>> >> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>>>>> >> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>>>>> >><br>
>>>>>>> ><br>
>>>>>>> ><br>
>>>>>>> ><br>
>>>>>>> > __________________________________________________________________________<br>
>>>>>>> > OpenStack Development Mailing List (not for usage questions)<br>
>>>>>>> > Unsubscribe:<br>
</span></span><span class="">>>>>>>> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>>>>> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>>>>> ><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> __________________________________________________________________________<br>
>>>>>>> OpenStack Development Mailing List (not for usage questions)<br>
>>>>>>> Unsubscribe:<br>
</span></span><span class="">>>>>>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>>>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>> __________________________________________________________________________<br>
>>>>>> OpenStack Development Mailing List (not for usage questions)<br>
>>>>>> Unsubscribe:<br>
</span></span><span class="">>>>>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>>>><br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> __________________________________________________________________________<br>
>>>>> OpenStack Development Mailing List (not for usage questions)<br>
>>>>> Unsubscribe:<br>
</span></span><span class="">>>>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> __________________________________________________________________________<br>
>>>> OpenStack Development Mailing List (not for usage questions)<br>
>>>> Unsubscribe:<br>
</span></span><span class="">>>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>>>><br>
>>><br>
>>><br>
>>> __________________________________________________________________________<br>
>>> OpenStack Development Mailing List (not for usage questions)<br>
>>> Unsubscribe:<br>
</span></span><span class="">>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>><br>
>> --<br>
>><br>
>> --<br>
>><br>
>> Andrew Woodward<br>
>><br>
>> Mirantis<br>
>><br>
>> Fuel Community Ambassador<br>
>><br>
>> Ceph Community<br>
>><br>
>><br>
>> __________________________________________________________________________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
</span></span>>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<span>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
>><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
</span></span>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<span>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class=""><br>
><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
</span></span>Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>