<div dir="ltr">So, to summarise, +1 from me, we accept the changes which are required<div>for the feature as feature freeze exceptions:<div><br></div><div>1. Fuel client changes [1]</div><div>2. Validation [2]</div><div>3. Change tokens in template language</div><div><br></div><div>Sebastian, Igor, correct?</div><div><br></div><div>[1] <a href="https://review.openstack.org/#/c/204321/">https://review.openstack.org/#/c/204321/</a></div><div>[2] <a href="https://bugs.launchpad.net/fuel/+bug/1476779">https://bugs.launchpad.net/fuel/+bug/1476779</a></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jul 25, 2015 at 1:25 AM, Andrew Woodward <span dir="ltr"><<a href="mailto:xarses@gmail.com" target="_blank">xarses@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Igor, <div><br></div><div><a href="https://bugs.launchpad.net/fuel/+bug/1476779" style="font-size:13.1999998092651px;line-height:19.7999992370605px" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a> must be included in the FFE if you think it's a feature. Networking is the most complicated and frustrating thing the user can work with. If we cant provide usable feedback from bad data in the template then the feature is useless. I could argue that its a critical UX defect.<br></div><div><br></div></div><div><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 24, 2015 at 7:16 AM Evgeniy L <<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Aleksey,<div><br><div>Yes, my point is those parts should be also included in the scope of FFE.</div><div>Regarding to template format, it's easy to fix and after release you will not</div><div>be able to change it, or you can change it, but you will have to support both</div><div>format, not to brake backward compatibility. So I would prefer to see it fixed</div><div>in 7.0.</div><div><br></div><div>Thanks,</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 24, 2015 at 3:14 PM, Aleksey Kasatkin <span dir="ltr"><<a href="mailto:akasatkin@mirantis.com" target="_blank">akasatkin@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>I agree, guys, we need at least some basic validation for template when it is being loaded.<br></div>Ivan Kliuk started to work on this task.<br></div><div>And we agreed to test other types of delimiters (it is regarding ERB style template) but we have some more important issues.<br></div>Evgeniy, is your meaning to include those to FFE ?<span><font color="#888888"><br><br></font></span></div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div><div><div dir="ltr">Aleksey Kasatkin
<br><br></div></div></div></font></span><div><div>
<br><div class="gmail_quote">On Fri, Jul 24, 2015 at 2:12 PM, Sebastian Kalinowski <span dir="ltr"><<a href="mailto:skalinowski@mirantis.com" target="_blank">skalinowski@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I agree here with Evgeniy. Even if it's not a trivial change, we cannot leave a new API in such shape.<br></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">2015-07-24 11:41 GMT+02:00 Evgeniy L <span dir="ltr"><<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Igor,<div><br></div><div>I don't agree with you, some basic validation is essential part of</div><div>any handler and our API, currently it's easy to get meaningless 500 error</div><div>(which is unhandled exception) from the backend or get the error that there</div><div>is something wrong with the template only after you press deploy button.</div><div>It's a bad UX and contradicts to our attempts to develop good api.</div><div><br></div><div>Thanks,</div></div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jul 24, 2015 at 12:02 PM, Igor Kalnitsky <span dir="ltr"><<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>Greetings,<br>
<br>
The issue [1] looks like a feature to me. I'd move it to next release.<br>
Let's focus on what's important right now - stability.<br>
<br>
Thanks,<br>
Igor<br>
<br></span>
[1]: <a href="https://bugs.launchpad.net/fuel/+bug/1476779" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a><br>
<span><span><br>
On Fri, Jul 24, 2015 at 11:53 AM, Evgeniy L <<a href="mailto:eli@mirantis.com" target="_blank">eli@mirantis.com</a>> wrote:<br>
> Hi,<br>
><br>
> Since the feature is essential, and changes are small, we can accept it as<br>
> a,<br>
> feature freeze exceptions.<br>
><br>
> But as far as I know there is a very important ticket [1] which was created<br>
> in<br>
> order to get patches merged faster, also I still have concerns regarding to<br>
> ERB style template "<% if3 %>" which is in fact Jinja. So it's not only<br>
> about<br>
> fixes in the client.<br>
><br></span>
> [1] <a href="https://bugs.launchpad.net/fuel/+bug/1476779" rel="noreferrer" target="_blank">https://bugs.launchpad.net/fuel/+bug/1476779</a><br>
><br>
</span>> On Thu, Jul 23, 2015 at 9:18 PM, Mike Scherbakov <<a href="mailto:mscherbakov@mirantis.com" target="_blank">mscherbakov@mirantis.com</a>><span><br>
<span>> wrote:<br>
>><br>
>> Looks like the only CLI part left:<br>
</span></span><span>>> <a href="https://review.openstack.org/#/c/204321/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/204321/</a>, and you guys did a great job<span><br>
>> finishing the other two.<br>
>><br>
>> Looks like we'd need to give FF exception, as this is essential feature.<br>
>> It's glad that we merged all other thousands lines of code. This is the most<br>
>> complex feature, and seems like the only small thing is left.<br>
>><br>
>> I'd like to hear feedback from Nailgun cores & fuel client SMEs. For me,<br>
>> it seems it is lower risk, and patch is relatively small. How long would it<br>
>> take to complete it? If it takes a couple of days, then it is fine. If it is<br>
>> going to take week or two, then we will have to have it as a risk for HCF<br>
>> deadline. Spending resources on features now, not on bugs, means less<br>
>> quality or slip of the release.<br>
>><br>
</span></span>>> On Wed, Jul 22, 2015 at 2:36 PM Aleksey Kasatkin <<a href="mailto:akasatkin@mirantis.com" target="_blank">akasatkin@mirantis.com</a>><br>
<span><span>>> wrote:<br>
>>><br>
>>> Team,<br>
>>><br>
>>> I would like to request an exception from the Feature Freeze for<br>
>>> "Templates for Networking" feature [1].<br>
>>><br>
>>> Exception is required for two CRs to python-fuelclient: [2],[3] and one<br>
>>> CR to fuel-web (Nailgun): [4].<br>
>>> These CRs are for adding ability to create/remove networks via API [4]<br>
>>> and for supporting new API functionality via CLI.<br>
>>> These patchsets are for adding new templates-related functionality and<br>
>>> they do not change existing functionality.<br>
>>> Patchsets [3],[4] are in deep review and they will hopefully be merged on<br>
>>> Thursday.<br>
>>><br>
>>> Please, respond if you have any questions or concerns related to this<br>
>>> request.<br>
>>><br>
>>> Thanks in advance.<br>
>>><br></span>
>>> [1] <a href="https://blueprints.launchpad.net/fuel/+spec/templates-for-networking" rel="noreferrer" target="_blank">https://blueprints.launchpad.net/fuel/+spec/templates-for-networking</a><br>
</span>>>> [2] <a href="https://review.openstack.org/#/c/204321/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/204321/</a><br>
>>> [3] <a href="https://review.openstack.org/#/c/203602/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/203602/</a><br>
>>> [4] <a href="https://review.openstack.org/#/c/201217/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/201217/</a><span><br>
<span>>>><br>
>>> --<br>
>>> Best regards,<br>
>>> Aleksey Kasatkin<br>
>>><br>
>>> __________________________________________________________________________<br>
>>> OpenStack Development Mailing List (not for usage questions)<br>
>>> Unsubscribe:<br>
</span></span><span>>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
</span><span>>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span><br>
>><br>
>> --<br>
>> Mike Scherbakov<br>
>> #mihgen<br>
>><br>
>> __________________________________________________________________________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
</span></span><span>>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br></span>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span><br>
<span>>><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
</span></span><span>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br></span>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span><br>
<span>><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
</span></span><span>Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</span></blockquote></div><br></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
</div></div><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><div dir="ltr">-- <br></div></div></div><div dir="ltr"><p dir="ltr">--</p><p dir="ltr"><span style="font-size:13.1999998092651px">Andrew Woodward</span></p><p dir="ltr"><span style="font-size:13.1999998092651px">Mirantis</span></p><p dir="ltr"><span style="font-size:13.1999998092651px">Fuel Community Ambassador</span></p><p dir="ltr"><span style="font-size:13.1999998092651px">Ceph Community</span></p>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>