<div dir="ltr">Maybe I'm not explaining myself well (sorry)...<div><br></div><div>For VPN commits, there are functional jobs that (now) enable the devstack plugin for neutron-vpnaas as needed (and grenade job will do the same). From the neutron-vpnaas repo standpoint everything is in place.<div><br></div><div>Now that there is a devstack plugin for neutron-vpnaas, I want to remove all the VPN setup from the <b>DevStack</b> repo's setup, as the user of DevStack can specify the enable_plugin in their local.conf file now. The commit is <a href="https://review.openstack.org/#/c/201119/">https://review.openstack.org/#/c/201119/</a>.</div></div><div><br></div><div>The issue I see though, is that the DevStack repo's jobs are failing, because they are using devstack, are relying on VPN being set up, and the enable_plugin line for VPN isn't part of any of the jobs shown in my last post.</div><div><br></div><div>How do we resolve that issue?</div><div><br></div><div>Regards,</div><div><br></div><div>PCM<br><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 27, 2015 at 8:09 AM Sean Dague <<a href="mailto:sean@dague.net">sean@dague.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You would build variants of the jobs you want that specifically enable<br>
your plugin.<br>
<br>
That being said, you should focus on jobs that substantially test your<br>
component, not just the giant list of all jobs. Part of our focus in on<br>
decoupling so that for something like vpnaas you can start with the<br>
assumption that neutron base services are sufficiently tested elsewhere,<br>
and the only thing you should test is the additional function and<br>
complexity that your component brings to the mix.<br>
<br>
-Sean<br>
<br>
On 07/27/2015 07:44 AM, Paul Michali wrote:<br>
> Yes, the plugin enables the service, and for the neutron-vpnaas DSVM<br>
> based jobs, I have the "enable_plugin" line added to the job so that<br>
> everything works.<br>
><br>
> However, for the DevStack repo, which runs a bunch of other DSVM jobs,<br>
> this fails, as there is (obviously) no enable_plugin line.:<br>
><br>
> * gate-tempest-dsvm-full<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-full/98be491/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-full/98be491/</a>> SUCCESS in<br>
> 58m 37s<br>
> * gate-tempest-dsvm-postgres-full<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-postgres-full/85c5b92/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-postgres-full/85c5b92/</a>> SUCCESS in<br>
> 50m 45s<br>
> * gate-tempest-dsvm-neutron-full<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-neutron-full/0050bfe/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-neutron-full/0050bfe/</a>> FAILURE in<br>
> 1h 25m 30s<br>
> * gate-grenade-dsvm<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-grenade-dsvm/b224606/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-grenade-dsvm/b224606/</a>> SUCCESS in<br>
> 44m 23s<br>
> * gate-tempest-dsvm-large-ops<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-large-ops/a250cf5/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-large-ops/a250cf5/</a>> SUCCESS in<br>
> 26m 49s<br>
> * gate-tempest-dsvm-neutron-large-ops<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-neutron-large-ops/6faa1be/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-neutron-large-ops/6faa1be/</a>> SUCCESS in<br>
> 25m 51s<br>
> * gate-devstack-bashate<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-devstack-bashate/65ad952/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-devstack-bashate/65ad952/</a>> SUCCESS in<br>
> 13s<br>
> * gate-devstack-unit-tests<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-devstack-unit-tests/ccdbe4e/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-devstack-unit-tests/ccdbe4e/</a>> SUCCESS in<br>
> 1m 02s<br>
> * gate-devstack-dsvm-cells<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-devstack-dsvm-cells/a6ca00c/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-devstack-dsvm-cells/a6ca00c/</a>> SUCCESS in<br>
> 24m 08s<br>
> * gate-grenade-dsvm-partial-ncpu<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-grenade-dsvm-partial-ncpu/744deb8/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-grenade-dsvm-partial-ncpu/744deb8/</a>> SUCCESS in<br>
> 48m 36s<br>
> * gate-tempest-dsvm-ironic-pxe_ssh<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-ironic-pxe_ssh/8eb4315/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-ironic-pxe_ssh/8eb4315/</a>> FAILURE in<br>
> 40m 10s<br>
> * gate-devstack-dsvm-updown<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-devstack-dsvm-updown/85f1de5/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-devstack-dsvm-updown/85f1de5/</a>> SUCCESS in<br>
> 21m 12s<br>
> * gate-tempest-dsvm-f21<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-f21/35a04c4/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-f21/35a04c4/</a>> FAILURE in<br>
> 51m 01s (non-voting)<br>
> * gate-tempest-dsvm-centos7<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-centos7/b9c99c9/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-centos7/b9c99c9/</a>> SUCCESS in<br>
> 30m 23s (non-voting)<br>
> * gate-devstack-publish-docs<br>
> <<a href="http://docs-draft.openstack.org/19/201119/1/check/gate-devstack-publish-docs/f794b1c//doc/build/html/" rel="noreferrer" target="_blank">http://docs-draft.openstack.org/19/201119/1/check/gate-devstack-publish-docs/f794b1c//doc/build/html/</a>> SUCCESS in<br>
> 2m 23s<br>
> * gate-swift-dsvm-functional-nv<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-swift-dsvm-functional-nv/13d2c58/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-swift-dsvm-functional-nv/13d2c58/</a>> SUCCESS in<br>
> 27m 12s (non-voting)<br>
> * gate-grenade-dsvm-neutron<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-grenade-dsvm-neutron/8675f0c/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-grenade-dsvm-neutron/8675f0c/</a>> FAILURE in<br>
> 47m 49s<br>
> * gate-tempest-dsvm-multinode-smoke<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-multinode-smoke/bd69c45/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-multinode-smoke/bd69c45/</a>> SUCCESS in<br>
> 36m 53s (non-voting)<br>
> * gate-tempest-dsvm-neutron-multinode-smoke<br>
> <<a href="http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-neutron-multinode-smoke/01e1d45/" rel="noreferrer" target="_blank">http://logs.openstack.org/19/201119/1/check/gate-tempest-dsvm-neutron-multinode-smoke/01e1d45/</a>> FAILURE in<br>
> 44m 16s (non-voting)<br>
><br>
><br>
> I'm wondering what's the best way to modify those jobs... is there some<br>
> common location where I can enable the plugin to handle all DSVM based<br>
> jobs, do I just update the 5 failing tests, do I update just the 3<br>
> voting tests, or do I update all 16 DSVM based jobs?<br>
><br>
> Regards,<br>
> PCM<br>
><br>
> On Fri, Jul 24, 2015 at 5:12 PM Clark Boylan <<a href="mailto:cboylan@sapwetik.org" target="_blank">cboylan@sapwetik.org</a><br>
> <mailto:<a href="mailto:cboylan@sapwetik.org" target="_blank">cboylan@sapwetik.org</a>>> wrote:<br>
><br>
> On Fri, Jul 24, 2015, at 02:05 PM, Paul Michali wrote:<br>
> > Hi,<br>
> ><br>
> > I've created a DevStack plugin for the neutron-vpnaas repo. Now, I'm<br>
> > trying<br>
> > to remove the q-vpn service setup from the DevStack repo (<br>
> > <a href="https://review.openstack.org/#/c/201119/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/201119/</a>).<br>
> ><br>
> > However, I'm hitting an issue in that (almost) every test that uses<br>
> > DevStack fails, because it is no longer setting up q-vpn.<br>
> ><br>
> > How should I modify the tests, so that they setup the q-vpn<br>
> service, in<br>
> > light of the fact that there is a DevStack plugin available for it. Is<br>
> > there some common place that I can do the "enable_plugin<br>
> > neutron-vpnaas..."<br>
> > line?<br>
> ><br>
> Your devstack plugin should enable the service. Then in your jobs you<br>
> just need to enable the plugin which will then enable the vpn service.<br>
> There should be plenty of prior art with the ec2api plugin, glusterfs<br>
> plugin, and others.<br>
><br>
> Clark<br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe:<br>
> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
<br>
--<br>
Sean Dague<br>
<a href="http://dague.net" rel="noreferrer" target="_blank">http://dague.net</a><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div>