<div dir="ltr">Hi Andrew,<div><br></div><div>I don't agree with you, user should be able to name the node any way he</div><div>wants why there should be a constraint which is related to some internal id</div><div>in Nailgun database? For example if he deleted node-5 and then he wants</div><div>to replace this node with another one, he can and should be able to provide</div><div>for this replacement node hostname node-5, even if node's id in the database</div><div>is 6.</div><div><br></div><div>Thanks,</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 24, 2015 at 2:36 AM, Andrew Woodward <span dir="ltr"><<a href="mailto:xarses@gmail.com" target="_blank">xarses@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><span class=""><div dir="ltr">On Wed, Jul 22, 2015 at 6:32 AM Fedor Zhadaev <<a href="mailto:fzhadaev@mirantis.com" target="_blank">fzhadaev@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Thanks for your answers.</div><div><br></div><div>Let me clarify some points:</div><div><br></div><div>Sure, we have to validate hostnames during node renaming. And sure we do it. This issue appears when we already have node with name 'node-X' and new node is created without providing custom name. I'll give you the example:</div><div><br></div><div>1. User has node with hostname 'node-4' (with ID = 4; and there no nodes with ID > 4) ;</div><div>2. He renames it in 'node-5' (this name is correct and unique. OK)</div><div>3. He adds new node without providing custom hostname.</div><div> New node gets ID = 5 (it's primary key and increments automatically) and default hostname 'node-5'. (Here we have a problem with uniqueness.)</div><div><br></div><div>It will be strange if we refuse to create node with default name if somebody has renamed another node using this name.</div><div><br></div><div>About nodes hostnames. Actually we can't refuse to use custom hostnames in format 'node-{#}' because it is one of the main use cases. So we need to find the solution which accepts such renaming.</div></div></blockquote></span><div>How is this a main use case? This is exactly what we should not support. If they want the node to have 'node-5' as it's hostname we need them to be <a href="http://node.id" target="_blank">node.id</a> = 5 (IE the node id in the DB is 5) They would not need custom node naming in this case.</div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"></div></div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2015-07-22 12:42 GMT+03:00 Igor Kalnitsky <span dir="ltr"><<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi guys,<br>
<br>
@Sergii, it looks like you misunderstood something. `node-uuid` is not<br>
a general use case. It's only about conflicting nodes, and I'm sure<br>
everyone's going to change such a hostname in order to avoid<br>
confusion.<br>
<br>
@Andrew,<br>
<br>
a) Database refuses hostnames that break unique constraint, sot it'll<br>
work out-of-box.<br>
<br>
b) I like this idea. I think refusing `node-id` where `id` is not<br>
actually a node id is good idea. It solves our problem.<br>
<br>
Thanks,<br>
Igor<br>
<div><div><br>
On Wed, Jul 22, 2015 at 8:21 AM, Sergii Golovatiuk<br>
<<a href="mailto:sgolovatiuk@mirantis.com" target="_blank">sgolovatiuk@mirantis.com</a>> wrote:<br>
> node-uuid is very terrible from UX perspective of view. Ask support people<br>
> if they are comfortable to ssh such nodes or telling the name in phone<br>
> conversation with customer. If we cannot validate FQDN of hostname I would<br>
> slip this feature to next release where we can pay more attention to<br>
> details.<br>
><br>
> --<br>
> Best regards,<br>
> Sergii Golovatiuk,<br>
> Skype #golserge<br>
> IRC #holser<br>
><br>
</div></div><span>> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
</span>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<span>><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
</span>Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><div dir="ltr"><div class="gmail_extra">-- <br><div><div dir="ltr"><div>Kind Regards,</div><div>Fedor Zhadaev</div><div>Junior Software Engineer, Mirantis Inc.</div><div>Skype: zhadaevfm</div><div>E-mail: <a href="mailto:fzhadaev@mirantis.com" target="_blank">fzhadaev@mirantis.com</a></div></div></div>
</div></div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div></div></div></div><div dir="ltr">-- <br></div><div class="HOEnZb"><div class="h5"><div dir="ltr"><p dir="ltr">--</p><p dir="ltr"><span style="font-size:13.1999998092651px">Andrew Woodward</span></p><p dir="ltr"><span style="font-size:13.1999998092651px">Mirantis</span></p><p dir="ltr"><span style="font-size:13.1999998092651px">Fuel Community Ambassador</span></p><p dir="ltr"><span style="font-size:13.1999998092651px">Ceph Community</span></p>
</div>
</div></div><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>