<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>I was referring to the HTML reports that the karma-coverage plugin creates for now. From my experience with it, it’s fairly relaxed about what counts as something being tested, hence the 100% aim. For example, often just checking that a value is defined
is enough for it to be “tested”, and this is where reviewers would have to use their own knowledge to ensure decent tests.</div>
<div><br>
</div>
<div>More than happy to discuss tooling though.</div>
<div><br>
</div>
<div>Rob</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Michael Krotscheck <<a href="mailto:krotscheck@gmail.com">krotscheck@gmail.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Thursday, 23 July 2015 18:11<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [horizon] Minimum Unit Test Coverage<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">+1 on coverage of any kind.
<div><br>
</div>
<div>From a tooling perspective, are you thinking istanbul?</div>
<div><br>
</div>
<div>From an infra perspective, are you thinking a separate job, or to have it integrated in with npm run test? FYI- istanbul wraps the unit test invocation, e.g. 'istanbul karma start ./karma.config.js' or something similar.</div>
<div><br class="Apple-interchange-newline">
100% code coverage is ambitious. Let's get the tool selected and working first.<br>
</div>
<div><br>
</div>
<div>Michael
<div dir="ltr">
<div><br>
</div>
</div>
<div class="gmail_quote">
<div dir="ltr">On Wed, Jul 22, 2015 at 11:57 AM Rajat Vig <<a href="mailto:rajatv@thoughtworks.com" target="_blank">rajatv@thoughtworks.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
Hi Rob</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
<br>
</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
I agree. Enforcing a minimum level of coverage as a start is awesome.</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
<br>
</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
I must add though keeping it at 100% and breaking the build has almost never worked in practice for me.</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
Keeping a slightly lower level ~98% is slightly more pragmatic.</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
Also, the currently low coverages will have to be addressed as well.</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
Is there a blueprint that can be created to tackle it?</div>
</div>
<div dir="ltr">
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
<br>
</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
-Rajat</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">
<br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jul 22, 2015 at 6:33 AM, Rob Cresswell (rcresswe)
<span dir="ltr"><<a href="mailto:rcresswe@cisco.com" target="_blank">rcresswe@cisco.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word;color:rgb(0,0,0);font-size:14px;font-family:Calibri,sans-serif">
<div>Hi all,</div>
<div><br>
</div>
<div>As far as I’m aware, we don’t currently enforce any minimum unit test coverage, despite Karma generating reports. I think as part of the review guidelines, it would be useful to set a minimum. Since Karma’s detection is fairly relaxed, I’d put it at 100%
on the automated reports.</div>
<div><br>
</div>
<div>I think the biggest drawback is that the tests may not be “valuable”, but rather just meet the minimum requirements. I understand this sentiment, but I think that “less valuable” is better then “not present” and it gives reviewers a clear line to +1/ -1
a patch. Furthermore, it encourages the unit tests to be written in the first place, so that reviewers can then ask for improvements, rather than miss them.</div>
<span><font color="#888888">
<div><br>
</div>
<div>Rob</div>
</font></span></div>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</span>
</body>
</html>