
<html><body>


<p><font size="2" face="sans-serif">Hi,</font><br>


<br>


<font size="2" face="sans-serif">I'm working on </font><a href="https://bugs.launchpad.net/nova/+bug/1466451"><font size="2" face="sans-serif">bug 1466451</font></a><font size="2" face="sans-serif">, which is about the invalid configuration of property "pci_passthrough_whitelist" in nova.</font><br>


<br>


<font size="2" face="sans-serif">My proposal for fixing this issue is:</font><br>


<br>


<font size="2" face="sans-serif">Before start nova-compute sevice, do a precheck against /etc/nova/nova.conf file, if the value format of "pci_passthrough_whitelist" doesn't match with any of following ones, the configuration will be recongnized as invalid:</font><br>


<br>


<tt><font size="2" color="#333333">1. Only "devname":</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"devname":"eth0", "physical_network":"physnet1"}</font></tt><br>


<tt><font size="2" color="#333333">2. Only "address":</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"address":"*:0a:00.*", "physical_network":"physnet1"}</font></tt><br>


<tt><font size="2" color="#333333">3. Only "vendor_id + product_id":</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"vendor_id":"1137","product_id":"0071", "physical_network":"physnet1"}</font></tt><br>


<tt><font size="2" color="#333333">4. "devname" and "address":</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"devname":"eth0", "address":"*:0a:00.*", "physical_network":"physnet1"}</font></tt><br>


<tt><font size="2" color="#333333">5. "devname" and "vendor_id+product_id'":</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"devname":"eth0", "vendor_id":"1137","product_id":"0071", "physical_network":"physnet1"}</font></tt><br>


<tt><font size="2" color="#333333">6. "address" and "vendor_id+product_id'":</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"address":"*:0a:00.*", "vendor_id":"1137","product_id":"0071", "physical_network":"physnet1"}</font></tt><br>


<tt><font size="2" color="#333333">7. All of them:</font></tt><br>


<tt><font size="2" color="#333333">pci_passthrough_whitelist = {"devname":"eth0", "address":"*:0a:00.*", "vendor_id":"1137", "product_id":"0071", "physical_network":"physnet1"}</font></tt><br>


<br>


<font size="2" face="sans-serif">Now I need some suggestion to proceed:</font><br>


<br>


<font size="2" face="sans-serif">1. Do I need to register a blueprint for fixing this issue?</font><br>


<font size="2" face="sans-serif">2. What kind of action is appropriate when the invalid configuration of pci_passthrough_whitelist is dectected, logging the error or raising the error?</font><br>


<br>


<font size="2" face="sans-serif">Thanks in advance!</font><br>


<br>


<font size="2" face="sans-serif">Best Regards,<br>


Yu WenZhi(余文治）<br>


OpenStack on Power Development, IBM Shanghai<br>


2F, 399 Keyuan Rd, Zhangjiang Chuangxin No. 10 Building, Zhangjiang High Tech Park Shanghai </font></body></html>