<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>
<div>
<div>On the top of that the co-authors should NOT be voting +2 on their own patch!</div>
<div><br>
</div>
<div>Edgar</div>
<div>
<div id="MAC_OUTLOOK_SIGNATURE"></div>
</div>
</div>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:12pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Kyle Mestery<br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)"<br>
<span style="font-weight:bold">Date: </span>Friday, July 17, 2015 at 8:13 AM<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)"<br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Neutron] Concern about networking-sfc and community process<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">On Thu, Jul 16, 2015 at 8:39 PM, Sean M. Collins <span dir="ltr"><<a href="mailto:sean@coreitpro.com" target="_blank">sean@coreitpro.com</a>></span> wrote:<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Cathy,<br>
<br>
You recently merged the following patch, by +2'ing and then<br>
Workflow+1'ing it, without allowing reviewers the chance to look at the<br>
changes between the patchset where there were -1's and the newer<br>
patchsets.<br>
<br>
<a href="https://review.openstack.org/#/c/192933/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/192933/</a><br>
<br>
I do see that you were asking on -infra about the mechanics of how to<br>
merge a patch<br>
<br>
<a href="http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2015-07-16.log.html#t2015-07-16T23:54:03" rel="noreferrer" target="_blank">http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2015-07-16.log.html#t2015-07-16T23:54:03</a><br>
<br>
Just because a core member has given it a +2 and the Neutron PTL had<br>
+2'd a previous patch, doesn't mean that you should go ahead and<br>
unilaterally approve your own patch. That's not a way to build a<br>
commmunity project.<br>
<span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote>
<div><br>
</div>
<div>I agree with Sean here. The patch merged with only a single +2, and if the other comments were not addressed earlier, they need to be addressed with a followup patch (and reply on this email thread with the patch), or we should revert the commit and address
them there.<br>
<br>
</div>
<div>Thanks,<br>
</div>
<div>Kyle<br>
</div>
<div> <br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888">--<br>
Sean M. Collins<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</span>
</body>
</html>