<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Just adding an experience from another project, Neutron.<div class=""><br class=""></div><div class="">We had similar debates, and prepping for the long apocalyptic winter of changeset death, Kyle decimated the world and ran the abandon script. The debates were far more intense than the reality, and my large stockpile of Rad-X and Nuka Cola went to waste.<div class=""><br class=""></div><div class="">Every few weeks, I get a few emails of things being abandoned. And if I care about something, mine or not, I click through and tap ‘Restore’. If one person in the entire community can’t be bothered to click one button, I’m not sure how it’d ever be kept up-to-date, much less merge.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">doug</div><div class=""><br class=""></div><div class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 16, 2015, at 8:36 PM, Dmitry Borodaenko <<a href="mailto:dborodaenko@mirantis.com" class="">dborodaenko@mirantis.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><div class="">I'm with Stanislaw on this one: abandoning reviews just to make numbers *look* better will accomplish nothing.<br class=""><br class="">The only benefit I can see is cleaning up reviews that we *know* don't need to be considered, so that it's easier for reviewers to find the reviews that still need attention. I don't see this as that much of a problem, finding stuff to review in Fuel Review Inbox [0] is not hard at all.<br class=""><br class="">[0] <a href="https://wiki.openstack.org/wiki/Fuel#Development_related_links" class="">https://wiki.openstack.org/wiki/Fuel#Development_related_links</a><br class=""><br class=""></div>And the state of our review backlog is such that it's not safe to auto-abandon reviews without looking at them, and if a contributor has spent time looking at a review, abandoning it manually is one click away.<br class=""><br class=""></div>If we do go with setting up an auto-abandon rule, it should be extremely conservative, for example: CR has a negative vote from a core reviewer AND there were no comments or positive votes from anyone after that AND it has not been touched in any way for 2 months.<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Jul 15, 2015 at 5:10 PM Mike Scherbakov <<a href="mailto:mscherbakov@mirantis.com" class="">mscherbakov@mirantis.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Folks,<div class="">let's execute here. Numbers are still large. Did we have a chance to look over the whole queue?</div><div class=""><br class=""></div><div class="">Can we go ahead and abandon changes having -1 or -2 from reviewers for over than a months or so?</div><div class="">I'm all for just following standard OpenStack process [1], and then change it only if there is good reason for it.</div><div class=""><br class=""></div><div class="">[1] <a href="https://wiki.openstack.org/wiki/Puppet#Patch_abandonment_policy" target="_blank" class="">https://wiki.openstack.org/wiki/Puppet#Patch_abandonment_policy</a></div></div><div dir="ltr" class=""><div class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Jul 9, 2015 at 6:27 PM Stanislaw Bogatkin <<a href="mailto:sbogatkin@mirantis.com" target="_blank" class="">sbogatkin@mirantis.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">2 weeks seems too small for me. We easy can be in situation when fix for medium bug is done, but SCF starts. And gap between SCF and release easily can be more than a month. So, 2 months seems okay for me if speaking about forcibly applying auto-abandon by major vote. And I'm personally against such innovation at all.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Jul 9, 2015 at 5:37 PM, Davanum Srinivas <span dir="ltr" class=""><<a href="mailto:davanum@gmail.com" target="_blank" class="">davanum@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That's a very good plan ("Initial feedback/triage") Mike.<br class="">
<br class="">
thanks,<br class="">
dims<br class="">
<div class=""><div class=""><br class="">
On Thu, Jul 9, 2015 at 3:23 PM, Mike Scherbakov<br class="">
<<a href="mailto:mscherbakov@mirantis.com" target="_blank" class="">mscherbakov@mirantis.com</a>> wrote:<br class="">
> +1 for just reusing existing script, and adjust it on the way. No need to<br class="">
> immediately switch from infinite time to a couple of weeks, we can always<br class="">
> adjust it later. But 1-2 month should be a good start already.<br class="">
><br class="">
> Our current stats [1] look just terrible. Before we enable an auto-abandon,<br class="">
> we need to go every single patch first, and review it / provide comment to<br class="">
> authors. The idea is not to abandon some good patches, and not to offend<br class="">
> contributors...<br class="">
><br class="">
> Let's think how we can approach it. Should we have core reviewers to check<br class="">
> their corresponding components?<br class="">
><br class="">
> [1] <a href="http://stackalytics.com/report/reviews/fuel-group/open" rel="noreferrer" target="_blank" class="">http://stackalytics.com/report/reviews/fuel-group/open</a><br class="">
><br class="">
> On Wed, Jul 8, 2015 at 1:13 PM Sean M. Collins <<a href="mailto:sean@coreitpro.com" target="_blank" class="">sean@coreitpro.com</a>> wrote:<br class="">
>><br class="">
>> Let's keep it at >4 weeks without comment, and Jenkins failed - similar<br class="">
>> to the script that Kyle Mestery uses for Neutron. In fact, we could<br class="">
>> actually just use his script ;)<br class="">
>><br class="">
>><br class="">
>> <a href="https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh" rel="noreferrer" target="_blank" class="">https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh</a><br class="">
>> --<br class="">
>> Sean M. Collins<br class="">
>><br class="">
>> __________________________________________________________________________<br class="">
>> OpenStack Development Mailing List (not for usage questions)<br class="">
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
><br class="">
> --<br class="">
> Mike Scherbakov<br class="">
> #mihgen<br class="">
><br class="">
> __________________________________________________________________________<br class="">
> OpenStack Development Mailing List (not for usage questions)<br class="">
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
><br class="">
<br class="">
<br class="">
<br class="">
--<br class="">
</div></div>Davanum Srinivas :: <a href="https://twitter.com/dims" rel="noreferrer" target="_blank" class="">https://twitter.com/dims</a><br class="">
<div class=""><div class=""><br class="">
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</div></div></blockquote></div><br class=""></div>
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</blockquote></div></div></div><div dir="ltr" class="">-- <br class=""></div><div dir="ltr" class="">Mike Scherbakov<br class="">#mihgen</div>
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org/?subject:unsubscribe" rel="noreferrer" target="_blank" class="">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</blockquote></div>
__________________________________________________________________________<br class="">OpenStack Development Mailing List (not for usage questions)<br class="">Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class=""><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class=""></div></blockquote></div><br class=""></div></div></div></body></html>