<div dir="ltr">Oh, no I didn't. By the time I got around to it I saw 264 and figured that would cover the issue.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 13, 2015 at 7:33 PM, Robert Collins <span dir="ltr"><<a href="mailto:robertc@robertcollins.net" target="_blank">robertc@robertcollins.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 10 July 2015 at 22:07, Kevin Benton <<a href="mailto:blak111@gmail.com">blak111@gmail.com</a>> wrote:<br>
</span><span class="">> No prob. The fixes for Neutron were relatively trivial.<br>
> <a href="https://review.openstack.org/#/c/200420/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/200420/</a><br>
><br>
> The only one that was a bit surprising was the failure of autospec in this<br>
> file:<br>
> <a href="https://review.openstack.org/#/c/200420/4/neutron/tests/unit/services/metering/agents/test_metering_agent.py" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/200420/4/neutron/tests/unit/services/metering/agents/test_metering_agent.py</a><br>
><br>
> It was coming back with argument count mismatch failures. It seems like the<br>
> log decorator[1] trips up autospec in the new version.<br>
><br>
> 1.<br>
> <a href="https://github.com/openstack/neutron/blob/master/neutron/services/metering/drivers/noop/noop_driver.py#L22" rel="noreferrer" target="_blank">https://github.com/openstack/neutron/blob/master/neutron/services/metering/drivers/noop/noop_driver.py#L22</a><br>
<br>
</span>Did you file a bug for that on mock? I don't recall seeing one.<br>
<br>
<a href="https://github.com/testing-cabal/mock/issues/264" rel="noreferrer" target="_blank">https://github.com/testing-cabal/mock/issues/264</a> has a patch upstream<br>
and it works on mock itself, so I'm applying that to cPython and<br>
backporting now.<br>
<br>
-Rob<br>
<div class="HOEnZb"><div class="h5"><br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div>Kevin Benton</div></div>
</div>