<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>
<div>
<div>Hi,</div>
</div>
</div>
<div><br>
</div>
<div>Python 2.6 support was dropped in Kilo (for all of OpenStack). The patchset you mention was just merged last week and will be in Liberty. Trove is no longer being tested with Python 2.6 so it is likely things like this will continue to occur going forward. </div>
<div><br>
</div>
<div>Regards,</div>
<div>Doug</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>³ÂµÏºÀ <<a href="mailto:chendihao@unitedstack.com">chendihao@unitedstack.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Monday, July 6, 2015 at 6:16 AM<br>
<span style="font-weight:bold">To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>[openstack-dev] [trove]The patch from 191859 breaks the compatibility with python 2.6<br>
</div>
<div><br>
</div>
<div>
<div>
<div>Hi all,</div>
<div><br>
</div>
<div>We're deploying trove with python 2.6 in production. And the latest code from <a href="https://review.openstack.org/#/c/191859">https://review.openstack.org/#/c/191859</a> has broken the compatible with python 2.6.</div>
<div><br>
</div>
<div>The actual code which causes it is in trove/guestagent/common/operating_system.py and looks like thest. Python 2.6 has syntax error for this "list" expression.</div>
<div><br>
</div>
<div>
<div>def list_files_in_directory(root_dir, recursive=False, pattern=None):</div>
<div> return {os.path.abspath(os.path.join(root, name))</div>
<div> for (root, _, files) in os.walk(root_dir, topdown=True)</div>
<div> if recursive or (root == root_dir)</div>
<div> for name in files</div>
<div> if not pattern or re.match(pattern, name)}</div>
</div>
<div><br>
</div>
<div>It would be great for anyone to fix it for both python 2.6 and 2.7, right?</div>
<div><br>
</div>
<div>- tobe</div>
<div><tincludetail></tincludetail></div>
<!--<![endif]--></div>
</div>
</span>
</body>
</html>