<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">After thinking about this for a while, I came to think, that we also need a jslinter job for murano-dashboard.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Horizon is currently adopting eslint as a one tool for the job (meant to replace jscs and jshint afaiu), so we could adopt this as part of the blueprint, I filed.</div> <br> <div id="bloop_sign_1434624155297172992" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px">-- <br>Kirill Zaitsev<br>Murano team</div><div style="font-family:helvetica,arial;font-size:13px">Software Engineer</div><div style="font-family:helvetica,arial;font-size:13px">Mirantis, Inc</div></div> <br><p class="airmail_on" style="color:#000;">On 15 Jun 2015 at 02:27:06, Kirill Zaitsev (<a href="mailto:kzaitsev@mirantis.com">kzaitsev@mirantis.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div>
<title></title>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">
Since there were no objections, and as a follow-up I’ve created a
BP for that in murano:
https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs</div>
<br>
<div id="bloop_sign_1434324292067741952" class="bloop_sign">
<div style="font-family:helvetica,arial;font-size:13px">
-- <br>
Kirill Zaitsev<br>
Murano team</div>
<div style="font-family:helvetica,arial;font-size:13px">Software
Engineer</div>
<div style="font-family:helvetica,arial;font-size:13px">Mirantis,
Inc</div>
</div>
<br>
<p class="airmail_on" style="color:#000;">On 10 Jun 2015 at
18:07:19, Filip Blaha (<a href="mailto:filip.blaha@hp.com">filip.blaha@hp.com</a>) wrote:</p>
<blockquote type="cite" class="clean_bq">
<div>
<div><span>Thanks for comment and suggestion!<br>
<br>
there is also shutil2 framework for unit testing over shell
scripts. We<br>
shall consider it whether it could bring us value for the effort.
I<br>
personally have no strong opinion about that. Little contradiction
to my<br>
previous mail:-)<br>
<br>
Regards<br>
Filip<br>
<br>
<br>
<br>
On 06/10/2015 03:34 PM, Jeremy Stanley wrote:<br>
> On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote:<br>
>> +1, nice idea. Shell script are not easy to review - large
files, not<br>
>> covered by unit tests. Any automatic tool could be
beneficial.<br>
> It's worth noting that just because your shell scripts don't
have<br>
> their own validation tests doesn't mean they can't. For
example see<br>
> the test-features.sh and test-functions.sh scripts in
the<br>
> https://git.openstack.org/cgit/openstack-infra/devstack-gate/
repo,<br>
> making sure we maintain a contract on things like branch
fallback<br>
> logic which is easy to subtly break if not tested.<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe:
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe<br>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br>
</span></div>
</div>
</blockquote>
</div></div></span></blockquote></body></html>