<div dir="ltr"><div>Indeed, the doc[1] is unclear<br><br><br></div>git-review can be installed using: python setup.py install or pip install .<br><div><br><br>[1]<a href="http://docs.openstack.org/infra/manual/developers.html#accessing-gerrit-over-https">http://docs.openstack.org/infra/manual/developers.html#accessing-gerrit-over-https</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 11, 2015 at 11:16 PM, KARR, DAVID <span dir="ltr"><<a href="mailto:dk068x@att.com" target="_blank">dk068x@att.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">I see. I would guess a footnote on the instructions about this would be useful. Is
<a href="https://github.com/openstack-infra/git-review" target="_blank">https://github.com/openstack-infra/git-review</a> the proper location to get the buildable source? I don’t see any obvious build instructions there.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> ZZelle [mailto:<a href="mailto:zzelle@gmail.com" target="_blank">zzelle@gmail.com</a>]
<br>
<b>Sent:</b> Thursday, June 11, 2015 2:01 PM</span></p><div><div class="h5"><br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] Looking for help getting git-review to work over https<u></u><u></u></div></div><p></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi David,<br>
<br>
<br>
Following git config options are supported by git-review (<a href="https://review.openstack.org/116035" target="_blank">https://review.openstack.org/116035</a>)<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"> git config --global gitreview.scheme https<br>
git config --global gitreview.port 443<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">BUT the feature was merged after 1.24 (it's highlighted by your git review -vs)
<br>
so the feature is currently only available on the git-review master branch (which<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">is quite stable, i use it every day).<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Cedric/ZZelle@irc<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Jun 11, 2015 at 10:14 PM, KARR, DAVID <<a href="mailto:dk068x@att.com" target="_blank">dk068x@att.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div style="border:none;border-bottom:solid windowtext 1.0pt;padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">I followed the instructions for installing and configuring corkscrew, similar to what you provided here. The
result seems to indicate it did something, but the overall result is the same:</span><u></u><u></u></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 13:07:25.866568 Running: git log --color=never --oneline HEAD^1..HEAD</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 13:07:25.869309 Running: git remote</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 13:07:25.872742 Running: git config --get gitreview.username</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">No remote set, testing ssh://<a href="http://dk068x@review.openstack.org:29418/openstack/horizon.git" target="_blank">dk068x@review.openstack.org:29418/openstack/horizon.git</a></span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 13:07:25.874869 Running: git push --dry-run ssh://<a href="http://dk068x@review.openstack.org:29418/openstack/horizon.git" target="_blank">dk068x@review.openstack.org:29418/openstack/horizon.git</a>
--all</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">The authenticity of host '[<a href="http://review.openstack.org" target="_blank">review.openstack.org</a>]:29418
(<no hostip for proxy command>)' can't be established.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">RSA key fingerprint is 28:c6:42:b7:44:d2:48:64:c1:3f:31:d8:1b:6e:3b:63.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Are you sure you want to continue connecting (yes/no)? yes</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">ssh://<a href="http://dk068x@review.openstack.org:29418/openstack/horizon.git" target="_blank">dk068x@review.openstack.org:29418/openstack/horizon.git</a>
did not work.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Could not connect to gerrit.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Enter your gerrit username:</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">---------------------------</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Paul Michali [mailto:<a href="mailto:pc@michali.net" target="_blank">pc@michali.net</a>]
<br>
<b>Sent:</b> Thursday, June 11, 2015 11:09 AM</span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] Looking for help getting git-review to work over https<u></u><u></u></p>
</div>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">Do you know if you have SSH access to the outside world through the firewall?<u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Did you setup a proxy? I setup 'corkscrew' under Ubuntu. After installing, created a .ssh/config file with:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Host
<a href="http://review.openstack.org" target="_blank">review.openstack.org</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> ProxyCommand corkscrew <proxy-host> 80 %h %p<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">The proxy host is one that allows HTTP/HTTPS to outside world and corkscrew tunnels the SSH through to port 80.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">HTHs,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">PCM<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, Jun 11, 2015 at 12:44 PM KARR, DAVID <<a href="mailto:dk068x@att.com" target="_blank">dk068x@att.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<div style="border:none;border-bottom:solid windowtext 1.0pt;padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Thanks for replying.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">% git review -vs</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 09:30:38.396076 Running: git log --color=never --oneline HEAD^1..HEAD</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 09:30:38.399021 Running: git remote</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 09:30:38.401033 Running: git config --get gitreview.username</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">No remote set, testing ssh://<a href="http://dk068x@review.openstack.org:29418/openstack/horizon.git" target="_blank">dk068x@review.openstack.org:29418/openstack/horizon.git</a></span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">2015-06-11 09:30:38.402988 Running: git push --dry-run ssh://<a href="http://dk068x@review.openstack.org:29418/openstack/horizon.git" target="_blank">dk068x@review.openstack.org:29418/openstack/horizon.git</a>
--all</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">ssh://<a href="http://dk068x@review.openstack.org:29418/openstack/horizon.git" target="_blank">dk068x@review.openstack.org:29418/openstack/horizon.git</a>
did not work.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Could not connect to gerrit.</span><u></u><u></u></p>
<div style="border:none;border-bottom:solid windowtext 1.0pt;padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Enter your gerrit username:</span><u></u><u></u></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
<div style="border:none;border-bottom:solid windowtext 1.0pt;padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">This output is interesting, because I followed the instructions to set the scheme and port to https and 443,
which can be seen from:</span><u></u><u></u></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">% git config --global -l</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"><a href="http://user.name" target="_blank">user.name</a>=David Karr</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">user.email=<a href="mailto:dk068x@att.com" target="_blank">dk068x@att.com</a></span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">gitreview.scheme=https</span><u></u><u></u></p>
<div style="border:none;border-bottom:solid windowtext 1.0pt;padding:0in 0in 1.0pt 0in">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">gitreview.port=443</span><u></u><u></u></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">Concerning the question ‘Do you have "gerrit" remote already configured?’, I guess I’d have to say I don’t know.
I’ve followed instructions for setting up my pub key, but I’m not sure exactly what is entailed in “gerrit remote”.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">I can get to
<a href="https://review.openstack.org/" target="_blank">https://review.openstack.org/</a> from my browser and from the command line with curl.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a">The “ls-remote” command returns without error (or any other output).</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Inconsolata;color:#44546a"> </span><u></u><u></u></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Yuriy Taraday [mailto:<a href="mailto:yorik.sar@gmail.com" target="_blank">yorik.sar@gmail.com</a>]
<br>
<b>Sent:</b> Thursday, June 11, 2015 9:19 AM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] Looking for help getting git-review to work over https</span><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p>On Thu, Jun 11, 2015, 18:09 KARR, DAVID <<a href="mailto:dk068x@att.com" target="_blank">dk068x@att.com</a>> wrote:<u></u><u></u></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p>I could use some help with setting up git-review in a slightly unfriendly firewall situation.<u></u><u></u></p>
<p>I'm trying to set up git-review on my CentOS7 VM, and our firewall blocks the non-standard ssh port. I'm following the instructions at
<a href="http://docs.openstack.org/infra/manual/developers.html#accessing-gerrit-over-https" target="_blank">
http://docs.openstack.org/infra/manual/developers.html#accessing-gerrit-over-https</a> , for configuring git-review to use https on port 443, but this still isn't working (times out with "Could not connect to gerrit"). I've confirmed that I can reach other
external sites on port 443.<u></u><u></u></p>
<p>Can someone give me a hand with this?<u></u><u></u></p>
</blockquote>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p> <u></u><u></u></p>
</blockquote>
<p> <u></u><u></u></p>
<p>Hello.<u></u><u></u></p>
<p> <u></u><u></u></p>
<p>- Can you please post all output from "git review -vs"?<u></u><u></u></p>
<p>- Do you have "gerrit" remote already configured?<u></u><u></u></p>
<p>- Do you have access to <a href="https://review.openstack.org/" target="_blank">
https://review.openstack.org/</a> from your browser?<u></u><u></u></p>
<p>- Can you access it from command line (via "curl -I <a href="https://review.openstack.org/" target="_blank">
https://review.openstack.org/</a>" for example)?<u></u><u></u></p>
<p>- Does "git ls-remote <a href="https://review.openstack.org/openstack/nova" target="_blank">
https://review.openstack.org/openstack/nova</a> > /dev/null" produce and error?<u></u><u></u></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal">__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>