<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">+1, nice idea. Shell script are not
easy to review - large files, not covered by unit tests. Any
automatic tool could be beneficial.<br>
<br>
Regards<br>
Filip<br>
<br>
On 06/09/2015 09:58 PM, Kirill Zaitsev wrote:<br>
</div>
<blockquote cite="mid:etPan.55774557.53358796.154@TefMBPr.local"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<style>body{font-family:Helvetica,Arial;font-size:13px}</style>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Folks, I’ve
got another proposal, mainly to the guys, who deal with CI and
test jobs daily.</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br>
</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;">What would you
say about adding a job to murano-deployment, that would launch
shellcheck <a moz-do-not-send="true"
href="http://www.shellcheck.net/about.html">http://www.shellcheck.net/about.html</a> against
all .sh files? </div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br>
</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;">I use it, when
reviewing .sh scripts (well, actually my vim does it for me =P)
and although It has some excessive checks I find it quite
useful.</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br>
</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;">We could also
add a similar job to murano-apps, since they use shell scripts
quite often.</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br>
</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Any objections
to this idea?</div>
<div id="bloop_customfont"
style="font-family:Helvetica,Arial;font-size:13px; color:
rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br>
</div>
<br>
<div id="bloop_sign_1433879305970240000" class="bloop_sign">
<div style="font-family:helvetica,arial;font-size:13px">-- <br>
Kirill Zaitsev<br>
Murano team</div>
<div style="font-family:helvetica,arial;font-size:13px">Software
Engineer</div>
<div style="font-family:helvetica,arial;font-size:13px">Mirantis,
Inc</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: <a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<a class="moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>