<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>I think there may just be some non-updated docstrings here. We should take only the 'ref'. If we get a UUID we wont know how to build it or what to do with it. The naming of this does need to change, but I dont' believe we need to convert UUID to ref. <br>
</p>
<p><br>
</p>
<p>Is 's<span style="color: rgb(33, 33, 33); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">elf.g</span><span style="color: rgb(33, 33, 33); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">et_cert_ref_url</span><span style="color: rgb(33, 33, 33); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">(cert_ref)</span>'
something already available that i may be over looking or an example?<br>
</p>
<p><br>
</p>
<p>IMO, we need to go through and make sure the 'container_ref' is updated to be consistent throughout the project for the barbican stuff and is something I plan on doing once I get a chance if no body else does. <br>
</p>
<p><br>
</p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>Phillip V. Toohill III</div>
<div>Software Developer</div>
<div><img style="margin:0px; padding:0px; border:0px; font-family:Arial,sans-serif; font-size:10px; line-height:10px; vertical-align:top; outline:none; max-width:100%; text-align:right; color:rgb(102,102,102)" src="http://600a2794aa4ab5bae6bd-8d3014ab8e4d12d3346853d589a26319.r53.cf1.rackcdn.com/signatures/images/rackspace_logo.png"></div>
<div>phone: 210-312-4366</div>
<div>mobile: 210-440-8374</div>
<div><br>
</div>
</div>
</div>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> santosh sharma <chitr.prayatan@gmail.com><br>
<b>Sent:</b> Thursday, June 4, 2015 12:08 AM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> [openstack-dev] [neutron][lbaas]Error at listener's barbican container validation</font>
<div> </div>
</div>
<div>
<div dir="ltr"><br clear="all">
<div>
<div>There is error while validating the barabican containers associated with listener (tls and sni container) at plugin layer.</div>
<div><br>
</div>
<div>In validate_tls_container() ,<b>contain_id</b> is passed where as it is expecting
<b>container_ref_url</b>.</div>
<div><br>
</div>
<div> def _validate_tls(self, listener, curr_listener=None):</div>
<div><br>
</div>
<div> def validate_tls_container(container_ref):</div>
<div> ...</div>
<div><br>
</div>
<div> def validate_tls_containers(to_validate):</div>
<div> for container_ref in to_validate:</div>
<div> validate_tls_container(container_ref)</div>
<div> ...</div>
<div> if len(to_validate) > 0:</div>
<div> validate_tls_containers(to_validate)</div>
<div><br>
</div>
<div><b><font color="#ff0000">#to_validate is list of container_ids.</font></b></div>
<div><font color="#ff0000"><br>
</font></div>
<div><b><font color="#ff0000"># barbican_cert_manager.py ,at get_cert() cert_ref is UUID instead of ref_url for container.</font></b></div>
<div><br>
</div>
<div>def get_cert(cert_ref, service_name='Octavia', resource_ref=None,</div>
<div> check_only=False, **kwargs):</div>
<div><br>
</div>
<div> ...</div>
<div> :param cert_ref: the UUID of the cert to retrieve</div>
<div> ...</div>
<div><br>
</div>
<div> cert_container = connection.containers.get(</div>
<div> container_ref=cert_ref</div>
<div><br>
</div>
<div><b><font color="#ff0000">#above container_ref is a UUID whereas connection.container.get() expects a reference url.</font></b></div>
<div><br>
</div>
<div><b>We should prepare ref_url from container UUID before passing to barbican client apis.</b></div>
<div><b>following should fix the issue.</b></div>
<div><br>
</div>
<div>diff --git a/neutron_lbaas/common/cert_manager/barbican_cert_manager.py b/neutron_lbaas/common/cert_manager/barbican_cert_manager.py</div>
<div>index 1ad38ee..8d3c3c4 100644</div>
<div>--- a/neutron_lbaas/common/cert_manager/barbican_cert_manager.py</div>
<div>+++ b/neutron_lbaas/common/cert_manager/barbican_cert_manager.py</div>
<div>@@ -219,6 +222,9 @@ class CertManager(cert_manager.CertManager):</div>
<div> """</div>
<div> connection = BarbicanKeystoneAuth.get_barbican_client()</div>
<div><br>
</div>
<div>+ if self.is_UUID(cert_ref):</div>
<div>+ cert_ref = self.get_cert_ref_url(cert_ref)</div>
<div>+<br>
</div>
<div><br>
</div>
<div><b>Error log:</b></div>
<div>-----------------------------------------------------------------------------------------------------------------------------------------------</div>
<div>ERROR neutron_lbaas.common.cert_manager.barbican_cert_manager [req-a5e704fb-f04b-45f2-9c50-f3bfebe09afd admin 5ca9f</div>
<div>cbf4652456a9bd53582b86bd0e9] Error getting 0b8d5af0-c156-46ad-b4c6-882a84824ce2</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager Traceback (most recent call last):</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager File "/opt/stack/neutron-lbaas/neutron_lbaas/common</div>
<div>/cert_manager/barbican_cert_manager.py", line 228, in get_cert</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager container_ref=cert_ref</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager File "/opt/stack/python-barbicanclient/barbicanclie</div>
<div>nt/containers.py", line 528, in get</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager base.validate_ref(container_ref, 'Container')</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager File "/opt/stack/python-barbicanclient/barbicanclie</div>
<div>nt/base.py", line 35, in validate_ref</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager raise ValueError('{0} incorrectly specified.'.for</div>
<div>mat(entity))</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager ValueError: Container incorrectly specified.</div>
<div>2015-06-04 09:58:38.126 TRACE neutron_lbaas.common.cert_manager.barbican_cert_manager</div>
<div>2015-06-04 09:58:38.167 INFO neutron.api.v2.resource [req-a5e704fb-f04b-45f2-9c50-f3bfebe09afd admin 5ca9fcbf4652456a9bd53582b86bd0e9] crea</div>
<div>te failed (client error): TLS container 0b8d5af0-c156-46ad-b4c6-882a84824ce2 could not be found</div>
<div>---------------------------------------------------------------------------------------------------------------------------------------------------</div>
</div>
--
<div><br>
</div>
<div>Thanks<br>
<div class="gmail_signature">Santosh</div>
</div>
</div>
</div>
</div>
</body>
</html>