<div dir="ltr">I have now submitted the patch to do the html shenanigans as a new step in the current ngReorg pipeline (inserted because it should fix a test failure popping up in the dashboard-app move final step).<br><div><br></div><div><a href="https://review.openstack.org/#/c/186295/">https://review.openstack.org/#/c/186295/</a><br></div><div><br></div><div>Ryan's API reorg should probably depend on this patch also as that should fix *its* test failures also.</div><div><br></div><div>And before anyone says anything, no I'm not particularly thrilled about the new horizon/test/templates/base.html but frankly I'm not sure how else to make it work. We could probably cull the JS from that file though. I'm pretty sure none of the django unit tests exercise JS, and I believe Selenium works off a different interface (but I've run out of time today to investigate).</div><div><br></div><div><br></div><div> Richard</div><div><br></div></div><br><div class="gmail_quote">On Thu, 28 May 2015 at 02:15 Thai Q Tran <<a href="mailto:tqtran@us.ibm.com">tqtran@us.ibm.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2">Yes Rob, you are correct. ToastService was something Cindy wrote to replace horizon.alert (aka messages). We can't remove it because legacy still uses it.<br><br><font color="#990099">-----"Rob Cresswell (rcresswe)" <<a href="mailto:rcresswe@cisco.com" target="_blank">rcresswe@cisco.com</a>> wrote: -----</font><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px"></div></div></font><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2"><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px">To: "OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br></div></div></font><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2"><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px">From: "Rob Cresswell (rcresswe)" <<a href="mailto:rcresswe@cisco.com" target="_blank">rcresswe@cisco.com</a>><br>Date: 05/26/2015 11:29PM</div></div></font><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2"><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px"><br>Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon<br><br>
<div>Went through the files myself and I concur. Most of these files define pieces specific to our implementation of the dashboard, so should be moved.</div>
<div><br>
</div>
<div>I’m not entirely sure on where _messages should sit. As we move forward, won’t that file just end up as a <toast> element and nothing more? Maybe I’m misinterpreting it, I’m not familiar with toastService.</div>
<div><br>
</div>
<div>Rob</div>
<div><br>
</div>
<div><br>
</div>
<span>
<div style="font-family:Calibri;font-size:11pt;text-align:left;color:black;BORDER-BOTTOM:medium none;BORDER-LEFT:medium none;PADDING-BOTTOM:0in;PADDING-LEFT:0in;PADDING-RIGHT:0in;BORDER-TOP:#b5c4df 1pt solid;BORDER-RIGHT:medium none;PADDING-TOP:3pt">
<span style="font-weight:bold">From: </span>Richard Jones <<a href="mailto:r1chardj0n3s@gmail.com" target="_blank">r1chardj0n3s@gmail.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Tuesday, 26 May 2015 01:35<br>
<span style="font-weight:bold">To: </span>"OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Cc: </span>"Johanson, Tyr H" <<a href="mailto:tyr@hp.com" target="_blank">tyr@hp.com</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Horizon] dashboard-app split in horizon<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">As a follow-up to this [in the misguided hope that anyone will actually read this conversation with myself ;-)] I've started looking at the base.html split. At the summit last week, we agreed to:
<div><br>
</div>
<div>1. move base.html over from the framework to the dashboard, and</div>
<div>2. move the _conf.html and _scripts.html over as well, since they configure the application (dashboard).</div>
<div><br>
</div>
<div>Upon starting the work it occurs to me that all of the other files referenced by base.html should also move. So, here's the complete list of base.html components and whether they should move over in my opinion:</div>
<div><br>
</div>
<div>- horizon/_custom_meta.html</div>
<div> Yep, is an empty file in horizon, intended as an extension point in dashboard. The empty file (plus an added comment) should move.</div>
<div> - horizon/_stylesheets.html</div>
<div> Is just a dummy in horizon anyway, should move.</div>
<div>- horizon/_conf.html</div>
<div> Yep, should move.</div>
<div>- horizon/client_side/_script_loader.html</div>
<div> Looks to be a framework component not intended for override, so we should leave it there.</div>
<div>- horizon/_custom_head_js.html</div>
<div>
<div> Yep, is an empty file in horizon, intended as an extension point in dashboard. Move, with a comment added.</div>
</div>
<div>- horizon/_header.html</div>
<div> There is a basic implementation in framework but the real (used) implementation is in dashboard, so should move.</div>
<div>- horizon/_messages.html</div>
<div> This is a framework component, so I think should stay there. I'm not sure whether anyone would ever wish to override this. Also the bulk of it is probably going to be replaced by the <toast> implementation anyway... hmm...</div>
<div>- horizon/common/_sidebar.html</div>
<div> This is an overridable component that I think should move.</div>
<div>- horizon/common/_page_header.html</div>
<div> This is an overridable component that I think should move. </div>
<div>- horizon/_scripts.html</div>
<div>
<div> Yep, should move.</div>
</div>
<div><br>
</div>
<div>Thoughts, anyone who has read this far?</div>
<div><br>
</div>
<div><br>
</div>
<div> Richard</div>
<div><br>
<br>
<div class="gmail_quote">On Sat, 23 May 2015 at 11:46 Richard Jones <<a href="mailto:r1chardj0n3s@gmail.com" target="_blank">r1chardj0n3s@gmail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>As part of the ongoing Horizon project code reorganisation, we today agreed to clean up the Horizon-the-Framework and OpenStack Dashboard separation issue by doing a couple of things:</div>
<div><br>
</div>
<div>1. nuke (the recently-created) horizon dashboard-app by moving the angular app over to dashboard and the other contents to appropriate places (mostly under the heading of "tech-debt" :)</div>
<div>2. move base.html, _conf.html and _scripts.html from horizon over to dashboard.</div>
<div><br>
</div>
<div>Thanks to Cindy, Sean and Thai for the pair (er triple?) programming keeping me honest today.</div>
<div><br>
</div>
<div>The first step is done and captured in several linked patches based off your leaf patch "ngReorg - Create dashboard-app" <<a href="https://review.openstack.org/#/c/184597/" target="_blank">https://review.openstack.org/#/c/184597/</a>> (yes, I am nuking
the thing created by your patch).</div>
<div><br>
</div>
<div>I've not done the second step, but might find some time since I have 6 hours to waste in LAX tomorrow.</div>
</div>
<div dir="ltr">
<div><br>
</div>
<div><br>
</div>
<div> Richard</div>
<div><br>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</span>
<div><font face="Courier New,Courier,monospace" size="3">__________________________________________________________________________<br>OpenStack Development Mailing List (not for usage questions)<br>Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br></font></div></div></div></font>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div>