<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>Hi,</div>
<div>I prefer the patched posted by Sabari. The patch has two changes:</div>
<ol>
<li>It fixes unit tests</li><li>In the even that an instance spawn fails then it catches an exception to warn the admin that the guestId may be invalid. The only degradation may be that the warning will no longer be there. I think that the admin can get this information from the logged
exception too.</li></ol>
<div>Thanks</div>
<div>Gary</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Sabari Murugesan <<a href="mailto:sabari.bits@gmail.com">sabari.bits@gmail.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Wednesday, May 27, 2015 at 6:20 AM<br>
<span style="font-weight:bold">To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] oslo.vmware release 0.13.0 (liberty)<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">Matt
<div><br>
</div>
<div>I posted a patch <a href="https://review.openstack.org/#/c/185830/1">https://review.openstack.org/#/c/185830/1</a> to fix the nova tests and make it compatible with the oslo.vmware 0.13.0 release. I am fine with the revert and g-r blacklist as oslo.vmware
broke the semver but we can also consider this patch as an option.</div>
<div><br>
</div>
<div>Thanks</div>
<div>Sabari</div>
<div><br>
</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, May 26, 2015 at 2:53 PM, Davanum Srinivas <span dir="ltr">
<<a href="mailto:davanum@gmail.com" target="_blank">davanum@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Vipin, Gary,<br>
<br>
Can you please accept the revert or figure out the best way to handle this?<br>
<br>
thanks,<br>
dims<br>
<div class="HOEnZb">
<div class="h5"><br>
On Tue, May 26, 2015 at 5:41 PM, Matt Riedemann<br>
<<a href="mailto:mriedem@linux.vnet.ibm.com">mriedem@linux.vnet.ibm.com</a>> wrote:<br>
><br>
><br>
> On 5/26/2015 4:19 PM, Matt Riedemann wrote:<br>
>><br>
>><br>
>><br>
>> On 5/26/2015 9:53 AM, Davanum Srinivas wrote:<br>
>>><br>
>>> We are gleeful to announce the release of:<br>
>>><br>
>>> oslo.vmware 0.13.0: Oslo VMware library<br>
>>><br>
>>> With source available at:<br>
>>><br>
>>> <a href="http://git.openstack.org/cgit/openstack/oslo.vmware" target="_blank">
http://git.openstack.org/cgit/openstack/oslo.vmware</a><br>
>>><br>
>>> For more details, please see the git log history below and:<br>
>>><br>
>>> <a href="http://launchpad.net/oslo.vmware/+milestone/0.13.0" target="_blank">
http://launchpad.net/oslo.vmware/+milestone/0.13.0</a><br>
>>><br>
>>> Please report issues through launchpad:<br>
>>><br>
>>> <a href="http://bugs.launchpad.net/oslo.vmware" target="_blank">http://bugs.launchpad.net/oslo.vmware</a><br>
>>><br>
>>> Changes in oslo.vmware 0.12.0..0.13.0<br>
>>> -------------------------------------<br>
>>><br>
>>> 5df9daa Add ToolsUnavailable exception<br>
>>> 286cb9e Add support for dynamicProperty<br>
>>> 7758123 Remove support for Python 3.3<br>
>>> 11e7d71 Updated from global requirements<br>
>>> 883c441 Remove run_cross_tests.sh<br>
>>> 1986196 Use suds-jurko on Python 2<br>
>>> 84ab8c4 Updated from global requirements<br>
>>> 6cbde19 Imported Translations from Transifex<br>
>>> 8d4695e Updated from global requirements<br>
>>> 1668fef Raise VimFaultException for unknown faults<br>
>>> 15dbfb2 Imported Translations from Transifex<br>
>>> c338f19 Add NoDiskSpaceException<br>
>>> 25ec49d Add utility function to get profiles by IDs<br>
>>> 32c61ee Add bandit to tox for security static analysis<br>
>>> f140b7e Add SPBM WSDL for vSphere 6.0<br>
>>><br>
>>> Diffstat (except docs and test files)<br>
>>> -------------------------------------<br>
>>><br>
>>> bandit.yaml | 130 +++<br>
>>> openstack-common.conf | 2 -<br>
>>> .../locale/fr/LC_MESSAGES/oslo.vmware-log-error.po | 9 -<br>
>>> .../locale/fr/LC_MESSAGES/oslo.vmware-log-info.po | 3 -<br>
>>> .../fr/LC_MESSAGES/oslo.vmware-log-warning.po | 10 -<br>
>>> oslo.vmware/locale/fr/LC_MESSAGES/oslo.vmware.po | 86 +-<br>
>>> oslo.vmware/locale/oslo.vmware.pot | 48 +-<br>
>>> oslo_vmware/api.py | 10 +-<br>
>>> oslo_vmware/exceptions.py | 13 +-<br>
>>> oslo_vmware/objects/datastore.py | 6 +-<br>
>>> oslo_vmware/pbm.py | 18 +<br>
>>> oslo_vmware/service.py | 2 +-<br>
>>> oslo_vmware/wsdl/6.0/core-types.xsd | 237 +++++<br>
>>> oslo_vmware/wsdl/6.0/pbm-messagetypes.xsd | 186 ++++<br>
>>> oslo_vmware/wsdl/6.0/pbm-types.xsd | 806 ++++++++++++++<br>
>>> oslo_vmware/wsdl/6.0/pbm.wsdl | 1104<br>
>>> ++++++++++++++++++++<br>
>>> oslo_vmware/wsdl/6.0/pbmService.wsdl | 16 +<br>
>>> requirements-py3.txt | 27 -<br>
>>> requirements.txt | 8 +-<br>
>>> setup.cfg | 2 +-<br>
>>> test-requirements-bandit.txt | 1 +<br>
>>> tox.ini | 14 +-<br>
>>> 27 files changed, 2645 insertions(+), 262 deletions(-)<br>
>>><br>
>>><br>
>>> Requirements updates<br>
>>> --------------------<br>
>>><br>
>>> diff --git a/requirements.txt b/requirements.txt<br>
>>> index 807bcfc..dd5a1aa 100644<br>
>>> --- a/requirements.txt<br>
>>> +++ b/requirements.txt<br>
>>> @@ -5 +5 @@<br>
>>> -pbr>=0.6,!=0.7,<1.0<br>
>>> +pbr>=0.11,<2.0<br>
>>> @@ -23,3 +23,3 @@ PyYAML>=3.1.0<br>
>>> -suds>=0.4<br>
>>> -eventlet>=0.16.1,!=0.17.0<br>
>>> -requests>=2.2.0,!=2.4.0<br>
>>> +suds-jurko>=0.6<br>
>>> +eventlet>=0.17.3<br>
>>> +requests>=2.5.2<br>
>>> diff --git a/test-requirements-bandit.txt b/test-requirements-bandit.txt<br>
>>> new file mode 100644<br>
>>> index 0000000..38c39e1<br>
>>> --- /dev/null<br>
>>> +++ b/test-requirements-bandit.txt<br>
>>> @@ -0,0 +1 @@<br>
>>> +bandit==0.10.1<br>
>>><br>
>>><br>
>>><br>
>><br>
>> There is now a blocking vmware unit tests bug in nova due to the<br>
>> oslo.vmware 0.13.0 release:<br>
>><br>
>> <a href="https://bugs.launchpad.net/nova/+bug/1459021" target="_blank">https://bugs.launchpad.net/nova/+bug/1459021</a><br>
>><br>
>> Since the vmware driver unit test code in nova likes to stub out<br>
>> external APIs there is probably a bug in the nova unit tests rather than<br>
>> an issue in oslo.vmware, but I'm not very familiar so I can't really say.<br>
>><br>
><br>
> I have a revert for oslo.vmware here:<br>
><br>
> <a href="https://review.openstack.org/#/c/185744/" target="_blank">https://review.openstack.org/#/c/185744/</a><br>
><br>
> And a block on the 0.13.0 version in global-requirements here:<br>
><br>
> <a href="https://review.openstack.org/#/c/185748/" target="_blank">https://review.openstack.org/#/c/185748/</a><br>
><br>
><br>
> --<br>
><br>
> Thanks,<br>
><br>
> Matt Riedemann<br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
<br>
<br>
</div>
</div>
<span class="im HOEnZb">--<br>
Davanum Srinivas :: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__twitter.com_dims&d=BQMFAw&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=VlZxHpZBmzzkWT5jqz9JYBk8YTeq9N3-diTlNj4GyNc&m=H5FruU_lGECJ7hf40Wo8bk4D7doq-0qZbLA6MCCiSNc&s=Hm_e9bhdBa-VF9V33roww1r5uV_grvbjTTgk9wu_uQA&e=" target="_blank">
https://twitter.com/dims</a><br>
<br>
</span>
<div class="HOEnZb">
<div class="h5">__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</span>
</body>
</html>