<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 25, 2015 at 5:35 PM, Richard Jones <span dir="ltr"><<a href="mailto:r1chardj0n3s@gmail.com" target="_blank">r1chardj0n3s@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">As a follow-up to this [in the misguided hope that anyone will actually read this conversation with myself ;-)] I've started looking at the base.html split. At the summit last week, we agreed to:<div><br></div><div>1. move base.html over from the framework to the dashboard, and</div><div>2. move the _conf.html and _scripts.html over as well, since they configure the application (dashboard).</div><div><br></div><div>Upon starting the work it occurs to me that all of the other files referenced by base.html should also move. So, here's the complete list of base.html components and whether they should move over in my opinion:</div><div><br></div><div>- horizon/_custom_meta.html</div><div> Yep, is an empty file in horizon, intended as an extension point in dashboard. The empty file (plus an added comment) should move.</div><div> - horizon/_stylesheets.html</div><div> Is just a dummy in horizon anyway, should move.</div><div>- horizon/_conf.html</div><div> Yep, should move.</div><div>- horizon/client_side/_script_loader.html</div><div> Looks to be a framework component not intended for override, so we should leave it there.</div><div>- horizon/_custom_head_js.html</div><div><div> Yep, is an empty file in horizon, intended as an extension point in dashboard. Move, with a comment added.</div></div><div>- horizon/_header.html</div><div> There is a basic implementation in framework but the real (used) implementation is in dashboard, so should move.</div><div>- horizon/_messages.html</div><div> This is a framework component, so I think should stay there. I'm not sure whether anyone would ever wish to override this. Also the bulk of it is probably going to be replaced by the <toast> implementation anyway... hmm...</div><div>- horizon/common/_sidebar.html</div><div> This is an overridable component that I think should move.</div><div>- horizon/common/_page_header.html</div><div> This is an overridable component that I think should move. </div><div>- horizon/_scripts.html</div><div><div> Yep, should move.</div></div><div><br></div><div>Thoughts, anyone who has read this far?</div><span class=""><font color="#888888"><div><br></div><div><br></div><div> Richard</div></font></span><div><div class="h5"><div><br><br><div class="gmail_quote">On Sat, 23 May 2015 at 11:46 Richard Jones <<a href="mailto:r1chardj0n3s@gmail.com" target="_blank">r1chardj0n3s@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>As part of the ongoing Horizon project code reorganisation, we today agreed to clean up the Horizon-the-Framework and OpenStack Dashboard separation issue by doing a couple of things:</div><div><br></div><div>1. nuke (the recently-created) horizon dashboard-app by moving the angular app over to dashboard and the other contents to appropriate places (mostly under the heading of "tech-debt" :)</div><div>2. move base.html, _conf.html and _scripts.html from horizon over to dashboard.</div><div><br></div><div>Thanks to Cindy, Sean and Thai for the pair (er triple?) programming keeping me honest today.</div><div><br></div><div>The first step is done and captured in several linked patches based off your leaf patch "ngReorg - Create dashboard-app" <<a href="https://review.openstack.org/#/c/184597/" target="_blank">https://review.openstack.org/#/c/184597/</a>> (yes, I am nuking the thing created by your patch).</div><div><br></div><div>I've not done the second step, but might find some time since I have 6 hours to waste in LAX tomorrow.</div></div><div dir="ltr"><div><br></div><div><br></div><div> Richard</div><div><br></div></div></blockquote></div></div></div></div></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><div class="gmail_extra"><br></div>This all sounds reasonable to me. We have better extension mechanisms than in the past so direct reuse of the horizon toolkit part is not necessary and we have little interest in maintaining the horizon toolkit as a generally reusable toolkit now. Moving the application pieces into openstack_dashboard (the actual application) makes sense. </div><div class="gmail_extra"><br></div><div class="gmail_extra">David</div></div>