On Monday, May 4, 2015, Matt Riedemann <<a href="mailto:mriedem@linux.vnet.ibm.com">mriedem@linux.vnet.ibm.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 5/4/2015 11:12 AM, Alessandro Pilotti wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Matt,<br>
<br>
We originally proposed a Juno spec for this blueprint, but it got postponed to Kilo where it has been approved without a spec together with other hypervisor specific blueprints (the so called “trivial” case).<br>
<br>
The BP itself is completed and marked accordingly on launchpad.<br>
<br>
Patches referenced in the BP:<br>
<br>
<a href="https://review.openstack.org/#/c/103945/" target="_blank">https://review.openstack.org/#/c/103945/</a><br>
Abandoned: Juno specs.<br>
<br>
<a href="https://review.openstack.org/#/c/107177/" target="_blank">https://review.openstack.org/#/c/107177/</a><br>
Merged<br>
<br>
<a href="https://review.openstack.org/#/c/107185/" target="_blank">https://review.openstack.org/#/c/107185/</a><br>
Merged<br>
<br>
<a href="https://review.openstack.org/#/c/137429/" target="_blank">https://review.openstack.org/#/c/137429/</a><br>
Abandoned: Acording to the previous discussions on IRC, this commit is no longer necessary.<br>
<br>
<a href="https://review.openstack.org/#/c/137429/" target="_blank">https://review.openstack.org/#/c/137429/</a><br>
Abandoned: Acording to the previous discussions on IRC, this commit is no longer necessary.<br>
<br>
<a href="https://review.openstack.org/#/c/145268/" target="_blank">https://review.openstack.org/#/c/145268/</a><br>
Abandoned, due to sqlalchemy model limitations<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 04 May 2015, at 18:41, Matt Riedemann <<a>mriedem@linux.vnet.ibm.com</a>> wrote:<br>
<br>
This spec was never approved [1] but the code was merged in Kilo [2].<br>
<br>
The blueprint is marked complete in launchpad [3] and it's referenced as a new feature in the hyper-v driver in the kilo release notes [4], but there is no spec published for consumers that detail the feature [5]. Also, the spec mentioned doc impacts which I have to assume weren't made, and there were abandoned patches [6] tied to the blueprint, so is this half-baked or not?  Are we missing information in the kilo release notes?<br>
<br>
How do we retroactively approve a spec so it's published to <a href="http://specs.openstack.org" target="_blank">specs.openstack.org</a> for posterity when obviously our review process broke down?<br>
<br>
[1] <a href="https://review.openstack.org/#/c/103945/" target="_blank">https://review.openstack.org/#/c/103945/</a><br>
[2] <a href="https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:bp/hyper-v-generation-2-vms,n,z" target="_blank">https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:bp/hyper-v-generation-2-vms,n,z</a><br>
[3] <a href="https://blueprints.launchpad.net/nova/+spec/hyper-v-generation-2-vms" target="_blank">https://blueprints.launchpad.net/nova/+spec/hyper-v-generation-2-vms</a><br>
[4] <a href="https://wiki.openstack.org/wiki/ReleaseNotes/Kilo#Hyper-V" target="_blank">https://wiki.openstack.org/wiki/ReleaseNotes/Kilo#Hyper-V</a><br>
[5] <a href="http://specs.openstack.org/openstack/nova-specs/specs/kilo/" target="_blank">http://specs.openstack.org/openstack/nova-specs/specs/kilo/</a><br>
[6] <a href="https://review.openstack.org/#/q/status:abandoned+project:openstack/nova+branch:master+topic:bp/hyper-v-generation-2-vms,n,z" target="_blank">https://review.openstack.org/#/q/status:abandoned+project:openstack/nova+branch:master+topic:bp/hyper-v-generation-2-vms,n,z</a><br>
<br>
--<br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br>
</blockquote>
<br>
OK, but this doesn't answer all of the questions.<br>
<br>
1. Are there doc impacts from the spec that need to be in the kilo release notes?  For example, the spec says:<br>
<br>
"The Nova driver documentation should include an entry about this topic<br>
including when to use and when not to use generation 2 VMs. A note on the relevant Glance image property should be added as well."<br>
<br>
I don't see any of that in the kilo release notes.</blockquote><div><br></div><div>They were generated from UpgradeImpact messages in commits, I guess we missed this one here, let's add that, thank you.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
2. If we have a feature merged, we should have something in <a href="http://specs.openstack.org" target="_blank">specs.openstack.org</a> for operators to go back to reference rather than dig through ugly launchpad whiteboards or incomplete gerrit reviews where what was merged might differ from what was originally proposed in the spec in Juno.</blockquote><div><br></div><div><font size="2"><span style="background-color:rgba(255,255,255,0)">Matt, appreciate you pushing on this.</span></font><div><font size="2"><span style="background-color:rgba(255,255,255,0)"><br></span></font></div><div><font size="2"><span style="background-color:rgba(255,255,255,0)">Happy to approve moving that spec to kilo so the docs are easier.</span></font></div><div><font size="2"><span style="background-color:rgba(255,255,255,0)"><br></span></font></div><div><font size="2"><span style="background-color:rgba(255,255,255,0)">But you do hit on a general issue with no tracking for spec-less blueprints. Maybe putting a stub spec in to document all the blueprint less specs would help here?</span></font></div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
3. Is the Hyper-V CI now testing with gen-2 images?</blockquote><div><br></div>Good question. Also does it still test some gen-1 too?<div><br></div><div>Thanks,</div><div>John</div><div><br><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt Riedemann<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div>