<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Apr 25, 2015 at 6:28 AM, Jay Pipes <span dir="ltr"><<a href="mailto:jaypipes@gmail.com" target="_blank">jaypipes@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 04/24/2015 04:33 PM, Ryan Brown wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 04/24/2015 03:00 PM, Julien Danjou wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I like that point and I agree with you. The problem, as someone already<br>
stated, is that these people are rarely on IRC and sometimes just never<br>
reply on the review. Right, maybe next time I'll chase them down via<br>
email. Sometimes I wish we were a little more conservative about who<br>
could do code review, but well.<br>
</blockquote>
<br>
I'm pretty heavily against limiting who can code review. There are some<br>
less-than-helpful reviewers about, but putting up barriers is the wrong<br>
way to go about fixing it.<br>
<br>
Education is the way to go, and it's ok if there's some nominal level of<br>
somewhat unhelpful reviews so long as, when possible, we try to teach<br>
those reviewers how they can be more helpful.<br>
</blockquote>
<br></span>
+1<span class="HOEnZb"><font color="#888888"><br>
<br>
-jay</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div><div class="gmail_extra"><div class="gmail_default" style="font-family:monospace,monospace">Just my 2 cents, I sometimes give a "0" score when asking questions, sometimes a -1. It's subjective based on whether *I* believe it may or may not have an impact on the code and whether the patch works. Could be an oversight by the committer etc. </div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">That being said, people do LOVE hitting that -1 button it seems, which is annoying at times.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">As others have said, the last thing I want to do is discourage reviews of any sort from anybody. Personally I want people to ask questions, and frankly there's three or four people on this list saying how terrible -1 with questions is, but I seem to recall each of them at least once providing me with a prompt -1 with questions in patches I've submitted (just saying). Sometimes it's tedious, sometimes it's down right infuriating... but there are also times where it makes me think about what I'm doing rather than just *hacking* out some short term fix on something, or gives me an idea to make a patch better.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Some may be warranted, some may not... I'd rather error on the side of "it matters" for the most part. No offense to anybody but if you have this happen to you multiple times in a week, over and over, maybe there is something about your code, commit-messages or comments in your code that just isn't doing it for people? Or maybe it's crap... I don't know, but again might be good to keep an open mind about it.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Also, personally this sort of thing is why I avoid the -1 filters when looking at code reviews. Now if I open the review that has a -1 and see it's from somebody I have a good deal of faith in, I *might* ignore it, but even then I want to see what they "found", and maybe improve my own reviewing/commit habits. <span style="font-size:small">Kinda dangerous IMO that we're sort of developing a clique, or belief that anybody is infallible, and that we shouldn't have to communicate or explain our work to anybody.</span></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">On that note, maybe folks on this list should go look at their review inbox and make sure they're not guilty here, and let the change begin with themselves.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Thanks,</div><div class="gmail_default" style="font-family:monospace,monospace">John</div><br></div></div>