<html><body>
<p><font size="2" face="sans-serif">+1 about Dan's comments.</font><br>
<br>
<br>
<font size="2" face="sans-serif">1. We should not discourage all cases for -1 for questions. Because it often leads more discussion about the code issue, it is helpful for such case.</font><br>
<br>
<font size="2" face="sans-serif">Of course, it is diffcult to find a balance point, what can -1, what can 0.</font><br>
<font size="2" face="sans-serif">I don't think 0 in gerrit works well, because sometimes authors not care about that.</font><br>
<br>
<br>
<br>
<font size="2" face="sans-serif">2. Also, for typos in comments and message, -1 makes sense too. </font><br>
<font size="2" face="sans-serif">Because 0 in gerrit means no need to improve the message and everything is good. It can lead many bad cases for cores, and non-cores. It means it doesn't matter if spell right or wrong.</font><br>
<br>
<br>
<br>
<br>
<br>
<br>
<font size="2" face="sans-serif">Best Wishes,<br>
</font><br>
<font size="2" face="sans-serif">--------------------------------------------------------------------------------</font><br>
<font size="2" face="sans-serif">Follow your heart. You are miracle! </font><br>
<br>
<img width="16" height="16" src="cid:1__=C7BBF4A1DF954E058f9e8a93df938@cn.ibm.com" border="0" alt="Inactive hide details for Dan Smith ---04/24/2015 10:48:45 PM---> In defense of those of us asking questions, I'll just point o"><font size="2" color="#424282" face="sans-serif">Dan Smith ---04/24/2015 10:48:45 PM---> In defense of those of us asking questions, I'll just point out > that as a core reviewer I need t</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">Dan Smith <dms@danplanet.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">"OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">04/24/2015 10:48 PM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [openstack-dev] Please stop reviewing code while asking questions</font><br>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<tt><font size="2">> In defense of those of us asking questions, I'll just point out<br>
> that as a core reviewer I need to be sure I understand the intent<br>
> and wide-ranging ramifications of patches as I review them. Especially<br>
> in the Oslo code, what appears to be a small local change can have<br>
> unintended consequences when the library gets out into the applications.<br>
> <br>
> I will often ask questions like, "what is going to happen in X<br>
> situation if we change this default" or "how does this change in<br>
> behavior affect the case where Y happens, which isn't well tested<br>
> in our unit tests." If those details aren't made clear by the commit<br>
> message and comments in the code, I consider that a good reason to<br>
> include a -1 with a request for the author to provide more detail.<br>
> Often these are cases I'm not intimately familiar with, so I ask a<br>
> question rather than saying outright that I think something is<br>
> broken because I expect to learn from the answer but I still have<br>
> doubts that I want to indicate with the -1.<br>
> <br>
> Most of the time the author has thought about the issues and worked<br>
> out a reason they are not a problem, but they haven't explained<br>
> that anywhere. On the other hand, it is frequently the case that<br>
> someone *hasn't* understood why a change might be bad and the<br>
> question ends up leading to more research and discussion.<br>
<br>
Right, and -1 makes the comment much more visible to both other cores<br>
and the reviewer. Questions which rightly point out something which<br>
would lead to what the OP considers a legit -1 can *easily* get missed<br>
in the wash of review comments on a bug.<br>
<br>
If you leave a -1 for a question and never come back to drop it when the<br>
answer is provided, then that's bad and you should stop doing that.<br>
However, I'm really concerned about the suggestion to not -1 for<br>
questions in general because of the visibility we lose. I also worry<br>
that more non-core people will feel even less likely to -1 a patch for<br>
something they feel is just their failing to understand, when in fact<br>
it's valuable feedback that the code is obscure.<br>
<br>
As a core, I don't exclude all reviews with a -1, and doing so is pretty<br>
dangerous behavior, IMHO.<br>
<br>
I'm not sure if the concern of -1s for questions is over dropping the<br>
review out of the hitlist for cores, or if it's about hurting the<br>
feelings of the submitter. I'm not in favor of discouraging -1s for<br>
either problem.<br>
<br>
--Dan<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe<br>
</font></tt><tt><font size="2"><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></font></tt><tt><font size="2"><br>
<br>
</font></tt><br>
</body></html>