<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 24, 2015 at 10:06 AM, Salvatore Orlando <span dir="ltr"><<a href="mailto:sorlando@nicira.com" target="_blank">sorlando@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On 24 April 2015 at 16:50, Chris Friesen <span dir="ltr"><<a href="mailto:chris.friesen@windriver.com" target="_blank">chris.friesen@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On 04/24/2015 07:26 AM, Salvatore Orlando wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If you think it might be beneficial to adjust tooling to that these<br>
"contributions" get counted this is fine by me. I just wanted to point out that<br>
I do not consider those contributions at all (and btw it would be at least more<br>
polite to put a +1 rather than a -1).<br>
</blockquote>
<br></span>
If you're asking a question to elicit information, then it's quite possible you don't have enough information for a +1 yet.</blockquote><div><br></div></span><div>This makes sense in general. I was referring to the specific cases posed by Julien - curiosities, pedantry, or questions unrelated to the scope of the patch.<br></div><div>Julien clarified that there actually questions which grant a -1, and surely never a +1. For instance the kind of "what if" questions listed by Doug. In this case it make sense for a reviewer to put a hold a patch while waiting for an answer.</div><span class=""><div><br></div></span></div></div></div></blockquote><div><br></div><div>Would anybody be willing to codify this into a document that we can point offenders to so that we can get better review quality over time? Maybe <a href="http://docs.openstack.org/infra/manual/developers.html#peer-review">http://docs.openstack.org/infra/manual/developers.html#peer-review</a> (was <a href="https://wiki.openstack.org/wiki/ReviewChecklist">https://wiki.openstack.org/wiki/ReviewChecklist</a> ).<br></div><div><br></div><div>(Just don't be surprised when some joker posts a question with a -1 on the review.)<br></div><div><br></div><div>- Brant<br><br></div></div></div></div>