<html><body>
<p><font size="2" face="sans-serif">Hi Madhuri,</font><br>
<br>
<font size="2" face="sans-serif">1) I think we'd better not jump to v1beta3 API if our image not updated. </font><br>
<br>
<font size="2" face="sans-serif">In release, we need to provide person with easy to use and function works well.</font><br>
<br>
<br>
<font size="2" face="sans-serif">As you mentioned, the v1beta3 not work with our image with many issues.</font><br>
<br>
<br>
<br>
<font size="2" face="sans-serif">2) If we could update our image, which integrate the latests k8s 0.15.0 release, I support to use v1beta3.</font><br>
<font size="2" face="sans-serif">@sdake may knows how to update image, maybe others also, I not know much about it how to update such image.</font><br>
<br>
<br>
<font size="2" face="sans-serif">Thanks</font><br>
<br>
<br>
<font size="2" face="sans-serif">Best Wishes,</font><br>
<font size="2" face="sans-serif">--------------------------------------------------------------------------------</font><br>
<font size="2" face="sans-serif">Kai Qiang Wu (吴开强 Kennan）<br>
</font><br>
<font size="2" face="sans-serif">--------------------------------------------------------------------------------</font><br>
<font size="2" face="sans-serif">Follow your heart. You are miracle! </font><br>
<br>
<img width="16" height="16" src="cid:1__=C7BBF4BCDFA51EBB8f9e8a93df938@cn.ibm.com" border="0" alt="Inactive hide details for Madhuri Rai ---04/22/2015 05:36:08 PM---Hi All, As we are using fedora-21-atomic-2 image and that has"><font size="2" color="#424282" face="sans-serif">Madhuri Rai ---04/22/2015 05:36:08 PM---Hi All, As we are using fedora-21-atomic-2 image and that has Kubernetes v0.11.0, I</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">Madhuri Rai <madhuri.rai07@gmail.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">"OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">04/22/2015 05:36 PM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [openstack-dev] [magnum] swagger-codegen generated code for python-k8sclient</font><br>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<font size="3" face="serif">Hi All,<br>
<br>
As we are using fedora-21-atomic-2 image and that has Kubernetes v0.11.0, I tried to run v1beta3 APIs on it. Some of the APIs failed.<br>
The Kubernetes developer said "v1beta3 wasn't fully supported until the 0.15.0 release". Hence this is causing some APIs to fail.<br>
<br>
Below are the failures:<br>
<br>
1. service-create API fail(422 status) with v1beta3 request format.<br>
The request format has changed from v1beta1 to v1beta3.<br>
</font><a href="https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/api.md#v1beta3-conversion-tips" target="_blank"><font size="3" color="#0000FF" face="serif"><u>https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/api.md#v1beta3-conversion-tips</u></font></a><font size="3" face="serif"><br>
<br>
I have logged an issue for the same at GoogleCloudPlatform/Kubernetes:<br>
</font><a href="https://github.com/GoogleCloudPlatform/kubernetes/issues/7157"><font size="3" color="#0000FF" face="serif"><u>https://github.com/GoogleCloudPlatform/kubernetes/issues/7157</u></font></a><font size="3" face="serif"><br>
<br>
2. pod-create API fail(500 status) with invalid request format.<br>
While doing negative testing, I found that pod-create API fails with 500 status. It should actually fail with 400 status.<br>
<br>
I have logged an issue for the same at GoogleCloudPlatform/Kubernetes:<br>
</font><a href="https://github.com/GoogleCloudPlatform/kubernetes/issues/7087" target="_blank"><font size="3" color="#0000FF" face="serif"><u>https://github.com/GoogleCloudPlatform/kubernetes/issues/7087</u></font></a><font size="3" face="serif"><br>
<br>
3. pod-update API fail(404).<br>
While trying to update a pod</font><font size="3" face="serif"><b>, </b></font><font size="3" face="serif">it failed with status 404 even if the pod exists. This is due to duplicate replacePod API in Kubernetes Client code.<br>
<br>
I have logged an issue for the same at GoogleCloudPlatform/Kubernetes:<br>
</font><a href="https://github.com/GoogleCloudPlatform/kubernetes/issues/7100" target="_blank"><font size="3" color="#0000FF" face="serif"><u>https://github.com/GoogleCloudPlatform/kubernetes/issues/7100</u></font></a><font size="3" face="serif"><br>
<br>
4. All APIs fail with json manifest.<br>
All Kubernetes resources(pod, rc, service) now fails with json format manifest due to issue in swagger-codegen generated Kubernetes Client code.<br>
It doesn't support unicode string.<br>
<br>
After all this issues, can we really switch to Kubernetes Client in this release or should we wait for the Fedora image with Kubernetes 0.15.0 release that has full support of v1beta3?<br>
<br>
Please provide your suggestions on this so that I can proceed further.<br>
</font><br>
<font size="2" face="Arial">Thanks & Regards<br>
Madhuri Kumari</font><font size="2" face="Arial"><b><br>
</b></font><br>
<br>
<font size="3" face="serif">On Tue, Mar 24, 2015 at 10:37 AM, Madhuri Rai <</font><a href="mailto:madhuri.rai07@gmail.com" target="_blank"><font size="3" color="#0000FF" face="serif"><u>madhuri.rai07@gmail.com</u></font></a><font size="3" face="serif">> wrote:</font>
<ul style="padding-left: 9pt"><font size="3" face="serif">Hi Hongbin,<br>
</font><br>
<br>
<font size="3" face="serif">On Tue, Mar 24, 2015 at 12:37 AM, Hongbin Lu <</font><a href="mailto:hongbin034@gmail.com" target="_blank"><font size="3" color="#0000FF" face="serif"><u>hongbin034@gmail.com</u></font></a><font size="3" face="serif">> wrote:</font>
<ul style="padding-left: 9pt"><font size="3" face="serif">Hi Madhuri,</font><br>
<br>
<font size="3" face="serif">Amazing work! I wouldn't concern the code duplication and modularity issue since the codes are generated. However, there is another concern here: if we find a bug/improvement of the generated code, we probably need to modify the generator. The question is if the upstream will accept the modifications? If yes, how fast the patch will go through.</font><br>
<br>
<font size="3" face="serif">I would prefer to maintain a folk of the generator. By this way, we would have full control of the generated code. Thoughts?</font></ul>
<br>
<font size="3" face="serif">I agree that's a concern. I will try to fix the pep8 error upstream to look how it take to push a change upstream.<br>
</font>
<ul style="padding-left: 9pt"><br>
<font size="3" face="serif">Thanks,</font><br>
<font size="3" face="serif">Hongbin</font><br>
<br>
<font size="3" face="serif">On Mon, Mar 23, 2015 at 10:11 AM, Steven Dake (stdake) <</font><a href="mailto:stdake@cisco.com" target="_blank"><font size="3" color="#0000FF" face="serif"><u>stdake@cisco.com</u></font></a><font size="3" face="serif">> wrote:</font>
<ul style="padding-left: 9pt"><br>
<br>
<font size="2" face="Calibri"><b>From: </b></font><font size="2" face="Calibri">Madhuri Rai <</font><a href="mailto:madhuri.rai07@gmail.com" target="_blank"><font size="2" color="#0000FF" face="Calibri"><u>madhuri.rai07@gmail.com</u></font></a><font size="2" face="Calibri">></font><font size="2" face="Calibri"><b><br>
Reply-To: </b></font><font size="2" face="Calibri">"OpenStack Development Mailing List (not for usage questions)" <</font><a href="mailto:openstack-dev@lists.openstack.org" target="_blank"><font size="2" color="#0000FF" face="Calibri"><u>openstack-dev@lists.openstack.org</u></font></a><font size="2" face="Calibri">></font><font size="2" face="Calibri"><b><br>
Date: </b></font><font size="2" face="Calibri">Monday, March 23, 2015 at 1:53 AM</font><font size="2" face="Calibri"><b><br>
To: </b></font><font size="2" face="Calibri">"</font><a href="mailto:openstack-dev@lists.openstack.org" target="_blank"><font size="2" color="#0000FF" face="Calibri"><u>openstack-dev@lists.openstack.org</u></font></a><font size="2" face="Calibri">" <</font><a href="mailto:openstack-dev@lists.openstack.org" target="_blank"><font size="2" color="#0000FF" face="Calibri"><u>openstack-dev@lists.openstack.org</u></font></a><font size="2" face="Calibri">></font><font size="2" face="Calibri"><b><br>
Subject: </b></font><font size="2" face="Calibri">[openstack-dev] [magnum] swagger-codegen generated code for python-k8sclient</font><br>
<ul style="padding-left: 36pt"><font size="2" face="Calibri">Hi All,<br>
<br>
This is to have a discussion on the blueprint for implementing python-k8client for magnum.<br>
<br>
</font><a href="https://blueprints.launchpad.net/magnum/+spec/python-k8sclient" target="_blank"><font size="2" color="#0000FF" face="Calibri"><u>https://blueprints.launchpad.net/magnum/+spec/python-k8sclient</u></font></a><font size="2" face="Calibri"><br>
<br>
I have committed the code generated by swagger-codegen at </font><a href="https://review.openstack.org/#/c/166720/" target="_blank"><font size="2" color="#0000FF" face="Calibri"><u>https://review.openstack.org/#/c/166720/</u></font></a><font size="2" face="Calibri">.<br>
But I feel the quality of the code generated by swagger-codegen is not good.<br>
<br>
Some of the points:<br>
1) There is lot of code duplication. If we want to generate code for two or more versions, same code is duplicated for each API version.<br>
2) There is no modularity. CLI code for all the APIs are written in same file.<br>
<br>
So, I would like your opinion on this. How should we proceed further?</font></ul>
<br>
<font size="2" face="Calibri">Madhuri,</font><br>
<br>
<font size="2" face="Calibri">First off, spectacular that you figured out how to do this! Great great job! I suspected the swagger code would be a bunch of garbage. Just looking over the review, the output isn’t too terribly bad. It has some serious pep8 problems.</font><br>
<br>
<font size="2" face="Calibri">Now that we have seen the swagger code generator works, we need to see if it produces useable output. In other words, can the API be used by the magnum backend. Google is “all-in” on swagger for their API model. Realistically maintaining a python binding would be a huge job. If we could just use swagger for the short term, even though its less then ideal, that would be my preference. Even if its suboptimal. We can put a readme in the TLD saying the code was generated by a a code generator and explain how to generate the API.</font><br>
<br>
<font size="2" face="Calibri">One last question. I didn’t see immediately by looking at the api, but does it support TLS auth? We will need that.</font><br>
<br>
<font size="2" face="Calibri">Super impressed!</font><br>
<br>
<font size="2" face="Calibri">Regards</font><br>
<font size="2" face="Calibri">-steve</font><br>
<br>
<ul style="padding-left: 36pt"><font size="2" face="Calibri"><br>
Regards,<br>
Madhuri Kumari</font></ul>
<br>
<font size="3" face="serif">__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: </font><a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank"><font size="3" color="#0000FF" face="serif"><u>OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</u></font></a><font size="3" color="#0000FF" face="serif"><u><br>
</u></font><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank"><font size="3" color="#0000FF" face="serif"><u>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</u></font></a><font size="3" face="serif"><br>
</font></ul>
<br>
<font size="3" face="serif"><br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: </font><a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank"><font size="3" color="#0000FF" face="serif"><u>OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</u></font></a><font size="3" color="#0000FF" face="serif"><u><br>
</u></font><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank"><font size="3" color="#0000FF" face="serif"><u>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</u></font></a><font size="3" face="serif"><br>
</font></ul>
<font size="3" face="serif">Regards,</font><br>
<font size="3" face="serif">Madhuri Kumari</font></ul>
<tt><font size="2">__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe<br>
</font></tt><tt><font size="2"><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></font></tt><tt><font size="2"><br>
</font></tt><br>
</body></html>