<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Two weeks ago, the patch <a href="https://review.openstack.org/#/c/164329/">
https://review.openstack.org/#/c/164329/</a> was merged to stable/juno. This patch fixes bug <a href="https://launchpad.net/bugs/1414218">https://launchpad.net/bugs/1414218</a> on the stable/juno branch. This patch removed LOG.debug statements from the for-loop
of method _<i>output</i>_hosts_file() in file neutron/agent/Linux/dhcp.py. Without the LOG.debug statements in the for-loop, the performance of dhcp agent updates improves significantly.
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">As it stands currently, neutron on the stable/juno branch behaves as if
<a href="https://review.openstack.org/#/c/164329/">https://review.openstack.org/#/c/164329/</a> was never merged. The merge of patch <a href="https://review.openstack.org/#/c/153181">https://review.openstack.org/#/c/153181</a> puts some LOG.debug statements
in the for-loop of the same function. The net result is the unintentional revert of patch
<a href="https://review.openstack.org/#/c/164329/">https://review.openstack.org/#/c/164329/</a>. <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">According to review.openstack.org, the patch <a href="https://review.openstack.org/#/c/153181">
https://review.openstack.org/#/c/153181</a> merged on April 1st at 1:56 pm. Patch
<a href="https://review.openstack.org/#/c/164329/">https://review.openstack.org/#/c/164329/</a> merged on the same day at 2:21 pm. After 153181 merged, the review of 164329 should have triggered a merge conflict error which would have compelled the owner
to do a rebase. The merge conflict wasn’t reported and the patches merged anyway. Does this point to a problem with the Jenkins CI system?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Note that this is only a problem on the neutron stable/juno branch. I filed bug https://bugs.launchpad.net/neutron/+bug/1445202 to have the LOG.debug statements taken out. The review is
<a href="https://review.hpcloud.net/#/c/174596">https://review.hpcloud.net/#/c/174596</a>.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>