<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 26, 2015 at 12:22 AM, Monty Taylor <span dir="ltr"><<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div id=":n5" class="" style="overflow:hidden">git review is used by a ton of people who write in non-python. I think<br>
adding openstack-specific style enforcement to it would make it way less<br>
generally useful.</div></blockquote></div><br><br></div><div class="gmail_extra">I think if we wanted to do that we could just extend git-review run_scripts thing[1] to read tox.ini or other shipped with the project file to run the pre-review script from it.<br><br></div><div class="gmail_extra">Chmouel<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">PS: I haven't looked at yapf so i have not much opinion about it.<br></div><div class="gmail_extra"><br>[1] <a href="https://git.openstack.org/cgit/openstack-infra/git-review/tree/git_review/cmd.py?h=master#n229">https://git.openstack.org/cgit/openstack-infra/git-review/tree/git_review/cmd.py?h=master#n229</a><br></div></div>