<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>Hi,</div>
<div>Until now all changes to the API’s have been made in separate extensions and not in the base. These should actually be on the provider networks extension.</div>
<div>First this code is not supported by any of the plugins other than the ML2 (I am not sure if this break things – it certain broke the unit tests). Secondly these two changes do not have open source reference implementations (but that is digressing from
the problem).</div>
<div>I really think that we need to revert these and have the extensions done in the standard fasion.</div>
<div>Thanks</div>
<div>Gary</div>
<div><br>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Brandon Logan <<a href="mailto:brandon.logan@RACKSPACE.COM">brandon.logan@RACKSPACE.COM</a>><br>
<span style="font-weight:bold">Reply-To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Thursday, March 19, 2015 at 6:20 PM<br>
<span style="font-weight:bold">To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Neutron] Neutron extenstions<br>
</div>
<div><br>
</div>
<div><style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
<div dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Isn't this argument as to whether those fields should be turned off/on, versus just always being on? Are there any guidelines as to what fields are allowed to be added in that base resource attr map? If ML2 needs these and other fields, should they just
always be on?<br>
</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Brandon<br>
</p>
<div style="word-wrap:break-word">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri,sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Doug Wiegley <<a href="mailto:dougwig@parksidesoftware.com">dougwig@parksidesoftware.com</a>><br>
<b>Sent:</b> Thursday, March 19, 2015 11:01 AM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] [Neutron] Neutron extenstions</font>
<div> </div>
</div>
<div>
<div class="">Hi Gary,</div>
<div class=""><br class="">
</div>
First I’m seeing these, but I don’t see that they’re required on input, unless I’m mis-reading those reviews. Additional of new output fields to a json object, or adding optional inputs, is not generally considered to be backwards incompatible behavior in
an API. Does OpenStack have a stricter standard on that?
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">doug<br class="">
<div class=""><br class="">
</div>
<div class=""><br class="">
<div class="">
<div>
<blockquote type="cite" class="">
<div class="">On Mar 19, 2015, at 6:37 AM, Gary Kotton <<a href="mailto:gkotton@vmware.com" class="">gkotton@vmware.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="word-wrap:break-word; font-size:14px; font-family:Calibri,sans-serif">
<div class="">Hi,</div>
<div class="">Changed the subject so that it may draw a little attention.</div>
<div class="">There were 2 patches approved that kind of break the API (in my humble opinion):</div>
<div class=""><a href="https://review.openstack.org/#/c/154921" class="">https://review.openstack.org/#/c/154921</a>/ and <a href="https://review.openstack.org/#/c/158420" class="">https://review.openstack.org/#/c/158420</a>/ </div>
<div class="">In both of these two new fields were added to the base attributes – mtu and vlan_transparency</div>
<div class="">Reverts for them are:</div>
<div class=""><a href="https://review.openstack.org/165801" class="">https://review.openstack.org/165801</a> (mtu) and <a href="https://review.openstack.org/165776" class="">https://review.openstack.org/165776</a> (vlan transparency).</div>
<div class="">In my opinion these should be added as separate extensions.</div>
<div class="">Thanks</div>
<div class="">Gary</div>
<div class=""><br class="">
</div>
<span id="OLK_SRC_BODY_SECTION" class="">
<div class="" style="font-family:Calibri; font-size:11pt; text-align:left; border-width:1pt medium medium; border-style:solid none none; padding:3pt 0in 0in; border-top-color:rgb(181,196,223)">
<span class="" style="font-weight:bold">From: </span>Gary Kotton <<a href="mailto:gkotton@vmware.com" class="">gkotton@vmware.com</a>><br class="">
<span class="" style="font-weight:bold">Reply-To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org" class="">openstack-dev@lists.openstack.org</a>><br class="">
<span class="" style="font-weight:bold">Date: </span>Thursday, March 19, 2015 at 2:32 PM<br class="">
<span class="" style="font-weight:bold">To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org" class="">openstack-dev@lists.openstack.org</a>><br class="">
<span class="" style="font-weight:bold">Subject: </span>Re: [openstack-dev] [Neutron] VLAN transparency support<br class="">
</div>
<div class=""><br class="">
</div>
<div class="">
<div class="" style="word-wrap:break-word; font-size:14px; font-family:Calibri,sans-serif">
<div class="">Hi,</div>
<div class="">This patch has the same addition too - <a href="https://review.openstack.org/#/c/154921" class="">https://review.openstack.org/#/c/154921</a>/. We should also revert that one.</div>
<div class="">Thanks</div>
<div class="">Gary</div>
<div class=""><br class="">
</div>
<span id="OLK_SRC_BODY_SECTION" class="">
<div class="" style="font-family:Calibri; font-size:11pt; text-align:left; border-width:1pt medium medium; border-style:solid none none; padding:3pt 0in 0in; border-top-color:rgb(181,196,223)">
<span class="" style="font-weight:bold">From: </span>Gary Kotton <<a href="mailto:gkotton@vmware.com" class="">gkotton@vmware.com</a>><br class="">
<span class="" style="font-weight:bold">Reply-To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org" class="">openstack-dev@lists.openstack.org</a>><br class="">
<span class="" style="font-weight:bold">Date: </span>Thursday, March 19, 2015 at 1:14 PM<br class="">
<span class="" style="font-weight:bold">To: </span>OpenStack List <<a href="mailto:openstack-dev@lists.openstack.org" class="">openstack-dev@lists.openstack.org</a>><br class="">
<span class="" style="font-weight:bold">Subject: </span>[openstack-dev] [Neutron] VLAN transparency support<br class="">
</div>
<div class=""><br class="">
</div>
<div class="">
<div class="" style="word-wrap:break-word; font-size:14px; font-family:Calibri,sans-serif">
<div class="">Hi,</div>
<div class="">It appears that <a href="https://review.openstack.org/#/c/158420" class="">https://review.openstack.org/#/c/158420</a>/ update the base attributes for the networks. Is there any reason why this was not added as a separate extension like all others.</div>
<div class="">I do not think that this is the correct way to go and we should do this as all other extensions have been maintained. I have posted a revert (<a href="https://review.openstack.org/#/c/165776" class="">https://review.openstack.org/#/c/165776</a>/)
– please feel free to knack if it is invalid.</div>
<div class="">Thanks</div>
<div class="">Gary</div>
</div>
</div>
</span></div>
</div>
</span></div>
__________________________________________________________________________<br class="">
OpenStack Development Mailing List (not for usage questions)<br class="">
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" class="">
OpenStack-dev-request@lists.openstack.org</a>?subject:unsubscribe<br class="">
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" class="">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</span>
</body>
</html>