<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 11, 2015 at 8:17 PM, Chen, Wei D <span dir="ltr"><<a href="mailto:wei.d.chen@intel.com" target="_blank">wei.d.chen@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Stefano,<br>
<br>
Thanks so much for your detailed answer, I finally know the reason why those patches are not reviewed in this cycle.<br>
Actually, this BP (<a href="https://blueprints.launchpad.net/python-cinderclient/+spec/support-modify-volume-image-metadata" target="_blank">https://blueprints.launchpad.net/python-cinderclient/+spec/support-modify-volume-image-metadata</a>) is created very<br>
early around Nov. 2014, and there is BP even earlier before that<br>
(<a href="https://blueprints.launchpad.net/python-cinderclient/+spec/support-volume-image-metadata" target="_blank">https://blueprints.launchpad.net/python-cinderclient/+spec/support-volume-image-metadata</a>) which is created around May 2014.<br>
<br>
Maybe they just believe this is not such important and not worth to take time to review. Hope those patches could be reviewed in<br>
'L'.<br>
<br>
Best Regards,<br>
Dave Chen<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> -----Original Message-----<br>
> From: Stefano Maffulli [mailto:<a href="mailto:stefano@openstack.org">stefano@openstack.org</a>]<br>
> Sent: Tuesday, March 10, 2015 10:14 PM<br>
> To: <a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a><br>
> Subject: Re: [openstack-dev] [cinder]difference between spec merged and BP approval<br>
><br>
> Hi David,<br>
><br>
> On Sat, 2015-03-07 at 02:22 +0000, Chen, Wei D wrote:<br>
> > I thought the feature should be approved as long as the SPEC[1] is<br>
> > merged, but it seems I am wrong from the beginning[2], both of them<br>
> > (SPEC merged and BP approval[4][5]) is necessary and mandatory for<br>
> > getting some effective reviews, right? anyone can help to confirm with<br>
> > that?<br>
><br>
> Since Cinder uses BP+spec, the process is described on the wiki page:<br>
><br>
> <a href="https://wiki.openstack.org/wiki/Blueprints#Spec_.2B_Blueprints_lifecycle" target="_blank">https://wiki.openstack.org/wiki/Blueprints#Spec_.2B_Blueprints_lifecycle</a><br>
><br>
> If it helps, I'd consider the spec and the blueprint as "one" element made of two pieces. The spec needs to be "approved" and<br>
> its corresponding blueprint needs to be approved and have a priority, deadline/milestone assigned. If any of these attributes<br>
> is missing, the feature is not going to be reviewed.<br>
><br>
> Blueprints and their attributes 'priority' and 'milestone' are used to track the status of the release. The reviewers use BPs to<br>
> identify the code that they need to review. For example,<br>
> <a href="https://launchpad.net/cinder/+milestone/kilo-3" target="_blank">https://launchpad.net/cinder/+milestone/kilo-3</a><br>
><br>
> I've tried to piece the history of your experience from the links you<br>
> provided:<br>
><br>
> - you submitted the spec in November 2014<br>
> - the spec was approved on Jan 6, 2015 (from<br>
> <a href="https://review.openstack.org/#/c/136253/" target="_blank">https://review.openstack.org/#/c/136253/</a>)<br>
> - the spec references two blueprints, one for Cinder, one of Cinder-client; both BPs were created at the end of February<br>
> - none of the BP have a milestone set<br>
> - you submitted code related to the approved spec between Jan 6 and today<br>
><br>
> I have the impression that you may have missed a step in the BP+spec process. I have tried to find the documentation for this<br>
> process myself and I had a hard time, too.<br>
><br>
> > Besides, who is eligible to define/modify the priority in the list[3],<br>
> > only PTL or any core? I am trying to understand the acceptable<br>
> > procedure for the coming 'L'.<br>
><br>
> The project team leaders (PTL) are ultimately responsible to set the priorities, although the decision is always a consensual<br>
> decision of the core teams.<br>
><br>
> Have you considered joining OpenStack Upstream Training?<br>
> <a href="https://www.openstack.org/blog/2015/02/openstack-upstream-training-in-vancouver/" target="_blank">https://www.openstack.org/blog/2015/02/openstack-upstream-training-in-vancouver/</a><br>
><br>
> Cheers,<br>
> stef<br>
><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><div class="gmail_default" style="font-family:monospace,monospace">First I'd like to thank Stef for the clear explanation; second I'd like to apologize Dave if you're feeling like nobody cares or don't feel your patch is that important. That's really not the case, it's just a matter of scheduling and priorities and honestly sometimes there's just more in the pipeline than we're able to actually process.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">I did notice that the bulk of your bp did in fact merge so that's good. Things like the cinderclient are a special case and don't have the same deadlines or prioritization. I'll take a look at what you have submitted again tomorrow, in the meantime you might want to jump on IRC at #openstack-cinder and look up myself or even better thingee who is the PTL for the Cinder project. There's plenty of core folks who should be willing and able to talk through some of the process stuff with you and discuss your patch.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Also keep in mind that we have a weekly meeting on IRC that is intended to provide a forum for topics exactly like this and help us from letting things slip through the cracks.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Thanks,</div><div class="gmail_default" style="font-family:monospace,monospace">John</div><br></div></div>