<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-03-06 13:49 GMT+08:00 GHANSHYAM MANN <span dir="ltr"><<a href="mailto:ghanshyammann@gmail.com" target="_blank">ghanshyammann@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi Sean,<div><br></div><div>That is very nice idea to keep only 1 set of tests and run those twice via tox.</div><div><br></div><div>Actually my main goal was-</div><div>- 1. Create clean sample file structure for V2. V2.1 and micro-versions</div><div> Something like below-</div><div> api_samples/</div><div> extensions/</div><div> v2.0/ - v2 sample files</div><div> v2.1/ - v2.1 sample files</div><div> v2.2/ - v2.2 sample files</div><div> and so on</div><div><br></div><div>- 2. Merge sample files between v2 and v2.1.</div><div><br></div><div>But your idea is much better which almost covers mine (except dir structure for microversion which can/should be work after that).</div></div></blockquote><div><br></div><div>++ for Sean's idea. One sample tests is best. And in normally we should keep the v2 API sample tests to ensure v2.1 totally compatible with v2. But really like the currently v2.1 API sample tests is each file per extension, not like v2 all the extension in a huge file... So I think we need keep the v2.1 api sample tests, and make the v2 API running on it.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>As there are many extensions merged/split from v2 -> v2.1, we need to twist tests to work for both v2 and v2.1.</div><div>For exmple, v2 flavor-swap, flavor-disable, flavor-extraData has been merged to single flavor plugin in v2.1.</div><div><br></div><div>So running v2.1 flavor tests for v2 needs above extensions to be enabled in that tests. It looks something like - <a href="https://review.openstack.org/#/c/162016/" target="_blank">https://review.openstack.org/#/c/162016/</a> </div></div></blockquote><div><br></div><div>Yea...good point and great work! I think all of ours hate those twist, but no choice...</div><div><br></div><div>Actually for the extension mapping between v2.1 and v2, we already have mapping at:</div><div><a href="https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/extension_info.py#L29">https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/extension_info.py#L29</a></div><div><br></div><div>So can we use this mapping to twist tests in the base class? Then we needn't twist a lot of extension.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><span class=""><div><br></div><div>-- </div><div>Thanks & Regards</div><div>Ghanshyam Mann</div></span><div><div class="h5"><div class="gmail_extra"><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div class="gmail_extra"><div><div><br></div></div></div><div class="gmail_extra">On Fri, Mar 6, 2015 at 7:00 AM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:</div><div class="gmail_extra">On 03/04/2015 07:48 PM, GHANSHYAM MANN wrote:</div><div class="gmail_extra">> Hi Sean,</div><div class="gmail_extra">></div><div class="gmail_extra">> Yes having V3 directory/file names is very confusing now.</div><div class="gmail_extra">></div><div class="gmail_extra">> But current v3 sample tests cases tests v2.1 plugins. As /v3 url is</div><div class="gmail_extra">> redirected to v21 plugins, v3 sample tests make call through v3 url and</div><div class="gmail_extra">> test v2.1 plugins.</div><div class="gmail_extra">></div><div class="gmail_extra">> I think we can start cleaning up the *v3* from everywhere and change it</div><div class="gmail_extra">> to v2.1 or much appropriate name.</div><div class="gmail_extra">></div><div class="gmail_extra">> To cleanup the same from sample files, I was planning to rearrange</div><div class="gmail_extra">> sample files structure. Please check if that direction looks good (still</div><div class="gmail_extra">> need to release patch for directory restructure)</div><div class="gmail_extra">></div><div class="gmail_extra">> <a href="https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z" target="_blank">https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z</a></div><div class="gmail_extra"><br></div><div class="gmail_extra">I had another chat with Alex this morning on IRC. I think my confusion</div><div class="gmail_extra">is that I don't feel like I understand how we get down to 1 set of API</div><div class="gmail_extra">samples in the tree based on that set of posted patches.</div><div class="gmail_extra"><br></div><div class="gmail_extra">It seems like there should only be 1 set of samples in docs/ and one set</div><div class="gmail_extra">of templates. I would also argue that we should only have 1 set of tests</div><div class="gmail_extra">(though that I'm mid term flexible on).</div><div class="gmail_extra"><br></div><div class="gmail_extra">It seems that if our concern is that both the v2 and v21 endpoints need</div><div class="gmail_extra">to have the same results, we could change the functional tox target to</div><div class="gmail_extra">run twice, once with v2 and once with v21 set as the v2 endpoint.</div><div class="gmail_extra">Eventually we'll be able to drop v2 on v2.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Anyway, in order to both assist my own work unwinding the test tree, and</div><div class="gmail_extra">to help review your work there, can you lay out your vision for cleaning</div><div class="gmail_extra">this up with all the steps involved? Hopefully that will cut down the</div><div class="gmail_extra">confusion and make all this work move faster.</div><div class="gmail_extra"><font color="#888888"><br></font></div><div class="gmail_extra"><span style="color:rgb(136,136,136)"> -Sean</span></div><div class="gmail_extra"><font color="#888888"><br></font></div><div class="gmail_extra"><span style="color:rgb(136,136,136)">--</span></div><div class="gmail_extra"><span style="color:rgb(136,136,136)">Sean Dague</span></div><div class="gmail_extra"><a href="http://dague.net" target="_blank">http://dague.net</a></div><div class="gmail_extra"><font color="#888888"><br></font></div><div class="gmail_extra"><span style="color:rgb(136,136,136)">______________________________</span><span style="color:rgb(136,136,136)">______________________________</span><span style="color:rgb(136,136,136)">______________</span></div><div class="gmail_extra"><span style="color:rgb(136,136,136)">OpenStack Development Mailing List (not for usage questions)</span></div><div class="gmail_extra"><span style="color:rgb(136,136,136)">Unsubscribe: </span><a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a></div><div class="gmail_extra"><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></div></blockquote></div><div class="gmail_extra"><br><br clear="all"><div><br></div><br><div><div><div><br></div></div></div>
</div></div></div></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>