<div dir="ltr"><div>Hi,</div><div><br></div><div>I believe that keeping review queue clean is the great idea. </div><div>But I am not sure that set of these rules is enough to abandon patches.</div><div> </div><div>Recently I wrote blogpost related to making OpenStack community more user friendly:</div><div><a href="http://boris-42.me/thoughts-on-making-openstack-community-more-user-friendly/">http://boris-42.me/thoughts-on-making-openstack-community-more-user-friendly/</a><br></div><div><br></div><div>tl;dr;</div><div><br></div><div>Patches on review are great source of information what is missing in project.</div><div>Removing them from queue means losing this essential information. The result</div><div>of such actions is that project doesn't face users requirements which is quite bad...</div><div><br></div><div>What if that project team continue work on all "abandoned" patches that are covering </div><div>valid use cases and finish them?</div><div><br></div><div>Best regards,</div><div>Boris Pavlovic </div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 13, 2015 at 3:52 PM, Flavio Percoco <span dir="ltr"><<a href="mailto:flavio@redhat.com" target="_blank">flavio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 13/02/15 11:06 +0000, Kuvaja, Erno wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
We have almost year old (from last update) reviews still in the queue for<br>
glance. The discussion was initiated on yesterday’s meeting for adopting<br>
abandon policy for stale changes.<br>
<br>
The documentation can be found from <a href="https://etherpad.openstack.org/p/" target="_blank">https://etherpad.openstack.<u></u>org/p/</a><br>
glance-cleanout-of-inactive-PS and any input would be appreciated. For your<br>
convenience current state below:<br>
<br>
</blockquote>
<br></span>
Thanks for putting this together. I missed the meeting yday and this<br>
is important.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
Glance - Cleanout of inactive change proposals from review<br>
<br>
<br>
We Should start cleaning out our review list to keep the focus on changes that<br>
has momentum. Nova is currently abandoning change proposals that has been<br>
inactive for 4 weeks.<br>
<br>
<br>
<br>
Proposed action (if all of the following is True, abandon the PS):<br>
<br></span>
1. The PS has -1/-2 (including Jenkins)<br>
</blockquote>
<br>
I assume you're talking about voting -1/-2 and not Workflow, right?<br>
(you said jenkins afterall but just for the sake of clarity).<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2. The change is proposed to glance, glance_store or python-glanceclient;<span class=""><br>
specs should not be abandoned as their workflow is much slower<br>
<br></span>
3. No activity for 28 days from Author/Owner after the -1/-2<br>
</blockquote>
<br>
I'd reword this in "No activity". This includes comments, feedback,<br>
discussions and or other committers taking over a patch.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
4. There has been query made to the owner to update the patch between 5 and<span class=""><br>
10 days before abandoning (comment on PS/Bug or something similar)<br>
<br>
● Let's be smart on this. Flexibility is good on holiday seasons, during<br>
feature freeze, etc.<br>
</span></blockquote>
<br>
+2 to the above, I like it.<br>
<br>
Thanks again,<br>
Flavio<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
@flaper87<br>
Flavio Percoco<br>
</font></span><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>