<div dir="ltr">That's good to know, but I'm still just the weensiest bit confused. The code is unreachable and unusable -- which is a bit more forceful than just redundant or deprecated. Can it be removed? Does Zhi Yan have plans to do that? Is there anything I can do to help?<div><br></div><div>Thanks!</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 13, 2015 at 5:19 AM, Flavio Percoco <span dir="ltr"><<a href="mailto:flavio@redhat.com" target="_blank">flavio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 12/02/15 09:34 -0800, Chris St. Pierre wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yeah, that commit definitely disables the file-backed queue -- it certainly<br>
*looks* like we want to be rid of it, but all of the code is left in place and<br>
even updated to support the new format. So my confusion remains. Hopefully Zhi<br>
Yan can clarify.<br>
<br>
Link added. Thanks.<br>
</blockquote>
<br>
<br></span>
Hi Chris,<br>
<br>
I touched bases with Zhi Yan and my understanding is right. Since<br>
Juno, we switched to using a queue based on database instead of file<br>
and the file queue is considered redundant and on its way to be<br>
deprecated.<br>
<br>
I'll also reply on the review,<div class="HOEnZb"><div class="h5"><br>
Thanks for bringing this up,<br>
Flavio<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Thu, Feb 12, 2015 at 12:59 AM, Flavio Percoco <<a href="mailto:flavio@redhat.com" target="_blank">flavio@redhat.com</a>> wrote:<br>
<br>
On 11/02/15 13:42 -0800, Chris St. Pierre wrote:<br>
<br>
I recently proposed a change to glance to turn the file-backed scrubber<br>
queue<br>
files into JSON: <a href="https://review.openstack.org/#/c/145223/" target="_blank">https://review.<u></u>openstack.org/#/c/145223/</a><br>
<br>
As I looked into it more, though, it turns out that the file-backed<br>
queue is no<br>
longer usable; it was killed by the implementation of this<br>
blueprint: https://<br>
<a href="http://blueprints.launchpad.net/glance/+spec/image-location-status" target="_blank">blueprints.launchpad.net/<u></u>glance/+spec/image-location-<u></u>status</a><br>
<br>
But what's not clear is if the implementation of that blueprint should<br>
have<br>
killed the file-backed scrubber queue, or if that was even intended.<br>
Two things<br>
contribute to the lack of clarity:<br>
<br>
1. The file-backed scrubber code was left in, even though it is<br>
unreachable.<br>
<br>
2. The ordering of the commits is strange. Namely, commit 66d24bb<br>
(https://<br>
<a href="http://review.openstack.org/#/c/67115/" target="_blank">review.openstack.org/#/c/<u></u>67115/</a>) killed the file-backed queue, and<br>
then,<br>
*after* that change, 70e0a24 (<a href="https://review.openstack.org/#/c/67122/" target="_blank">https://review.openstack.org/<u></u>#/c/67122/</a>)<br>
updates<br>
the queue file format. So it's not clear why the queue file format<br>
would be<br>
updated if it was intended that the file-backed queue was no longer<br>
usable.<br>
<br>
Can someone clarify what was intended here? If killing the file-backed<br>
scrubber<br>
queue was deliberate, then let's finish the job and excise that code.<br>
If not,<br>
then let's make sure that code is reachable again, and I'll resurrect<br>
my<br>
blueprint to make the queue files suck less.<br>
<br>
Either way I'm happy to make the changes, I'm just not sure what the<br>
goal of<br>
these changes was, and how to properly proceed.<br>
<br>
Thanks for any clarification anyone can offer.<br>
<br>
<br>
I believe the commit you're looking for is this one:<br>
f338a5c870a36e493f8c818fa78394<u></u>2d1e0565a4<br>
<br>
There the scrubber queue was switched on purpose, which leads to the<br>
conclusion that we're moving away from it. I've not participated in<br>
discussions around the change related to the scrubber queue so I'll<br>
let Zhi Yan weight in here.<br>
<br>
Thanks for bringing this up,<br>
Flavio<br>
<br>
P.S: Would you mind putting a link to this discussion on the spec<br>
review?<br>
<br>
<br>
<br>
<br>
<br>
--<br>
Chris St. Pierre<br>
<br>
<br>
______________________________<u></u>______________________________<u></u>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="mailto:OpenStack-dev-request@lists.openstack.org" target="_blank">OpenStack-dev-request@lists.<u></u>openstack.org</a>?<br>
subject:unsubscribe<br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
<br>
<br>
<br>
--<br>
@flaper87<br>
Flavio Percoco<br>
______________________________<u></u>______________________________<u></u>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.<u></u>openstack.org?subject:<u></u>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
<br>
<br>
<br>
<br>
<br>
--<br>
Chris St. Pierre<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
______________________________<u></u>______________________________<u></u>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.<u></u>openstack.org?subject:<u></u>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote>
<br>
<br>
-- <br>
@flaper87<br>
Flavio Percoco<br>
</div></div><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Chris St. Pierre</div>
</div>