<div dir="ltr">Why did the services fail with the stdlib patched? Are they incompatible with eventlet?</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 12, 2015 at 11:25 AM, Ihar Hrachyshka <span dir="ltr"><<a href="mailto:ihrachys@redhat.com" target="_blank">ihrachys@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Hi all,<br>
<br>
there were some moves recently to make monkey patching strategy sane<br>
in neutron.<br>
<br>
This was triggered by some bugs found when interacting with external<br>
oslo libraries [1], and a cross project spec to make eventlet usage<br>
sane throughout the project [2].<br>
<br>
Specifically, instead of monkey patching stdlib in each of services<br>
and agents (and forgetting to do so for some of them [3]), we should<br>
monkey patch it as part of a common import (ideally, it would be any<br>
neutron.* import).<br>
<br>
Initially, we've tried to patch it inside neutron/__init__.py [4], but<br>
it didn't place nice with some advanced services importing from<br>
neutron while not expecting stdlib to be patched, and so was reverted.<br>
<br>
So an alternative that I currently look into is "the Nova way".<br>
Specifically, moving all main() functions for all agents and services<br>
into neutron/cmd/... and monkey patching stdlib thru<br>
neutron/cmd/__init__.py.<br>
<br>
I've sent a series of patches to do just that [5]. It was rightfully<br>
blocked by Mark to seek for broader agreement.<br>
<br>
I encourage community to say your word on the direction.<br>
<br>
[1]: <a href="https://bugs.launchpad.net/oslo.concurrency/+bug/1418541" target="_blank">https://bugs.launchpad.net/oslo.concurrency/+bug/1418541</a><br>
[2]: <a href="https://review.openstack.org/154642" target="_blank">https://review.openstack.org/154642</a><br>
[3]:<br>
<a href="http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/mlnx/agent/eswitch_neutron_agent.py" target="_blank">http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/mlnx/agent/eswitch_neutron_agent.py</a><br>
[4]: <a href="https://review.openstack.org/153699" target="_blank">https://review.openstack.org/153699</a><br>
[5]:<br>
<a href="https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bug/1418541,n,z" target="_blank">https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bug/1418541,n,z</a><br>
<br>
Cheers,<br>
/Ihar<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1<br>
<br>
iQEcBAEBAgAGBQJU3P4QAAoJEC5aWaUY1u57A/cH/AuKbkewZy5Z0Hus2m4bClGp<br>
4DJ37ygcY9HwGmJTLpvUyfRcDWnaO9S+6sj28Ebv49MN1w9qJ4MuQmaYA1xsFERb<br>
aR6uKgnkiIT0FS8CVjbClEC7gN5elHCe2dcB8cakrk7uUsTJ2LP5A6rdNQqly/uN<br>
2hkdfa1WBcAYMX6raFWD8DJ49R1MhbPr09YXXU9ApoflMY6ZywvNBzwIZEw5gqPO<br>
Vpjb9DwevaFZ9kqzjHTrXk47CqOSYS7ZXQjS1bOGUOJFOBqNRLzl2qPX7wkBiA2N<br>
12U4Qe3/3MvWwBig0O+mY2RwN2OtnxhK8X5tP6kbrybyOKLGUe4ZgIlvfQHI33Q=<br>
=8pX5<br>
-----END PGP SIGNATURE-----<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div>Kevin Benton</div></div>
</div>