<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 11, 2015 at 5:15 AM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Feb 11, 2015 at 12:03:58PM +0100, Pasquale Porreca wrote:<br>
> Thank you for all answers.<br>
> I know that meta data tags are "free" to use with any key/value, still<br>
> there are some specific values that triggers pieces of code in nova (or<br>
> maybe even in other components). In particular I am working on one of<br>
> these key/value, in my case it should enable the<br>
><br>
> <bios rebootTimeout=value/><br>
><br>
> parameter in libvirt. Anyway even if my code is merged, no one will know<br>
> about it (except myself and the reviewers) if it is not documented<br>
> somewhere. A DocImpact flag was added to the commit message, but I still<br>
> don't know how to proper document it. I may create/update existing wiki<br>
> pages, but I would have preferred an official documentation: I was not<br>
> able to find the wiki page proposed by Daniel Berrange, even if I had<br>
> been searching exactly to something similar :(<br>
> It is very good that there is a work to objectify image meta, anyway is<br>
> there any recommendation how to document it in the meanwhile?<br>
<br>
</span>For people submitting patches to nova the expectation is simply that they<br>
add DocImpact and have a commit message that describes the usage of the<br>
new property. The docs team work from this data. </blockquote><div><br></div><div>Technically, DocImpact creates a doc bug for the Launchpad project indicated in a configuration file. It's not always an indicator for the doc team to work from, it is the responsibility of each project to take care of their impactful doc bugs.</div><div><br></div><div>For example, there were over 50 new bugs logged last week, and no way for a centralized doc team to keep up with the incoming DocImpact requests, not even to triage.</div><div><br></div><div>So please, spread the word wide and far that DocImpact is merely a mechanism to track that further doc work is needed for the feature to be completed.</div><div><br></div><div>Thanks,</div><div>Anne </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There's no current formal<br>
docs that I'd expect you to be editing/updating.<br>
<span class=""><br>
> I would also know if there is any naming convention for image meta and<br>
> flavor extra-spec keys: in my case I used hw_reboot_timeoutand<br>
> hw:reboot_timeout respectively, but it is more a bios than hardware<br>
> feature and they are handled in nova/virt/libvirt/driver.py rather than<br>
> nova/virt/hardware.py so maybe the name choice was not so good.<br>
<br>
</span>In terms of image metadata, broadly speaking, we're aiming to standardize<br>
on 3 name prefixes in Nova<br>
<br>
'hw' - stuff that affects guest hardware configuration (this includes<br>
the BIOS settings, since that's hardware firmware)<br>
'os' - stuff that affects the guest operating system setup<br>
'img' - stuff Nova uses related to managing images<br>
<br>
So, your choice of 'hw_reboot_timeout' for image and 'hw:reboot_timeout'<br>
for the flavour is correct.<br>
<span class="im HOEnZb"><br>
Regards,<br>
Daniel<br>
--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
<br>
</span><div class="HOEnZb"><div class="h5">__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Anne Gentle<br><a href="mailto:annegentle@justwriteclick.com" target="_blank">annegentle@justwriteclick.com</a></div>
</div></div>