<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 5, 2015 at 11:24 PM, Kekane, Abhishek <span dir="ltr"><<a href="mailto:Abhishek.Kekane@nttdata.com" target="_blank">Abhishek.Kekane@nttdata.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-IN" link="blue" vlink="purple">
<div>
<p class="MsoNormal">Hi Devs,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">This change is not backward compatible and to do not break OpenStack services which are using cinder-client,<u></u><u></u></p>
<p class="MsoNormal">we need to first make provision in these consumer services to handle cinder-client return type change.<u></u><u></u></p>
<p class="MsoNormal">To make this cinder-client change backward compatible we need to do changes in consumers of cinder-client like patch :
<a href="https://review.openstack.org/#/c/152820/" target="_blank">https://review.openstack.org/#/c/152820/</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Also for backward compatibility can we make changes suggested by Gary W. Smith on cinder-spec :
<a href="https://review.openstack.org/#/c/132161/6/" target="_blank">https://review.openstack.org/#/c/132161/6/</a>.<u></u><u></u></p>
<p class="MsoNormal">As per his suggestion we need to add one new optional kwarg 'return_req_id' in cinder-client api methods, when it is 'True' cinder-client will returns the tuple, but when False (the default) it returns the current value (i.e.- only response
body).<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">For example cinder-client 'get' method will look like -<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"> def _get(self, url, response_key=None, return_req_id=False):<u></u><u></u></p>
<p class="MsoNormal"> resp, body = self.api.client.get(url)<u></u><u></u></p>
<p class="MsoNormal"> if response_key:<u></u><u></u></p>
<p class="MsoNormal"> body = self.resource_class(self, body[response_key], loaded=True)<u></u><u></u></p>
<p class="MsoNormal"> else:<u></u><u></u></p>
<p class="MsoNormal"> body = self.resource_class(self, body, loaded=True)<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> if return_req_id:<u></u><u></u></p>
<p class="MsoNormal"> # return tuple containing headers and body<u></u><u></u></p>
<p class="MsoNormal"> return (resp.headers, body)<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> return body<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">If we want headers from cinder-client then we need to pass kwarg 'return_req_id' as True from caller.<u></u><u></u></p>
<p class="MsoNormal">For example from nova we need to call cinder-client get method as -<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"> resp_header, volume = cinderclient(context).volumes.get(volume_id, return_req_id=True)<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">With this optional kwarg 'return_req_id' approach we do not need to make changes in services which are using cinder-client.<u></u><u></u></p>
<p class="MsoNormal">It will be backward compatible change.</p></div></div></blockquote><div><br></div><div>Maintaining backwards compatibility is very important. Making return_req_id optional sounds like a good solution going forward. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-IN" link="blue" vlink="purple"><div><p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Could you please give your suggestion on this approach.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Abhishek<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Joe Gordon [mailto:<a href="mailto:joe.gordon0@gmail.com" target="_blank">joe.gordon0@gmail.com</a>]
<br>
<b>Sent:</b> 05 February 2015 22:50<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Subject:</b> Re: [openstack-dev] [python-cinderclient] Return request ID to caller<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Wed, Feb 4, 2015 at 11:23 PM, Malawade, Abhijeet <<a href="mailto:Abhijeet.Malawade@nttdata.com" target="_blank">Abhijeet.Malawade@nttdata.com</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">Hi,<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I have submitted patch for cinder-client [1] to 'Return tuple containing header and body from client' instead of just response.<u></u><u></u></p>
<p class="MsoNormal">Also cinder spec for the same is under review [2].<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">This change will break OpenStack services which are using cinder-client. To do not break services which are using cinder-client,<u></u><u></u></p>
<p class="MsoNormal">we need to first make changes in those projects to check return type of cinder-client. We are working on doing cinder-client return<u></u><u></u></p>
<p class="MsoNormal">type check changes in OpenStack services like nova, glance_store, heat, trove, manila etc.<u></u><u></u></p>
<p class="MsoNormal">We have already submitted patch for same against nova :
<a href="https://review.openstack.org/#/c/152820/" target="_blank">https://review.openstack.org/#/c/152820/</a><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">[1]
<a href="https://review.openstack.org/#/c/152075/" target="_blank">https://review.openstack.org/#/c/152075/</a><u></u><u></u></p>
<p class="MsoNormal">[2]
<a href="https://review.openstack.org/#/c/132161/" target="_blank">https://review.openstack.org/#/c/132161/</a><u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This sounds like a backwards incompatible change to the python client, that will break downstream consumers of python-cinderclient. This change should be done in a way that allows us to deprecate the old usage without breaking it right
away.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I want to seek early feedback from the community members on the above patches, so please give your thoughts on the same.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">Abhijeet Malawade<u></u><u></u></p>
</div>
<p class="MsoNormal"><br>
______________________________________________________________________<br>
Disclaimer: This email and any attachments are sent in strictest confidence<br>
for the sole use of the addressee and may contain legally privileged,<br>
confidential, and proprietary data. If you are not the intended recipient,<br>
please advise the sender by replying promptly to this email and then delete<br>
and destroy this email and any attachments without any further use, copying<br>
or forwarding.<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">
OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div><div><div class="h5">
<br clear="both">
______________________________________________________________________<br>
Disclaimer: This email and any attachments are sent in strictest confidence<br>
for the sole use of the addressee and may contain legally privileged,<br>
confidential, and proprietary data. If you are not the intended recipient,<br>
please advise the sender by replying promptly to this email and then delete<br>
and destroy this email and any attachments without any further use, copying<br>
or forwarding.<br>
</div></div></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div></div>