<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">
<!--
p
{margin-top:0;
margin-bottom:0}
p
{margin-top:0;
margin-bottom:0}
-->
P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">I have failed to add Chris Yeoh. Hope it's fine now..<br>
<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF877622"><font color="#000000" size="2" face="Tahoma"><b>From:</b> Claudiu Belu [cbelu@cloudbasesolutions.com]<br>
<b>Sent:</b> Wednesday, February 04, 2015 5:10 PM<br>
<b>To:</b> OpenStack Development Mailing List (not for usage questions)<br>
<b>Cc:</b> xuhj@linux.vnet.ibm.com<br>
<b>Subject:</b> Re: [openstack-dev] [nova][api] How to handle API changes in contrib/*.py<br>
</font><br>
</div>
<div></div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Bump.<br>
<br>
Also, added to CC Alex Xu and Chris Yeoh.<br>
<br>
Cheers!<br>
Claudiu Belu<br>
<br>
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr tabindex="-1">
<div id="divRpF302363" style="direction:ltr"><font color="#000000" size="2" face="Tahoma"><b>From:</b> Claudiu Belu [cbelu@cloudbasesolutions.com]<br>
<b>Sent:</b> Tuesday, February 03, 2015 12:51 AM<br>
<b>To:</b> openstack-dev@lists.openstack.org<br>
<b>Subject:</b> [openstack-dev] [nova][api] How to handle API changes in contrib/*.py<br>
</font><br>
</div>
<div></div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hello!<br>
<br>
There have been some discussion on what nova-api should return after a change in the API itself.<br>
<br>
So, the change that generated this discussion is an API change to 2.2 is:<br>
<a href="https://review.openstack.org/#/c/140313/23" target="_blank">https://review.openstack.org/#/c/140313/23</a><br>
<br>
- **2.2**<br>
<br>
Added Keypair type.<br>
<br>
A user can request the creation of a certain 'type' of keypair (ssh or x509).<br>
<br>
If no keypair type is specified, then the default 'ssh' type of keypair is<br>
created.<br>
<br>
Currently, this change was done on <b>plugins/v3/keypairs.py</b>, so now, the 2.2 version will also return the keypair type on keypair-list, keypair-show, keypair-create.<br>
<br>
Microversioning was used, so this behaviour is valid only if the user requests the 2.2 version. Version 2.1 will not accept keypair type as argument, nor will return the keypair type.<br>
<br>
Now, the main problem is <b>contrib/keypairs.py</b>, microversioning cannot be applied there. The current commit filters the keypair type, it won't be returned. But there have been reviews stating that returning the keypair type is a "back-compatible change".
Before this, there was a review stating that keypair type should not be returned.<br>
<br>
So, finally, my question is: how should the API change be handled in <b>contrib/keypairs.py</b>?<br>
<br>
Best regards, <br>
<br>
Claudiu Belu<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>