<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-02-03 22:40 GMT+08:00 Eduard Matei <span dir="ltr"><<a href="mailto:eduard.matei@cloudfounders.com" target="_blank">eduard.matei@cloudfounders.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br clear="all"><div>Hi team,</div><div><br></div><div>We have some questions regarding the Gerrit workflow and what should we do next for our patch to be merged:</div><div>1. Once we have a CodeReview +2 and a Jenkins Verified +1 what should we do next to get the patch merged?</div></div></blockquote><div> We need at least two code review + 2 and will approved by core reviewer. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>2. If we have a CodeReview +2 and we want to fix an issue, does the next patchset keep the CR +2 ?</div></div></blockquote><div> will not keep +2 if change code except a rebase. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>3. Once the patch is merged, if we have further changes do we have to create a new patch (blueprint/bug report)?</div></div></blockquote><div> Yes ,need another commit ( bug or blueprint report) <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Thanks,</div><div>Eduard</div><div><br></div>-- <br><div><div dir="ltr"><pre style="white-space:pre-wrap;font-size:10px;word-wrap:break-word;margin-top:0px;margin-bottom:0px"><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><b><span style="font-size:10pt;font-family:Arial,sans-serif" lang="EN-US">Eduard Biceri Matei, Senior Software Developer</span></b></div><div style="color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><span style="font-size:13.5pt;font-family:Helvetica,sans-serif"><a href="http://www.cloudfounders.com/" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"><font color="#0045a3">www.cloudfounders.com</font></span></a><div style="display:inline-block;width:16px;min-height:16px"></div><div style="display:inline-block;width:16px;min-height:16px"></div></span><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"><font color="#1f497d"> | </font><a href="mailto:eduard.matei@cloudfounders.com" style="color:rgb(17,85,204)" target="_blank"><font color="#0045a3">eduard.matei@cloudfounders.com</font></a></span></div><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)" lang="EN-US"><u></u> <u></u></span></div><br><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><span style="font-size:13.5pt;font-family:Arial,sans-serif;color:rgb(80,0,80)" lang="EN-US"><u></u> <u></u></span></div><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><b><span style="font-size:13.5pt;font-family:Arial,sans-serif" lang="EN-US">CloudFounders, The Private Cloud Software Company</span></b><span style="font-size:13.5pt;font-family:Arial,sans-serif" lang="EN-US"><u></u><u></u></span></div><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><span style="font-size:13.5pt;font-family:Helvetica,sans-serif" lang="EN-US"><u></u> <u></u></span></div><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><span style="font-family:Helvetica,sans-serif;font-size:11px" lang="EN-US">Disclaimer:<u></u><u></u></span></div><div style="font-family:arial,sans-serif;font-size:13px;text-align:-webkit-auto;white-space:normal;margin:0px"><span style="font-size:8.5pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)" lang="EN-US">This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed.</span><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)" lang="EN-US"><br><span style="font-size:11px">If you are not the named addressee or an employee or agent responsible for delivering this message to the named addressee, you are hereby notified that you are not authorized to read, print, retain, copy or disseminate this message or any part of it. If you have received this email in error we request you to notify us by reply e-mail and to delete all electronic files of the message. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. <br>E-mail transmission cannot be guaranteed to be secure or error free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the content of this message, and shall have no liability for any loss or damage suffered by the user, which arise as a result of e-mail transmission.</span></span></div></pre></div></div>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div>ChangBo Guo(gcb)</div></div></div>
</div></div>