<div dir="ltr">Right, there are two bugs here. One is in whatever went wrong with defer_apply and one is with this exception handling code. I would allow the fix to go in for the exception handling and then file another bug for the actual underlying defer_apply bug.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 22, 2015 at 10:32 AM, Brian Haley <span dir="ltr"><<a href="mailto:brian.haley@hp.com" target="_blank">brian.haley@hp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 01/22/2015 01:06 PM, Kevin Benton wrote:<br>
> There was a bug for this already.<br>
> <a href="https://bugs.launchpad.net/bugs/1413111" target="_blank">https://bugs.launchpad.net/bugs/1413111</a><br>
<br>
</span>Thanks Kevin. I added more info to it, but don't think the patch proposed there<br>
is correct. Something in the iptables manager defer_apply() code isn't quite right.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Brian<br>
</font></span><span class="im HOEnZb"><br>
<br>
> On Thu, Jan 22, 2015 at 9:07 AM, Brian Haley <<a href="mailto:brian.haley@hp.com">brian.haley@hp.com</a><br>
</span><div class="HOEnZb"><div class="h5">> <mailto:<a href="mailto:brian.haley@hp.com">brian.haley@hp.com</a>>> wrote:<br>
><br>
> On 01/22/2015 10:17 AM, Carl Baldwin wrote:<br>
> > I think this warrants a bug report. Could you file one with what you<br>
> > know so far?<br>
><br>
> Carl,<br>
><br>
> Seems as though a recent change introduced a bug. This is on a devstack<br>
> I just created today, at l3/vpn-agent startup:<br>
><br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent Traceback (most<br>
> recent call last):<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent File<br>
> "/opt/stack/neutron/neutron/common/utils.py", line 342, in call<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent return<br>
> func(*args, **kwargs)<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent File<br>
> "/opt/stack/neutron/neutron/agent/l3/agent.py", line 584, in process_router<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent<br>
> self._process_external(ri)<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent File<br>
> "/opt/stack/neutron/neutron/agent/l3/agent.py", line 576, in _process_external<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent<br>
> self._update_fip_statuses(ri, existing_floating_ips, fip_statuses)<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent UnboundLocalError:<br>
> local variable 'existing_floating_ips' referenced before assignment<br>
> 2015-01-22 11:55:07.961 4203 TRACE neutron.agent.l3.agent<br>
> Traceback (most recent call last):<br>
> File "/usr/local/lib/python2.7/dist-packages/eventlet/greenpool.py", line<br>
> 82, in _spawn_n_impl<br>
> func(*args, **kwargs)<br>
> File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 1093, in<br>
> _process_router_update<br>
> self._process_router_if_compatible(router)<br>
> File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 1047, in<br>
> _process_router_if_compatible<br>
> self._process_added_router(router)<br>
> File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 1056, in<br>
> _process_added_router<br>
> self.process_router(ri)<br>
> File "/opt/stack/neutron/neutron/common/utils.py", line 345, in call<br>
> self.logger(e)<br>
> File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line<br>
> 82, in __exit__<br>
> six.reraise(self.type_, self.value, self.tb)<br>
> File "/opt/stack/neutron/neutron/common/utils.py", line 342, in call<br>
> return func(*args, **kwargs)<br>
> File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 584, in<br>
> process_router<br>
> self._process_external(ri)<br>
> File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 576, in<br>
> _process_external<br>
> self._update_fip_statuses(ri, existing_floating_ips, fip_statuses)<br>
> UnboundLocalError: local variable 'existing_floating_ips' referenced before<br>
> assignment<br>
><br>
> Since that's happening while we're holding the iptables lock I'm assuming<br>
> no rules are being applied.<br>
><br>
> I'm looking into it now, will file a bug if there isn't already one.<br>
><br>
> -Brian<br>
<br>
<br>
</div></div><div class="HOEnZb"><div class="h5">__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div>Kevin Benton</div></div>
</div>