<div dir="ltr">I don't believe we have any unit tests that create namespaces or veth pairs. This sounds like it belongs with functional tests.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 20, 2015 at 10:20 AM, Numan Siddique <span dir="ltr"><<a href="mailto:numan.siddique@enovance.com" target="_blank">numan.siddique@enovance.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<font face="monospace">Hello,<br>
<br>
I am working on a bug [1] on neutron vpnaas and submitted the
patch here [2].<br>
<br>
The test code to test the fix does the following<br>
- creates a namespace<br>
- creates a veth pair and add one interface into the namespace<br>
- configures the interface with an ip address and<br>
- adds a default gateway<br>
- and of course tests the code.<br>
<br>
This test code only tests a specific function (</font><font face="monospace">
<span style="color:rgb(102,0,102);font-family:monospace;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:pre-wrap;word-spacing:0px;display:inline!important;float:none;background-color:rgb(255,255,255)">OpenSwanProcess.</span>_get_nexthop())<br>
</font><font face="monospace"><font face="monospace"><br>
Reviewers of this patch are not clear if this should be part of
functional tests or unit tests.<br>
</font>Can unit tests create linux namespaces, interfaces etc or
it falls under functional tests?<br>
<br>
Please let me know your thoughts on this.<br>
<br>
[1] - <a href="https://bugs.launchpad.net/neutron/+bug/1405413" target="_blank">https://bugs.launchpad.net/neutron/+bug/1405413</a><br>
[2] - <a href="https://review.openstack.org/#/c/145005/5" target="_blank">https://review.openstack.org/#/c/145005/5</a><br>
<br>
<br>
Regards<span class="HOEnZb"><font color="#888888"><br>
Numan<br>
<br>
</font></span></font>
</div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div>Kevin Benton</div></div>
</div>