<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On 27 Dec 2014, at 01:39, W Chan <<a href="mailto:m4d.coder@gmail.com" class="">m4d.coder@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><pre style="margin-top:1.5em;margin-bottom:1.5em;padding:0px;border:0px;font-size:12px;font-family:'andale mono','lucida console',monospace;vertical-align:baseline;white-space:pre-wrap;font-stretch:normal;line-height:18.0018005371094px;color:rgb(83,83,83)" class="">> What you’re saying is that whatever is under “$.env” is just the exact same environment that we passed when we started the workflow? If yes then it definitely makes sense to me (it just allows to explicitly access environment, not through the implicit variable lookup). Please confirm.</pre></div><div class="">Yes. the $.env that I original proposed would be the same dict as the one supplied at start_workflow. Although we have to agree whether the variables in the environment are allowed to change after the WF started. Unless there's a valid use case, I would lean toward making env immutable.</div></div></div></blockquote><div><br class=""></div><div>Let’s make them immutable. </div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">> <span style="color:rgb(83,83,83);font-family:'andale mono','lucida console',monospace;font-size:12px;line-height:18.0018005371094px;white-space:pre-wrap" class="">One thing that I strongly suggest is that we clearly define all reserved keys like “env”, “__actions” etc. I think it’d be better if they all started with the same prefix, for example, double underscore.</span></div><div class=""><span style="color:rgb(83,83,83);font-family:'andale mono','lucida console',monospace;font-size:12px;line-height:18.0018005371094px;white-space:pre-wrap" class=""><br class=""></span></div><div class="">Agree. How about using double underscore for env as well (i.e. $.__env.var1, $.__env.var2)?<br class=""></div></div></div></blockquote></div><br class=""><div class="">Yes.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div class="">Renat Akhmerov</div><div class="">@ Mirantis Inc.</div></div><div class=""><br class=""></div></body></html>